fix(indexer): key hybrid route cache on resolved discount tier (#283) #751

Merged

Brouie merged 1 commit from qa/283-solver-cache-key-tier into main

2026-06-05 03:20:43 +00:00

Brouie commented

2026-06-05 01:35:17 +00:00

(Migrated from gitlab.com)

Follow-up on #283, your "key on the sender's discount tier" direction.

hybrid_cache_key (route_solver.rs) keyed on trader only; maybe_simulate forwards both trader and sender to the router and the on-chain discount depends on the subject's tier. So two callers with trader unset but different senders on different tiers collided on the cache key and could be served each other's (wrong-discount) quote.

Resolve the discount subject (trader if set, else sender) and look up its tier from the already-synced traders.tier_id (no extra LCD), then fold the tier into the key. Same-tier callers still share the cache (your intent); different tiers can't collide. hybrid_cache_key stays pure/sync — the async tier lookup is in the caller. Test hybrid_cache_key_distinguishes_discount_tier added.

Scoped to the cache-key correctness; the deeper sender / is_trusted_router tracking stays in #279's cache phase as flagged. No closing keyword.

Follow-up on #283, your "key on the sender's discount tier" direction. `hybrid_cache_key` (route_solver.rs) keyed on `trader` only; `maybe_simulate` forwards both `trader` and `sender` to the router and the on-chain discount depends on the subject's tier. So two callers with `trader` unset but different senders on different tiers collided on the cache key and could be served each other's (wrong-discount) quote. Resolve the discount subject (`trader` if set, else `sender`) and look up its tier from the already-synced `traders.tier_id` (no extra LCD), then fold the tier into the key. Same-tier callers still share the cache (your intent); different tiers can't collide. `hybrid_cache_key` stays pure/sync — the async tier lookup is in the caller. Test `hybrid_cache_key_distinguishes_discount_tier` added. Scoped to the cache-key correctness; the deeper sender / is_trusted_router tracking stays in #279's cache phase as flagged. No closing keyword.

Rows
Columns