test(frontend): fix stale Claim-all confirm assertion in placements panel (#253) #736

Merged

Brouie merged 1 commit from qa/253-claim-all-panel-test-stale into main

2026-06-03 01:59:00 +00:00

Brouie commented

2026-06-02 16:08:27 +00:00

(Migrated from gitlab.com)

Test-only fix for a red test on main, found while verifying #253.

LimitOrderMyPlacementsPanel.test.tsx asserted the exact Claim-all confirm string, but #259 (2e6f2cf) added a gas-estimate suffix to that copy ("... Est. ~X LUNC gas (saves ~Y LUNC vs N separate claims).") without updating this panel test — so it has failed since that merge:

expected '...in one transaction?'
received '...in one transaction? Est. ~15.86 LUNC gas (saves ~9.63 LUNC vs 2 separate claims).'

The feature is fine; this is a stale assertion. Match the stable confirm prefix via expect.stringContaining(...). The exact gas copy is already asserted by regex in limitExpiredClaimBatch.test.ts, so the panel test stays decoupled from volatile gas numbers with no coverage loss.

npx vitest run on the three #253 files (useLimitExpiredClaimMutation, limitExpiredClaimBatch, LimitOrderMyPlacementsPanel) -> 13/13.

Relates to #253 / #259. Not a close — the #253 browser Claim-all sign-off is still pending.

Test-only fix for a red test on main, found while verifying #253. `LimitOrderMyPlacementsPanel.test.tsx` asserted the exact Claim-all confirm string, but #259 (2e6f2cf) added a gas-estimate suffix to that copy ("... Est. ~X LUNC gas (saves ~Y LUNC vs N separate claims).") without updating this panel test — so it has failed since that merge: ``` expected '...in one transaction?' received '...in one transaction? Est. ~15.86 LUNC gas (saves ~9.63 LUNC vs 2 separate claims).' ``` The feature is fine; this is a stale assertion. Match the stable confirm prefix via `expect.stringContaining(...)`. The exact gas copy is already asserted by regex in `limitExpiredClaimBatch.test.ts`, so the panel test stays decoupled from volatile gas numbers with no coverage loss. `npx vitest run` on the three #253 files (`useLimitExpiredClaimMutation`, `limitExpiredClaimBatch`, `LimitOrderMyPlacementsPanel`) -> 13/13. Relates to #253 / #259. Not a close — the #253 browser Claim-all sign-off is still pending.

Rows
Columns