code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

fix(swap): copy simulate tx bytes into a plain ArrayBuffer #1363

Merged
PlasticDigits merged 1 commit from fix/simulate-tx-bytes into main 2026-09-27 13:20:40 +00:00
Conversation 2 Commits 1 Files changed 1 +13 -5
PlasticDigits commented 2026-09-27 13:20:00 +00:00
Owner
Copy link

Summary

The frontend image build failed tsc -b after #1361 / #1362. TypeScript 5.9 types protobuf toBinary() as Uint8Array<ArrayBufferLike>, and the simulate tx fields want Uint8Array<ArrayBuffer>.

The encoder now copies those bytes into a plain ArrayBuffer before they are placed on the pubkey and the tx body.

Test plan

  • tsc -b in frontend-dapp
  • terraSimulateTx and swapAutoGas unit tests
## Summary The frontend image build failed `tsc -b` after #1361 / #1362. TypeScript 5.9 types protobuf `toBinary()` as `Uint8Array<ArrayBufferLike>`, and the simulate tx fields want `Uint8Array<ArrayBuffer>`. The encoder now copies those bytes into a plain `ArrayBuffer` before they are placed on the pubkey and the tx body. ## Test plan - [x] `tsc -b` in `frontend-dapp` - [x] `terraSimulateTx` and `swapAutoGas` unit tests
fix(swap): copy simulate tx bytes into a plain ArrayBuffer
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
0c793588c4 
tsc -b on TypeScript 5.9 rejects protobuf toBinary() Uint8Array values when the field wants ArrayBuffer, which failed the frontend image build.
PlasticDigits commented 2026-09-27 13:20:03 +00:00
Author
Owner
Copy link

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue
PlasticDigits commented 2026-09-27 13:20:22 +00:00
Author
Owner
Copy link

drain skip: default autoland requires tip ACCEPT (#77)

drain skip: default autoland requires tip ACCEPT (#77)
PlasticDigits deleted branch fix/simulate-tx-bytes 2026-09-27 13:20:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1363
No description provided.