code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

fix(pair): skip Observe extrapolate on unrepresentable Decimal ratio #1236

Merged
PlasticDigits merged 3 commits from issue/1231 into main 2026-09-12 02:38:43 +00:00
Conversation 2 Commits 3 Files changed 11 +589 -4
PlasticDigits commented 2026-09-11 08:23:11 +00:00
Owner
Copy link

Summary

  • oracle_observe_single forward-extrapolation now uses Decimal::checked_from_ratio (same operand order as oracle_update). Either overflow skips extrapolate and returns last stored cumulatives — same as the zero-reserve branch. No VM panic. No clamp to Decimal::MAX.
  • Execute-path #465 skip is unchanged. Observe price_times_dt / checked_add stay typed Oracle errors. #1224 execute overflow is out of scope.
  • Tests beside oracle_overflow_tests (oracle_observe_overflow_tests). Docs/skill O1231-1–O1231-6. Wasm migrate is ops after merge.

Fixes #1231

Acceptance

  • AC1. Extreme non-zero ratio + Observe extrapolate (seconds_ago == 0 / target after last obs) does not panic; returns last cumulatives.
  • AC2. oracle_update extreme ratio still Ok / skip (#465).
  • AC3. Balanced reserves + dt > 0 still advance cumulatives.
  • AC4. Historical interpolation (two stored obs, no spot ratio) unchanged under extreme live reserves.
  • AC5. extreme_ratio_degrades_gracefully_instead_of_panicking and normal_ratio_still_records_observation stay green.
  • AC6. Observe JSON shape unchanged on the success path (price_a_cumulatives / price_b_cumulatives).

Test plan

  • make verify-issue-1231 (first pass + retest after grep/fmt)
  • cargo test -p cl8y-dex-pair oracle_overflow
  • cargo test -p cl8y-dex-pair oracle_observe
  • cargo test -p cl8y-dex-tests oracle -- --test-threads=1
  • cargo clippy -- -D warnings in smartcontracts
  • make test-contracts: cl8y-dex-tests 504 passed; one pre-existing factory cw2 version pin (1.10.0 vs 1.9.0) unrelated to this change.
  • Reviewer: confirm Observe skip returns last cumulatives, not clamp / not execute rewrite
  • Ops follow-up (not this PR): pair wasm store + migrate
## Summary - `oracle_observe_single` forward-extrapolation now uses `Decimal::checked_from_ratio` (same operand order as `oracle_update`). Either overflow **skips extrapolate** and returns last stored cumulatives — same as the zero-reserve branch. No VM panic. No clamp to `Decimal::MAX`. - Execute-path `#465` skip is unchanged. Observe `price_times_dt` / `checked_add` stay typed `Oracle` errors. `#1224` execute overflow is out of scope. - Tests beside `oracle_overflow_tests` (`oracle_observe_overflow_tests`). Docs/skill **O1231-1–O1231-6**. Wasm migrate is ops after merge. Fixes #1231 ## Acceptance - [x] AC1. Extreme non-zero ratio + Observe extrapolate (`seconds_ago == 0` / target after last obs) does not panic; returns last cumulatives. - [x] AC2. `oracle_update` extreme ratio still `Ok` / skip (#465). - [x] AC3. Balanced reserves + `dt > 0` still advance cumulatives. - [x] AC4. Historical interpolation (two stored obs, no spot ratio) unchanged under extreme live reserves. - [x] AC5. `extreme_ratio_degrades_gracefully_instead_of_panicking` and `normal_ratio_still_records_observation` stay green. - [x] AC6. Observe JSON shape unchanged on the success path (`price_a_cumulatives` / `price_b_cumulatives`). ## Test plan - [x] `make verify-issue-1231` (first pass + retest after grep/fmt) - [x] `cargo test -p cl8y-dex-pair oracle_overflow` - [x] `cargo test -p cl8y-dex-pair oracle_observe` - [x] `cargo test -p cl8y-dex-tests oracle -- --test-threads=1` - [x] `cargo clippy -- -D warnings` in `smartcontracts` - [x] `make test-contracts`: cl8y-dex-tests 504 passed; one pre-existing factory cw2 version pin (`1.10.0` vs `1.9.0`) unrelated to this change. - [ ] Reviewer: confirm Observe skip returns last cumulatives, not clamp / not execute rewrite - [ ] Ops follow-up (not this PR): pair wasm store + migrate
QueryMsg::Observe still used panicking from_ratio after #465 skipped
the execute sample. Use checked_from_ratio and return last cumulatives.
PlasticDigits commented 2026-09-11 22:09:53 +00:00
Author
Owner
Copy link

drain skip: hard-blocked (needs-human / high-risk / human topic); remaining continue

drain skip: hard-blocked (needs-human / high-risk / human topic); remaining continue
ci: add Woodpecker PR gitleaks gate for Forgejo status checks
All checks were successful
ci/woodpecker/pr/woodpecker gitleaks tracked-tree scan passed locally; .woodpecker.yaml added
Details
699c15c1d5
PlasticDigits deleted branch issue/1231 2026-09-12 02:38:43 +00:00
PlasticDigits reviewed 2026-09-12 02:38:44 +00:00
PlasticDigits left a comment
Copy link

Self-review blocked (author). CODEOWNERS team request: PlasticDigits is the only maintainer. AC matches #1231.

Self-review blocked (author). CODEOWNERS team request: PlasticDigits is the only maintainer. AC matches #1231.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1236
No description provided.