Portfolio: hide test-gem Open Positions and P&L by default (#674) #1177

Merged

PlasticDigits merged 1 commit from issue-674-portfolio-hide-test-gems into main

2026-08-27 04:44:31 +00:00

PlasticDigits commented

2026-08-27 00:33:34 +00:00

(Migrated from gitlab.com)

Closes #674

Summary

/portfolio Open Positions, header realized P&L (visible rows), and Recent activity hide soft-launch test gems by default (EMBER, CORAL, JADE, TOPAZ, ONYX, RUBY, PEARL, QUARTZ, plus LocalTerra extras).
Reuses the existing #534 / #562 classifier (isTestPair / isGemTokenId) — no second gem list.
Show test pairs toggle (default off) reveals gem rows under a Test pairs divider so QA can still inspect them.
/trader, LP overview, and open limits stay unfiltered. Indexer JSON is unchanged. total_volume_usd stays the indexer-wide wallet figure.

Test plan

make verify-issue-674
Connected /portfolio with a gem position (e.g. EMBER/CORAL): row hidden by default; header P&L excludes it
Toggle Show test pairs: gem row appears after a Test pairs divider; P&L includes it
Economic pairs (CL8Y, UST1, USTR, cLUNC, cUSTC, vFDUSD) still list
/trader/:addr still shows gem positions without a hide toggle
Open limits and LP overview still show gem pairs / balances
Toggle is absent when the wallet has no gem performance
Playwright e2e/portfolio.spec.ts when LocalTerra is up (disconnected visit does not show the toggle)

Closes #674 ## Summary - `/portfolio` Open Positions, header realized P&L (visible rows), and Recent activity hide soft-launch test gems by default (EMBER, CORAL, JADE, TOPAZ, ONYX, RUBY, PEARL, QUARTZ, plus LocalTerra extras). - Reuses the existing `#534` / `#562` classifier (`isTestPair` / `isGemTokenId`) — no second gem list. - **Show test pairs** toggle (default off) reveals gem rows under a **Test pairs** divider so QA can still inspect them. - `/trader`, LP overview, and open limits stay unfiltered. Indexer JSON is unchanged. `total_volume_usd` stays the indexer-wide wallet figure. ## Test plan - [ ] `make verify-issue-674` - [ ] Connected `/portfolio` with a gem position (e.g. EMBER/CORAL): row hidden by default; header P&L excludes it - [ ] Toggle **Show test pairs**: gem row appears after a **Test pairs** divider; P&L includes it - [ ] Economic pairs (CL8Y, UST1, USTR, cLUNC, cUSTC, vFDUSD) still list - [ ] `/trader/:addr` still shows gem positions without a hide toggle - [ ] Open limits and LP overview still show gem pairs / balances - [ ] Toggle is absent when the wallet has no gem performance - [ ] Playwright `e2e/portfolio.spec.ts` when LocalTerra is up (disconnected visit does not show the toggle)

Rows
Columns