WIP: Draft: feat(frontend): share-link button on /trader/:address (#665) #1171

Closed
PlasticDigits wants to merge 0 commits from 665-feat-frontend-share-link-button-on-trader-address-mobile-web-share-copy- into main
PlasticDigits commented 2026-08-26 07:18:45 +00:00 (Migrated from gitlab.com)

Summary

  • Add a Share control on /trader/:address that sends the canonical same-origin profile URL (origin/trader/{validated-address}), preferring navigator.share and falling back to the existing copyToClipboard helper.
  • Keep Copy trader address as bech32-only. Share stays visible on profile 404 and indexer outage when the path is a valid terra address; it is hidden on empty /trader and invalid segments.
  • Optional TS-11: /portfolio Share emits /trader/{wallet} when connected (never /portfolio). Pair /trade and /charts mounts are not in this MR (helper already supports those kinds).

Closes #665

Test plan

  • make verify-issue-665 (Vitest helper + button + trader/portfolio, chrome nesting, docs/skills, Playwright trader-share-link smoke)
  • AddressRow still copies bech32; Share copies/shares the profile URL
  • /trader empty and invalid segments hide Share
  • Manual 375 + 1280, light + dark: Share visible, focus-visible ring, 44px hit target
  • Manual: Web Share sheet on a capable phone; cancel does not toast; clipboard fallback on desktop
  • Optional: /trade/:pair and /charts/:pair Share mounts (follow-up)

Closes #665

## Summary - Add a **Share** control on `/trader/:address` that sends the canonical same-origin profile URL (`origin/trader/{validated-address}`), preferring `navigator.share` and falling back to the existing `copyToClipboard` helper. - Keep **Copy trader address** as bech32-only. Share stays visible on profile 404 and indexer outage when the path is a valid terra address; it is hidden on empty `/trader` and invalid segments. - Optional **TS-11**: `/portfolio` Share emits `/trader/{wallet}` when connected (never `/portfolio`). Pair `/trade` and `/charts` mounts are not in this MR (helper already supports those kinds). Closes #665 ## Test plan - [x] `make verify-issue-665` (Vitest helper + button + trader/portfolio, chrome nesting, docs/skills, Playwright `trader-share-link` smoke) - [x] AddressRow still copies bech32; Share copies/shares the profile URL - [x] `/trader` empty and invalid segments hide Share - [ ] Manual 375 + 1280, light + dark: Share visible, focus-visible ring, 44px hit target - [ ] Manual: Web Share sheet on a capable phone; cancel does not toast; clipboard fallback on desktop - [ ] Optional: `/trade/:pair` and `/charts/:pair` Share mounts (follow-up) Closes #665
PlasticDigits (Migrated from gitlab.com) closed this pull request 2026-08-26 07:19:44 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1171
No description provided.