code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

WIP: Draft: feat(frontend): show Charts trader leaderboard on /trader (#657) #1166

Closed
PlasticDigits wants to merge 0 commits from 657-trader-show-charts-leaderboard-at-bottom-of-trader-and-trader-address into main
pull from: 657-trader-show-charts-leaderboard-at-bottom-of-trader-and-trader-address
merge into: code:main
Conversation 0 Commits - Files changed -
PlasticDigits commented 2026-08-26 07:12:37 +00:00 (Migrated from gitlab.com)
Copy link

Summary

  • Extract the Charts trader leaderboard into shared TraderLeaderboard (getLeaderboard(sort, 20), query key ['leaderboard', sort], USD Volume via formatIndexedVolumeUsd).
  • Mount it as the last /trader and /trader/:address page section (empty lookup, 404, and profile outage included). /portfolio is unchanged.
  • Document invariants TL-1–TL-10, skill AGENTS_FRONTEND_TRADER_LEADERBOARD.md, and make verify-issue-657.

Closes #657

Test plan

  • Vitest: TraderLeaderboard.test.tsx, TraderPage.test.tsx, ChartsPage.test.tsx (#553), PortfolioPage.test.tsx (no board)
  • make verify-issue-657 (docs/skills, chrome nesting, Playwright e2e/trader-page.spec.ts)
  • Manual: /trader empty lookup — Leaderboard below empty prompt, above legal footer
  • Manual: /trader/:address found — board below Trade History
  • Manual: 404 + indexer outage — board still visible; profile banner/RetryError unchanged
  • Volume tab compact USD (no raw T); unpriced —; idle $0
  • P&L tabs: Best Trade / Most Profit / Most Loss
  • Light + dark; ~375px horizontal scroll; last rows not under mobile nav
  • /portfolio has no leaderboard

Closes #657

## Summary - Extract the Charts trader leaderboard into shared `TraderLeaderboard` (`getLeaderboard(sort, 20)`, query key `['leaderboard', sort]`, USD Volume via `formatIndexedVolumeUsd`). - Mount it as the **last** `/trader` and `/trader/:address` page section (empty lookup, 404, and profile outage included). `/portfolio` is unchanged. - Document invariants **TL-1–TL-10**, skill `AGENTS_FRONTEND_TRADER_LEADERBOARD.md`, and `make verify-issue-657`. Closes #657 ## Test plan - [x] Vitest: `TraderLeaderboard.test.tsx`, `TraderPage.test.tsx`, `ChartsPage.test.tsx` (#553), `PortfolioPage.test.tsx` (no board) - [x] `make verify-issue-657` (docs/skills, chrome nesting, Playwright `e2e/trader-page.spec.ts`) - [ ] Manual: `/trader` empty lookup — Leaderboard below empty prompt, above legal footer - [ ] Manual: `/trader/:address` found — board below Trade History - [ ] Manual: 404 + indexer outage — board still visible; profile banner/RetryError unchanged - [ ] Volume tab compact USD (no raw `T`); unpriced `—`; idle `$0` - [ ] P&L tabs: Best Trade / Most Profit / Most Loss - [ ] Light + dark; ~375px horizontal scroll; last rows not under mobile nav - [ ] `/portfolio` has no leaderboard Closes #657
PlasticDigits (Migrated from gitlab.com) closed this pull request 2026-08-26 07:13:27 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1166
No description provided.