fix: flatten metric-grid chrome and lock one-layer invariant (#653) #1151

Merged

PlasticDigits merged 2 commits from feat/653-chrome-nesting into main

2026-08-26 01:57:33 +00:00

PlasticDigits commented

2026-08-26 01:37:09 +00:00

(Migrated from gitlab.com)

Summary

Strengthen the one-chrome-layer invariant so nested card-glass is no longer a general exception. Metric tiles use StatBox variant="flat" / .stat-flat.
Flatten Charts overview + pair 24h/TWAP, Trader summary + P&L chips, and Protocol Global stats / fees / oracle stat chips. Swap Pay/Receive and Trade sibling panels stay allowlisted.
Add scripts/check_chrome_nesting.py + allowlist, make verify-issue-653, and playbook skills/AGENTS_FRONTEND_CHROME_NESTING.md (C653-1–C653-8).

Closes #653

Related: #652 (Protocol inline Δ% — not in this MR), #561 L561-2, #488, #489

Test plan

make verify-issue-653 (run twice; 14/14)
StatBox default still card-glass; flat is not
Charts / Trader / Protocol RTL testids unchanged
python3 scripts/check_chrome_nesting.py + python3 scripts/check_design_tokens.py
Manual: /charts, /trader/:addr, /protocol, / — 375px + 1280px, light + dark (no empty-ring tiles)
Manual: Swap Pay/Receive still card-glass; Trade chart still single shell-panel-strong
Theme toggle: no leftover brown/gold fills

## Summary - Strengthen the one-chrome-layer invariant so nested `card-glass` is no longer a general exception. Metric tiles use `StatBox variant="flat"` / `.stat-flat`. - Flatten Charts overview + pair 24h/TWAP, Trader summary + P&L chips, and Protocol Global stats / fees / oracle stat chips. Swap Pay/Receive and Trade sibling panels stay allowlisted. - Add `scripts/check_chrome_nesting.py` + allowlist, `make verify-issue-653`, and playbook [`skills/AGENTS_FRONTEND_CHROME_NESTING.md`](../skills/AGENTS_FRONTEND_CHROME_NESTING.md) (**C653-1–C653-8**). Closes #653 Related: #652 (Protocol inline Δ% — not in this MR), #561 **L561-2**, #488, #489 ## Test plan - [x] `make verify-issue-653` (run twice; 14/14) - [x] StatBox default still `card-glass`; `flat` is not - [x] Charts / Trader / Protocol RTL testids unchanged - [x] `python3 scripts/check_chrome_nesting.py` + `python3 scripts/check_design_tokens.py` - [ ] Manual: `/charts`, `/trader/:addr`, `/protocol`, `/` — 375px + 1280px, light + dark (no empty-ring tiles) - [ ] Manual: Swap Pay/Receive still `card-glass`; Trade chart still single `shell-panel-strong` - [ ] Theme toggle: no leftover brown/gold fills

PlasticDigits commented

2026-08-26 01:57:31 +00:00

(Migrated from gitlab.com)

added 5 commits

30234a12...640bb28f - 4 commits from branch main
7245ac1c - Merge branch 'main' into feat/653-chrome-nesting

Compare with previous version

added 5 commits <ul><li>30234a12...640bb28f - 4 commits from branch <code>main</code></li><li>7245ac1c - Merge branch 'main' into feat/653-chrome-nesting</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/433/diffs?diff_id=1983935760&start_sha=30234a125f06e4952a0da2ef8d63310fe887a9f4)

PlasticDigits commented

2026-08-26 01:57:33 +00:00

(Migrated from gitlab.com)

mentioned in commit c90c893493

mentioned in commit c90c893493c228199fee61bf49fc8b97ccd5579b