fix: always consider the limit book on Swap and Trade (#596) #1116

Merged

PlasticDigits merged 1 commit from issue-596-hybrid-always-on into main

2026-08-22 13:51:04 +00:00

PlasticDigits commented

2026-08-22 13:43:36 +00:00

(Migrated from gitlab.com)

Summary

Remove the retail hybrid opt-out on Swap and Trade Market so CW20 quotes always use indexer GET /route/solve (best execution). Users can no longer uncheck a book-leg toggle to force pool-only.
Advanced stays a typed book-leg split override (POST /route/solve); empty book is still the solver path, not “skip the book”.
Document invariants H596-1–H596-8 in skills/AGENTS_FRONTEND_HYBRID_ALWAYS_ON.md and add make verify-issue-596. Integrators keep pool_only=true on indexer GET.

Closes #596

Test plan

make verify-issue-596 (unit + docs; retested)
make verify-issue-501 (GET default still holds)
Swap Settings → Advanced: no hybrid checkbox; empty book still GET /route/solve
Trade Market → Advanced: no Best execution toggle; typed book still POST
Optional: VERIFY_ISSUE_596_CHAIN=1 make verify-issue-596 with LocalTerra + frontend-dapp/.env.local
Observational (issue notes): indexer book_leg_volume vs pool_leg_volume share after deploy

## Summary - Remove the retail hybrid opt-out on Swap and Trade Market so CW20 quotes always use indexer `GET /route/solve` (best execution). Users can no longer uncheck a book-leg toggle to force pool-only. - Advanced stays a typed book-leg **split override** (`POST /route/solve`); empty book is still the solver path, not “skip the book”. - Document invariants **H596-1–H596-8** in `skills/AGENTS_FRONTEND_HYBRID_ALWAYS_ON.md` and add `make verify-issue-596`. Integrators keep `pool_only=true` on indexer GET. Closes #596 ## Test plan - [x] `make verify-issue-596` (unit + docs; retested) - [x] `make verify-issue-501` (GET default still holds) - [ ] Swap Settings → Advanced: no hybrid checkbox; empty book still `GET /route/solve` - [ ] Trade Market → Advanced: no Best execution toggle; typed book still `POST` - [ ] Optional: `VERIFY_ISSUE_596_CHAIN=1 make verify-issue-596` with LocalTerra + `frontend-dapp/.env.local` - [ ] Observational (issue notes): indexer `book_leg_volume` vs `pool_leg_volume` share after deploy

Rows
Columns