WIP: Draft: fix: keep slippage preset chips in one aligned group #1063

Closed

PlasticDigits wants to merge 0 commits from 528-fix-trade-market-slippage-chips-wrap-so-0-5-sits-above-1-5- into main

PlasticDigits commented

2026-08-16 08:33:44 +00:00

(Migrated from gitlab.com)

Summary

Shared SlippageProtectionPresets puts the Slippage protection label above a role="group" 3-up grid so 0.5% / 1% / 5% stay one aligned row on /trade Market and Swap Settings.
Swap Custom stacks below that group (never between chips). Preset values, default 5%, clamp, and max_spread = percent/100 are unchanged.
Documents invariants S528-1–S528-10 in docs/frontend.md and the #528 agent playbook.

Closes #528

Test plan

VERIFY_ISSUE_528_SKIP_E2E=1 make verify-issue-528 (8/8)
Vitest scoped suite (65 tests) — presets, default 5%, Custom sanitize, submit max_spread
Playwright P1–P10 Chromium (e2e/slippage-preset-align-528.spec.ts, 5 workers) against LocalTerra
Manual: /trade Market at phone + squeezed desktop ticket — chips share one row under the label
Manual: Swap Settings Custom still works; 99 clamps/warns; 0 range error
Manual: keyboard Tab 0.5 → 1 → 5; focus ring; light + dark

Closes #528

## Summary - Shared `SlippageProtectionPresets` puts the **Slippage protection** label above a `role="group"` 3-up grid so **0.5% / 1% / 5%** stay one aligned row on `/trade` Market and Swap Settings. - Swap **Custom** stacks below that group (never between chips). Preset values, default **5%**, clamp, and `max_spread = percent/100` are unchanged. - Documents invariants **S528-1–S528-10** in `docs/frontend.md` and the #528 agent playbook. Closes #528 ## Test plan - [x] `VERIFY_ISSUE_528_SKIP_E2E=1 make verify-issue-528` (8/8) - [x] Vitest scoped suite (65 tests) — presets, default 5%, Custom sanitize, submit `max_spread` - [x] Playwright P1–P10 Chromium (`e2e/slippage-preset-align-528.spec.ts`, 5 workers) against LocalTerra - [ ] Manual: `/trade` Market at phone + squeezed desktop ticket — chips share one row under the label - [ ] Manual: Swap Settings Custom still works; `99` clamps/warns; `0` range error - [ ] Manual: keyboard Tab 0.5 → 1 → 5; focus ring; light + dark Closes #528

Rows
Columns

WIP: Draft: fix: keep slippage preset chips in one aligned group #1063

Summary

Test plan

Pull request closed