fix: dock /trade money CTAs to ticket footer (#527) #1062

Merged

PlasticDigits merged 2 commits from feat/527-ticket-cta-dock into main

2026-08-16 08:47:48 +00:00

PlasticDigits commented

2026-08-16 08:14:35 +00:00

(Migrated from gitlab.com)

Summary

Replace Chromium-broken position: sticky inside the /trade ticket scrollport with a flex shrink-0 ticket footer so Place limit / Update price / Market buy|sell sit on the ticket card bottom instead of floating mid-form over Pay / Receive / Expiry.
Limit and Market share trade-ticket-submit-footer. Guards stay in document flow above the footer (#500). No position: fixed / portal footer. Place/submit semantics unchanged (#524 convert-on-submit untouched).
Document T527-1–T527-10 in docs/frontend.md and agent playbooks. make verify-issue-527 covers RTL + greps; Playwright geometry is in e2e/trade-page-responsive.spec.ts.

Closes #527

Test plan

make verify-issue-527 (unit + docs/testid greps; retested)
Scoped Vitest: TradePage.test.tsx footer DOM / Market dock / invert; TradeMarketOrderPanel.submitSnapshot.test.tsx
Playwright Chromium e2e/trade-page-responsive.spec.ts — #348, #500/#527 opacity, P1–P7, P10, P11 (LocalTerra + LCD proxy)
Manual Chrome /trade 1280×720: Place limit flush with ticket bottom; Limit ↔ Market one footer
Light theme + phone DevTools: no mid-form overlay, no position: fixed over bottom nav
Drag ticket resize handle: footer stays inside the ticket

## Summary - Replace Chromium-broken `position: sticky` inside the `/trade` ticket scrollport with a flex `shrink-0` **ticket footer** so **Place limit** / **Update price** / **Market buy|sell** sit on the ticket card bottom instead of floating mid-form over Pay / Receive / Expiry. - Limit and Market share `trade-ticket-submit-footer`. Guards stay in document flow above the footer (`#500`). No `position: fixed` / portal footer. Place/submit semantics unchanged (`#524` convert-on-submit untouched). - Document **T527-1–T527-10** in `docs/frontend.md` and agent playbooks. `make verify-issue-527` covers RTL + greps; Playwright geometry is in `e2e/trade-page-responsive.spec.ts`. Closes #527 ## Test plan - [x] `make verify-issue-527` (unit + docs/testid greps; retested) - [x] Scoped Vitest: `TradePage.test.tsx` footer DOM / Market dock / invert; `TradeMarketOrderPanel.submitSnapshot.test.tsx` - [x] Playwright Chromium `e2e/trade-page-responsive.spec.ts` — #348, #500/#527 opacity, P1–P7, P10, P11 (LocalTerra + LCD proxy) - [ ] Manual Chrome `/trade` 1280×720: Place limit flush with ticket bottom; Limit ↔ Market one footer - [ ] Light theme + phone DevTools: no mid-form overlay, no `position: fixed` over bottom nav - [ ] Drag ticket resize handle: footer stays inside the ticket

PlasticDigits commented

2026-08-16 08:44:25 +00:00

(Migrated from gitlab.com)

mentioned in issue #527

PlasticDigits commented

2026-08-16 08:47:44 +00:00

(Migrated from gitlab.com)

added 9 commits

3b9e25f8...a879d258 - 8 commits from branch main
9ee15f75 - merge: keep ticket footer dock with aligned slippage chips

Compare with previous version

added 9 commits <ul><li>3b9e25f8...a879d258 - 8 commits from branch <code>main</code></li><li>9ee15f75 - merge: keep ticket footer dock with aligned slippage chips</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/344/diffs?diff_id=1964222633&start_sha=3b9e25f8c9c81993cffdd56845d23d07c2ee8644)

PlasticDigits commented

2026-08-16 08:47:48 +00:00

(Migrated from gitlab.com)

mentioned in commit 438e7bc00b

mentioned in commit 438e7bc00b5aee21b1bd0498c5addfddc1919543