code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

fix(#522): scale pair tape to human quote-per-base and persist USD #1055

Merged
PlasticDigits merged 1 commit from fix/522-pair-price-usd into main 2026-08-15 12:00:01 +00:00
Conversation 3 Commits 1 Files changed 41 +1159 -74
PlasticDigits commented 2026-08-15 11:52:32 +00:00 (Migrated from gitlab.com)
Copy link

Closes #522

Summary

  • Indexer now stores human quote-per-base in swap_events.price (raw × 10^(decimals_base − decimals_quote)) and USD of 1 human base in swap_events.price_usd via the #515 catalog (UST1 = $1, cUSTC/USTC, LUNC, USTR = 2.5× USTC).
  • Trade / Charts / pair Open–Close / limit escrow Price (USD) use price_usd / *_usd — they no longer pass trades[0].price as dollars.
  • Migration backfills historical prices and rebuilds candles so mixed-decimal history is not permanently T-scaled.

Scale note: the issue text had 10^(decimals_quote − decimals_base). That exponent is inverted. UST1(6)/USTR(18) raw ≈7.97e13 becomes human ≈79.72 only with 10^(6−18).

Test plan

  • cd indexer && cargo test --lib pair_price_usd swap_orientation
  • cd indexer && cargo test --test swap_price_human_usd --test swap_price_orientation -- --test-threads=1
  • Frontend pairPriceUsd + Charts/Trade/Limits page tests
  • make verify-issue-522 (pass, then retest pass)
  • After indexer migrate/restart on columbus-5: UST1/cUSTC and UST1/USTR Price (USD) ≈ $1 on dex.cl8y.com
  • Confirm USTC oracle is populated so USD backfill is not NULL

Acceptance (#522)

  • Indexer + frontend so UST1/cUSTC and UST1/USTR can show ~$1 (6/6 and 18/6 fixtures)
  • Same USD helper on Trade, Charts, pair Open/Close, limit escrow headline
  • Mixed-decimal + same-decimal indexer tests; frontend 18/6 fixture
  • Migration backfills prices + rebuilds candles (needs prod indexer migrate/restart)
  • Live dex.cl8y.com visual confirm (needs deployed indexer)

Limit-order mode box on the issue was unchecked; the code path now uses the same USD helper, but it is not live-verified.

Docs / skills

  • Invariant row in docs/indexer-invariants.md
  • Playbook skills/AGENTS_INDEXER_PAIR_PRICE_USD.md (P522-1–P522-5)
  • Crosslinks: AGENTS.md, price chart, limit-order price, UST1 secondary AMM, external oracle
  • make verify-issue-522

Related: #466, #515, #508

Closes #522

Closes #522 ## Summary - Indexer now stores **human** quote-per-base in `swap_events.price` (`raw × 10^(decimals_base − decimals_quote)`) and **USD of 1 human base** in `swap_events.price_usd` via the #515 catalog (UST1 = $1, cUSTC/USTC, LUNC, USTR = 2.5× USTC). - Trade / Charts / pair Open–Close / limit escrow **Price (USD)** use `price_usd` / `*_usd` — they no longer pass `trades[0].price` as dollars. - Migration backfills historical prices and rebuilds candles so mixed-decimal history is not permanently T-scaled. **Scale note:** the issue text had `10^(decimals_quote − decimals_base)`. That exponent is inverted. UST1(6)/USTR(18) raw `≈7.97e13` becomes human `≈79.72` only with `10^(6−18)`. ## Test plan - [x] `cd indexer && cargo test --lib pair_price_usd swap_orientation` - [x] `cd indexer && cargo test --test swap_price_human_usd --test swap_price_orientation -- --test-threads=1` - [x] Frontend `pairPriceUsd` + Charts/Trade/Limits page tests - [x] `make verify-issue-522` (pass, then retest pass) - [ ] After indexer migrate/restart on columbus-5: UST1/cUSTC and UST1/USTR Price (USD) ≈ $1 on dex.cl8y.com - [ ] Confirm USTC oracle is populated so USD backfill is not NULL ## Acceptance (#522) - [x] Indexer + frontend so UST1/cUSTC and UST1/USTR **can** show ~$1 (6/6 and 18/6 fixtures) - [x] Same USD helper on Trade, Charts, pair Open/Close, limit escrow headline - [x] Mixed-decimal + same-decimal indexer tests; frontend 18/6 fixture - [x] Migration backfills prices + rebuilds candles (needs **prod indexer migrate/restart**) - [ ] Live dex.cl8y.com visual confirm (needs deployed indexer) Limit-order mode box on the issue was unchecked; the code path now uses the same USD helper, but it is not live-verified. ## Docs / skills - Invariant row in `docs/indexer-invariants.md` - Playbook `skills/AGENTS_INDEXER_PAIR_PRICE_USD.md` (P522-1–P522-5) - Crosslinks: `AGENTS.md`, price chart, limit-order price, UST1 secondary AMM, external oracle - `make verify-issue-522` Related: #466, #515, #508 Closes #522
PlasticDigits commented 2026-08-15 11:52:41 +00:00 (Migrated from gitlab.com)
Copy link

marked this merge request as ready

marked this merge request as **ready**
PlasticDigits commented 2026-08-15 11:59:54 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #522

mentioned in issue #522
PlasticDigits commented 2026-08-15 12:00:01 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 8ff700ee20

mentioned in commit 8ff700ee20c7ddd2ac17eea8368316b5ab3522e8
PlasticDigits (Migrated from gitlab.com) merged commit 8ff700ee20 into main 2026-08-15 12:00:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1055
No description provided.