fix(frontend): hide misleading pool-only book-leg notice (#492) #1038

Merged

PlasticDigits merged 2 commits from fix/492-hide-pool-only-book-leg-notice into main

2026-07-25 04:53:30 +00:00

PlasticDigits commented

2026-07-25 04:34:02 +00:00

(Migrated from gitlab.com)

Summary

Hide the Swap Execution “Pool only — add a book leg in Settings…” notice when hybrid Settings are already on and the manual book leg is empty (#492).
Extract display logic into getDirectHybridSettingsExecutionSummary so empty-book / hybrid-on yields { show: false } (silence; no substitute instructional copy).
Document Swap empty-book vs Trade empty-book invariants and cross-link agent skills.

Closes #492

Test plan

vitest swapDisclosure.test.ts + SwapPage.test.tsx filtered #492
Manual: Swap direct CW20 pair → Settings → Advanced → hybrid checked, book amount empty → quote → no “add a book leg” / no hollow Execution card unless indexer hybrid shows
Manual: set book leg > 0 → still see Hybrid pool/book split
Manual: book > pay → still see short exceeds-pay error
Manual: book > 0 with max makers 0 → still see short max-makers warning

## Summary - Hide the Swap Execution “Pool only — add a book leg in Settings…” notice when hybrid Settings are already on and the manual book leg is empty (#492). - Extract display logic into `getDirectHybridSettingsExecutionSummary` so empty-book / hybrid-on yields `{ show: false }` (silence; no substitute instructional copy). - Document Swap empty-book vs Trade empty-book invariants and cross-link agent skills. Closes #492 ## Test plan - [x] `vitest` `swapDisclosure.test.ts` + `SwapPage.test.tsx` filtered `#492` - [ ] Manual: Swap direct CW20 pair → Settings → Advanced → hybrid checked, book amount empty → quote → no “add a book leg” / no hollow Execution card unless indexer hybrid shows - [ ] Manual: set book leg > 0 → still see Hybrid pool/book split - [ ] Manual: book > pay → still see short exceeds-pay error - [ ] Manual: book > 0 with max makers 0 → still see short max-makers warning

ghost1 commented

2026-07-25 04:34:05 +00:00

(Migrated from gitlab.com)

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot) to get automatic reviews on future PRs.

PlasticDigits commented

2026-07-25 04:34:22 +00:00

(Migrated from gitlab.com)

mentioned in issue #492

PlasticDigits commented

2026-07-25 04:52:44 +00:00

(Migrated from gitlab.com)

mentioned in commit 392db3c4c3

mentioned in commit 392db3c4c31338eae4ec4dad35ec8d0c39db9b0c

PlasticDigits commented

2026-07-25 04:53:30 +00:00

(Migrated from gitlab.com)

mentioned in commit 73b80b6f4d

mentioned in commit 73b80b6f4ddbba0fefd5de3da957a45ff88b4ff8

PlasticDigits (Migrated from gitlab.com) merged commit 73b80b6f4d into main

2026-07-25 04:53:30 +00:00

PlasticDigits commented

2026-07-25 04:53:33 +00:00

(Migrated from gitlab.com)

added 19 commits

f778d9b1...b3e11cbb - 18 commits from branch main
392db3c4 - merge: sync branch with main for !1038

Compare with previous version

added 19 commits <ul><li>f778d9b1...b3e11cbb - 18 commits from branch <code>main</code></li><li>392db3c4 - merge: sync branch with main for !1038</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/320/diffs?diff_id=1923593142&start_sha=f778d9b130a79cc34c12c12e004f781c9acd45a4)