fix(frontend): clear stale You Receive on pay change (#496) #1031

Merged

PlasticDigits merged 2 commits from fix/496-stale-you-receive-pay-change into main

2026-07-25 04:48:08 +00:00

PlasticDigits commented

2026-07-25 04:32:57 +00:00

(Migrated from gitlab.com)

Summary

Extend shouldShowSimReceiveCalculating so pay amount debounce and keepPreviousData placeholder rows show Calculating/Quoting instead of a prior-pair receive amount (#496).
Wire the gate on Swap (swap-you-receive) and Trade market Expected receive; keep same-input background refetch keep-previous behavior (#484).
Document invariants + agent checklists in docs/frontend.md, AGENTS_FRONTEND_SWAP_QUOTE_REFETCH.md, and related skills.

Test plan

quoteDebounce.test.ts — #484 keep-previous vs #496 placeholder/pay-pending
SwapPage.test.tsx — You Receive shows Calculating while typed amount ≠ debounced
Manual: Swap quoted pair → change pay amount → You Receive Calculating → new amount
Manual: Swap → change pay token → no leftover receive from previous pair
Manual: stable pay inputs during background sim refetch → prior receive amount stays (#484)
Manual: submit stale/Calculating gate still correct (#356)
Manual (optional): Trade market Expected receive Quoting on amount change

Closes #496

## Summary - Extend `shouldShowSimReceiveCalculating` so pay amount debounce and `keepPreviousData` placeholder rows show Calculating/Quoting instead of a prior-pair receive amount (#496). - Wire the gate on Swap (`swap-you-receive`) and Trade market Expected receive; keep same-input background refetch keep-previous behavior (#484). - Document invariants + agent checklists in `docs/frontend.md`, `AGENTS_FRONTEND_SWAP_QUOTE_REFETCH.md`, and related skills. ## Test plan - [x] `quoteDebounce.test.ts` — #484 keep-previous vs #496 placeholder/pay-pending - [x] `SwapPage.test.tsx` — You Receive shows Calculating while typed amount ≠ debounced - [ ] Manual: Swap quoted pair → change pay amount → You Receive Calculating → new amount - [ ] Manual: Swap → change pay token → no leftover receive from previous pair - [ ] Manual: stable pay inputs during background sim refetch → prior receive amount stays (#484) - [ ] Manual: submit stale/Calculating gate still correct (#356) - [ ] Manual (optional): Trade market Expected receive Quoting on amount change Closes #496

ghost1 commented

2026-07-25 04:33:00 +00:00

(Migrated from gitlab.com)

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot) to get automatic reviews on future PRs.

PlasticDigits commented

2026-07-25 04:45:09 +00:00

(Migrated from gitlab.com)

added 3 commits

70937b9c...6c0e51e2 - 2 commits from branch main
a04bc11e - merge: sync #496 with main and fix router clippy

Compare with previous version

added 3 commits <ul><li>70937b9c...6c0e51e2 - 2 commits from branch <code>main</code></li><li>a04bc11e - merge: sync #496 with main and fix router clippy</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/313/diffs?diff_id=1923591109&start_sha=70937b9c1ffc124db473dc594cc18406b57173dd)

project_80162261_bot_e646d24e9b17aa4b22040bfe08d3fd1c commented

2026-07-25 04:45:11 +00:00

(Migrated from gitlab.com)

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot) to get automatic reviews on future PRs.

PlasticDigits (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed

2026-07-25 04:45:50 +00:00

PlasticDigits (Migrated from gitlab.com) canceled auto merging this pull request when all checks succeed

2026-07-25 04:48:06 +00:00

PlasticDigits (Migrated from gitlab.com) merged commit 5993d3a7e8 into main

2026-07-25 04:48:08 +00:00

PlasticDigits commented

2026-07-25 04:48:38 +00:00

(Migrated from gitlab.com)

mentioned in commit 5993d3a7e8

mentioned in commit 5993d3a7e8d72360972024222d0341ea3f920d71