Contract integration: fee discount on limit book match path #83

New issue

Closed

opened 2026-04-09 03:24:20 +00:00 by PlasticDigits · 7 comments

PlasticDigits commented

2026-04-09 03:24:20 +00:00

(Migrated from gitlab.com)

Evidence

smartcontracts/contracts/pair/src/orderbook.rs uses effective_fee_bps

Acceptance criteria

Discounted trader: book fill fee consistent with pool policy

Epic

#61

## Evidence - `smartcontracts/contracts/pair/src/orderbook.rs` uses `effective_fee_bps` ## Acceptance criteria - [ ] Discounted trader: book fill fee consistent with pool policy ## Epic #61

PlasticDigits commented

2026-04-09 03:24:21 +00:00

(Migrated from gitlab.com)

marked this issue as related to #61

PlasticDigits commented

2026-04-13 04:51:42 +00:00

(Migrated from gitlab.com)

New integration test hybrid_book_fill_uses_taker_discounted_effective_fee_bps: taker with fee-discount registry hits a bid via hybrid book-only swap; swap attrs effective_fee_bps matches discounted rate. Doc sentence in limit-orders.md. @brouie please verify fee math vs tier policy.

New integration test `hybrid_book_fill_uses_taker_discounted_effective_fee_bps`: taker with fee-discount registry hits a bid via hybrid book-only swap; swap attrs `effective_fee_bps` matches discounted rate. Doc sentence in limit-orders.md. @brouie please verify fee math vs tier policy.

PlasticDigits commented

2026-04-13 04:51:46 +00:00

(Migrated from gitlab.com)

mentioned in issue #58

PlasticDigits commented

2026-04-13 04:59:40 +00:00

(Migrated from gitlab.com)

mentioned in commit a611e0ef2d

mentioned in commit a611e0ef2d4ce2be30ef01b66f7202edc64fcb5e

PlasticDigits commented

2026-04-13 12:15:58 +00:00

(Migrated from gitlab.com)

mentioned in issue #100

Brouie commented

2026-04-20 06:50:19 +00:00

(Migrated from gitlab.com)

@PlasticDigits Verified on current main. Acceptance criteria:

Discounted trader: book fill fee consistent with pool policy: smartcontracts/tests/src/limit_order_tests.rs has hybrid_book_fill_uses_taker_discounted_effective_fee_bps. Ran locally: 1 passed, 0 failed (limit_order_tests::hybrid_book_fill_uses_taker_discounted_effective_fee_bps ... ok).

Test covers: taker with fee-discount registry hits a bid via hybrid book-only swap, asserts swap attrs effective_fee_bps matches the discounted tier rate. Fee math consistency between book match path and pool policy locked in.

Closing.

@PlasticDigits Verified on current main. Acceptance criteria: - [x] Discounted trader: book fill fee consistent with pool policy: smartcontracts/tests/src/limit_order_tests.rs has hybrid_book_fill_uses_taker_discounted_effective_fee_bps. Ran locally: **1 passed, 0 failed** (limit_order_tests::hybrid_book_fill_uses_taker_discounted_effective_fee_bps ... ok). Test covers: taker with fee-discount registry hits a bid via hybrid book-only swap, asserts swap attrs effective_fee_bps matches the discounted tier rate. Fee math consistency between book match path and pool policy locked in. Closing.

Brouie (Migrated from gitlab.com) closed this issue

2026-04-20 06:50:22 +00:00

PlasticDigits commented

2026-05-26 08:00:37 +00:00

(Migrated from gitlab.com)

mentioned in issue #199