ops: post-merge !483 leftover verify (#715) #716

New issue

Open

opened 2026-09-01 07:48:08 +00:00 by PlasticDigits · 4 comments

PlasticDigits commented

2026-09-01 07:48:08 +00:00

(Migrated from gitlab.com)

Summary

!1201 (#715 Swap from=/to= tokenlist symbols, unique-ticker CI, Share logos) is on main at 53237a50. Local AC passed before merge (make verify-issue-715 PASS=8, make verify-issue-711, make verify-issue-713). Close this leftover when Coolify frontend rebuild + LocalTerra Playwright (5 workers) + Trader Share spot-check are done.

Do not reopen #715 unless a merged invariant is wrong (GitLab auto-closed it on merge). Sibling leftover #714 still covers !1199/!1200 Coolify + marketing hrefs — Playwright there must now expect symbols (from=LUNC&to=USTC) and Share aria-label Share LUNC to USTC swap link.

No automerge. Do not wait on GitLab CI (quota is not a product signal).

Merged MR

MR	Issue	What landed
!1201	#715	Unique `tokenlist.json` CI; inbound symbols; canonical rewrite/Share/deep links emit published tickers (`from=LUNC&to=UST1`); Swap Share `{pay logo} → {receive logo}`

Included at merge (not leftover): #713 Playwright Share aria-label updated from /share swap/i to /Share LUNC to USTC swap link/i (86744db1).

No git conflicts — branch was already based on main (cbd37cd8).

Operator leftovers

Coolify frontend

Redeploy dApp from current main (53237a50+). Confirm:

https://dex.cl8y.com/?from=UST1&to=USTR selects those tokens; bar stays symbols.
Paste an old #713 uluna / bech32 link → pair applies → bar and Share rewrite to tokenlist symbols (from=LUNC&to=UST1).
Swap header Share reads Share {pay logo} → {receive logo}; copied URL uses symbols, not location.href.
Trader / Portfolio Share still say Share with no pair logos.

LocalTerra Playwright (live factory)

make verify-issue-715 and make verify-issue-713 SKIP Playwright without LocalTerra + frontend-dapp/.env.local + live factory. After make setup-cloud-localterra or make deploy-local:

make verify-issue-715
PLAYWRIGHT_SKIP_CHAIN=1 bash scripts/with-node.sh --cwd frontend-dapp -- \
  ./node_modules/.bin/playwright test --project=e2e-smoke --workers=5 \
  e2e/swap-tokenlist-symbols-715.spec.ts e2e/swap-url-sync-713.spec.ts e2e/swap-query-params.spec.ts

Small code leftover (non-blocking)

SHARE_LINK_ARIA_SWAP = 'Share swap link' in sharePageLinkCopy.ts is unused after SH-1 (Swap uses swapShareAriaLabel). Safe to drop in a tiny follow-up; do not restore the old aria-label.

Coverage gaps (optional, not merge blockers)

QS-3 unlisted factory CW20 outbound bech32: unit only, no Swap RTL/e2e.
/trade?from=UST1&to=cUSTC unique-pair replace: parser covered; TradePage RTL still uses uluna.
SH-2 Trader/Portfolio no-logos: relies on #665; not in verify-issue-715.
make verify-issue-542 / 665 / 630 not re-run at merge (chrome nesting passed).

Out of scope

No Coolify env vars, wasm, or indexer change.
Do not reopen #711 / #713.
Marketing-site DEX hrefs stay on CL8Y-web #6 / leftover #714.

Verification

make verify-issue-715
make verify-issue-711 and make verify-issue-713 (canonical strings are from=LUNC&to=USTC)
Playwright 5 workers when factory is live (commands above)

Playbook: skills/AGENTS_FRONTEND_SWAP_TOKENLIST_SYMBOLS.md (TL-1–TL-2, QS-1–QS-6, SH-1–SH-3).

## Summary [!1201](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/483) (#715 Swap `from=`/`to=` tokenlist symbols, unique-ticker CI, Share logos) is on `main` at `53237a50`. Local AC passed before merge (`make verify-issue-715` PASS=8, `make verify-issue-711`, `make verify-issue-713`). **Close this leftover when Coolify frontend rebuild + LocalTerra Playwright (5 workers) + Trader Share spot-check are done.** Do **not** reopen [#715](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/715) unless a merged invariant is wrong (GitLab auto-closed it on merge). Sibling leftover [#714](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/714) still covers !1199/!1200 Coolify + marketing hrefs — Playwright there must now expect **symbols** (`from=LUNC&to=USTC`) and Share aria-label `Share LUNC to USTC swap link`. No automerge. Do not wait on GitLab CI (quota is not a product signal). ## Merged MR | MR | Issue | What landed | |----|-------|-------------| | !1201 | #715 | Unique `tokenlist.json` CI; inbound symbols; canonical rewrite/Share/deep links emit published tickers (`from=LUNC&to=UST1`); Swap Share `{pay logo} → {receive logo}` | Included at merge (not leftover): #713 Playwright Share aria-label updated from `/share swap/i` to `/Share LUNC to USTC swap link/i` (`86744db1`). No git conflicts — branch was already based on `main` (`cbd37cd8`). ## Operator leftovers ### Coolify frontend Redeploy dApp from current `main` (`53237a50+`). Confirm: - `https://dex.cl8y.com/?from=UST1&to=USTR` selects those tokens; bar stays symbols. - Paste an old #713 `uluna` / bech32 link → pair applies → bar and Share rewrite to tokenlist symbols (`from=LUNC&to=UST1`). - Swap header Share reads **Share {pay logo} → {receive logo}**; copied URL uses symbols, not `location.href`. - Trader / Portfolio Share still say **Share** with no pair logos. ### LocalTerra Playwright (live factory) `make verify-issue-715` and `make verify-issue-713` **SKIP** Playwright without LocalTerra + `frontend-dapp/.env.local` + live factory. After `make setup-cloud-localterra` or `make deploy-local`: ```bash make verify-issue-715 PLAYWRIGHT_SKIP_CHAIN=1 bash scripts/with-node.sh --cwd frontend-dapp -- \ ./node_modules/.bin/playwright test --project=e2e-smoke --workers=5 \ e2e/swap-tokenlist-symbols-715.spec.ts e2e/swap-url-sync-713.spec.ts e2e/swap-query-params.spec.ts ``` ### Small code leftover (non-blocking) - `SHARE_LINK_ARIA_SWAP = 'Share swap link'` in `sharePageLinkCopy.ts` is unused after SH-1 (Swap uses `swapShareAriaLabel`). Safe to drop in a tiny follow-up; do not restore the old aria-label. ### Coverage gaps (optional, not merge blockers) - QS-3 unlisted factory CW20 outbound bech32: unit only, no Swap RTL/e2e. - `/trade?from=UST1&to=cUSTC` unique-pair replace: parser covered; TradePage RTL still uses `uluna`. - SH-2 Trader/Portfolio no-logos: relies on #665; not in `verify-issue-715`. - `make verify-issue-542` / `665` / `630` not re-run at merge (chrome nesting passed). ## Out of scope - No Coolify env vars, wasm, or indexer change. - Do not reopen #711 / #713. - Marketing-site DEX hrefs stay on [CL8Y-web #6](https://gitlab.com/PlasticDigits/CL8Y-web/-/work_items/6) / leftover #714. ## Verification - `make verify-issue-715` - `make verify-issue-711` and `make verify-issue-713` (canonical strings are `from=LUNC&to=USTC`) - Playwright 5 workers when factory is live (commands above) Playbook: `skills/AGENTS_FRONTEND_SWAP_TOKENLIST_SYMBOLS.md` (**TL-1–TL-2**, **QS-1–QS-6**, **SH-1–SH-3**).

PlasticDigits commented

2026-09-01 07:48:09 +00:00

(Migrated from gitlab.com)

marked as related to #715

PlasticDigits commented

2026-09-01 07:48:22 +00:00

(Migrated from gitlab.com)

mentioned in issue #715

PlasticDigits commented

2026-09-01 07:48:24 +00:00

(Migrated from gitlab.com)

mentioned in issue #714

PlasticDigits commented

2026-09-01 07:48:24 +00:00

(Migrated from gitlab.com)

Opened from the !1201 merge session. Local unit/docs verify is already green; remaining work is Coolify + LocalTerra Playwright as described. Do not wait on GitLab CI.