code/cl8y-dex-terraclassic

Fork 0

ops: post-merge !481/!482 leftover verify (#711 #713) #714

New issue

Closed

opened 2026-08-31 11:18:40 +00:00 by PlasticDigits · 8 comments

PlasticDigits commented

2026-08-31 11:18:40 +00:00

(Migrated from gitlab.com)

Summary

!1199 (#711 Swap query params) and !1200 (#713 URL sync / reverse quotes / Share / Create+Trade prefill) are on main. Local AC passed before merge (make verify-issue-711, make verify-issue-713). Close this leftover when Coolify + live factory Playwright + marketing-site hrefs are done.

Do not reopen #711 / #713 unless a merged invariant is wrong (GitLab auto-closed them on merge).

No automerge. Do not wait on GitLab CI (quota is not a product signal).

Merged MRs

MR	Issue	What landed
!1199	#711	`/swap` preserves search; Uniswap/Terra aliases; factory gate; gems/hostile ignore; optional pay amount; `ust1SecondarySwapPath()` `/?from=&to=`
!1200	#713	Canonical `/?from=&to=` replace write-back; reverse quote on direct pairs (execute stays offer-in); Swap Share; `/create?a=&b=` prefill; `/trade?from=&to=` unique-pair replace

Conflict resolution: Makefile help kept main greedy 708–710 Cloud Agent entries and added verify-issue-711 / verify-issue-713 on the Frontend line.

Fixes included at merge (not leftover)

AC1 wrap-native race (#711): apply waits for pairsQuery.isSuccess so wrap natives in getAllTokens([]) cannot stamp the apply-once ref and drop a listed CW20. RTL covers delayed factory fetch.
#678 Reduce vs reverse (#713): Reduce now setExactField('input') like Max/fraction so pay-human does not land in You Receive.

Operator leftovers

Coolify frontend

Redeploy dApp from current main. Confirm:

https://dex.cl8y.com/swap/?inputCurrency=uluna&outputCurrency=<listed> selects the pair; Swap tab stays active.
After changing tokens, Share copies canonical /?from=&to= (no leftover Uniswap keys) and a reload of that URL keeps the pair.
/create?a=&b= listed CW20s prefills and does not auto-submit.
/trade?from=uluna&to=<listed> lands on /trade/{pair} when the factory pair is unique.

LocalTerra Playwright (live factory)

make verify-issue-713 ran Create Pair query smoke only — VITE_FACTORY_ADDRESS in .env.local was stale vs this LocalTerra. After make deploy-local:

PLAYWRIGHT_SKIP_CHAIN=1 bash scripts/with-node.sh --cwd frontend-dapp -- \
  ./node_modules/.bin/playwright test --project=e2e-smoke --workers=5 \
  e2e/swap-query-params.spec.ts e2e/swap-url-sync-713.spec.ts

Need a listed CW20 to= (not only uluna/uusd) for #711 AC1 on Coolify-shaped wrap env.

Tests that still do not prove T1/T3/T9/T14

RTL/Playwright: picker change rewrites from/to; Share copies canonical URL; /trade?from=&to= e2e; Create e2e asserts listed pickers (not only heading).
Vitest: swap() called with reverse offer_amount; gem ids → share URL null.

Out of scope (already tracked)

Marketing-site DEX hrefs: CL8Y-web #6 (gated on Coolify shipping !1199).
Create Token emitting /create?a=<newCw20> (P402-5) — copy-address remains valid until that ships.
Indexer exact-out /route/solve.

Verification

make verify-issue-711
make verify-issue-713
make verify-issue-542 / make verify-issue-678 if Create/acquire banners look off after Coolify

## Summary [!1199](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/481) (#711 Swap query params) and [!1200](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/482) (#713 URL sync / reverse quotes / Share / Create+Trade prefill) are on `main`. Local AC passed before merge (`make verify-issue-711`, `make verify-issue-713`). **Close this leftover when Coolify + live factory Playwright + marketing-site hrefs are done.** Do **not** reopen [#711](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/711) / [#713](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/713) unless a merged invariant is wrong (GitLab auto-closed them on merge). No automerge. Do not wait on GitLab CI (quota is not a product signal). ## Merged MRs | MR | Issue | What landed | |----|-------|-------------| | !1199 | #711 | `/swap` preserves search; Uniswap/Terra aliases; factory gate; gems/hostile ignore; optional pay amount; `ust1SecondarySwapPath()` `/?from=&to=` | | !1200 | #713 | Canonical `/?from=&to=` replace write-back; reverse quote on direct pairs (execute stays offer-in); Swap Share; `/create?a=&b=` prefill; `/trade?from=&to=` unique-pair replace | Conflict resolution: Makefile help kept main greedy **708–710** Cloud Agent entries and added `verify-issue-711` / `verify-issue-713` on the Frontend line. ## Fixes included at merge (not leftover) - **AC1 wrap-native race (#711):** apply waits for `pairsQuery.isSuccess` so wrap natives in `getAllTokens([])` cannot stamp the apply-once ref and drop a listed CW20. RTL covers delayed factory fetch. - **#678 Reduce vs reverse (#713):** Reduce now `setExactField('input')` like Max/fraction so pay-human does not land in You Receive. ## Operator leftovers ### Coolify frontend Redeploy dApp from current `main`. Confirm: - `https://dex.cl8y.com/swap/?inputCurrency=uluna&outputCurrency=<listed>` selects the pair; Swap tab stays active. - After changing tokens, Share copies canonical `/?from=&to=` (no leftover Uniswap keys) and a reload of that URL keeps the pair. - `/create?a=&b=` listed CW20s prefills and does **not** auto-submit. - `/trade?from=uluna&to=<listed>` lands on `/trade/{pair}` when the factory pair is unique. ### LocalTerra Playwright (live factory) `make verify-issue-713` ran Create Pair query smoke only — `VITE_FACTORY_ADDRESS` in `.env.local` was stale vs this LocalTerra. After `make deploy-local`: ```bash PLAYWRIGHT_SKIP_CHAIN=1 bash scripts/with-node.sh --cwd frontend-dapp -- \ ./node_modules/.bin/playwright test --project=e2e-smoke --workers=5 \ e2e/swap-query-params.spec.ts e2e/swap-url-sync-713.spec.ts ``` Need a **listed CW20** `to=` (not only `uluna`/`uusd`) for #711 AC1 on Coolify-shaped wrap env. ### Tests that still do not prove T1/T3/T9/T14 - RTL/Playwright: picker change rewrites `from`/`to`; Share copies canonical URL; `/trade?from=&to=` e2e; Create e2e asserts listed pickers (not only heading). - Vitest: `swap()` called with reverse `offer_amount`; gem ids → share URL `null`. ### Out of scope (already tracked) - Marketing-site DEX hrefs: [CL8Y-web #6](https://gitlab.com/PlasticDigits/CL8Y-web/-/work_items/6) (gated on Coolify shipping !1199). - Create Token emitting `/create?a=<newCw20>` (**P402-5**) — copy-address remains valid until that ships. - Indexer exact-out `/route/solve`. ## Verification - `make verify-issue-711` - `make verify-issue-713` - `make verify-issue-542` / `make verify-issue-678` if Create/acquire banners look off after Coolify

PlasticDigits commented

2026-08-31 11:18:41 +00:00

(Migrated from gitlab.com)

marked as related to #711

PlasticDigits commented

2026-08-31 11:18:42 +00:00

(Migrated from gitlab.com)

marked as related to #713

PlasticDigits commented

2026-08-31 11:18:56 +00:00

(Migrated from gitlab.com)

mentioned in issue #711

PlasticDigits commented

2026-08-31 11:18:57 +00:00

(Migrated from gitlab.com)

mentioned in issue #713

PlasticDigits commented

2026-08-31 11:18:58 +00:00

(Migrated from gitlab.com)

Opened from the !1199 / !1200 merge pass. Parent issues #711 and #713 auto-closed on merge; this ticket is the Coolify + live-factory Playwright + test-gap follow-up only.

PlasticDigits commented

2026-09-01 07:48:09 +00:00

(Migrated from gitlab.com)

mentioned in issue #716

PlasticDigits commented

2026-09-01 07:48:22 +00:00

(Migrated from gitlab.com)

mentioned in issue #715

PlasticDigits commented

2026-09-01 07:48:23 +00:00

(Migrated from gitlab.com)

!1201 (#715) is now on main (53237a50). Leftover Playwright for this ticket (e2e/swap-url-sync-713.spec.ts, e2e/swap-query-params.spec.ts) must expect canonical symbols (from=LUNC&to=USTC), not uluna/uusd, and Share aria-label Share LUNC to USTC swap link.

#715 Coolify + chain leftover is tracked on #716. Do not reopen #711/#713.

!1201 (#715) is now on `main` (`53237a50`). Leftover Playwright for this ticket (`e2e/swap-url-sync-713.spec.ts`, `e2e/swap-query-params.spec.ts`) must expect canonical **symbols** (`from=LUNC&to=USTC`), not `uluna`/`uusd`, and Share `aria-label` `Share LUNC to USTC swap link`. #715 Coolify + chain leftover is tracked on [#716](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/716). Do not reopen #711/#713.