QA: wire post-deploy smoke and broadcast recovery E2E #368
Labels
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
code/cl8y-dex-terraclassic#368
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Parent
Gap analysis follow-up from GitLab #361 — bundled validation items H12 (broadcast recovery E2E) and M12 (post-deploy smoke automation).
Current codebase
Post-sign broadcast recovery (H12)
terraWalletSignTxRaw.ts,terraTxRecoveryPoll.ts,terraBroadcast.ts,terraMsgDeadline.ts.terraBroadcastRecovery.test.ts,terraBroadcastUi.test.ts.skills/AGENTS_FRONTEND_TX_BROADCAST_TIMEOUT.md.Post-deploy smoke (M12)
scripts/smoke-pool-swap.sh(LCDpool+ optionalhybrid_simulationpool-only).docs/testing.md,docs/deployment-guide.md,docs/runbooks/launch-checklist.md.scripts/qa/start-qa.shafter deploy.Why needed
Wallet-specific edge cases (Keplr extension fee guards via patched cosmes vs Simulated Wallet) need ongoing E2E protection. Pool-only smoke after deploy catches LCD/schema regressions early on QA without full Playwright ladder.
Constraints / guardrails
scripts/setup-browser-cloud-agent.sh); default CI smoke may stay Simulated Wallet — document Keplr manual/optional job.Relevant files
frontend-dapp/src/services/terraclassic/terraBroadcast.tsfrontend-dapp/src/services/terraclassic/terraTxRecoveryPoll.tsfrontend-dapp/src/services/terraclassic/terraWalletSignTxRaw.tsfrontend-dapp/src/services/terraclassic/__tests__/terraBroadcastRecovery.test.tsfrontend-dapp/e2e/(new or extended spec)frontend-dapp/playwright.config.tsscripts/smoke-pool-swap.shscripts/qa/start-qa.sh,scripts/qa/verify-deploy.shskills/AGENTS_E2E_STRICT_CHAIN.mdskills/AGENTS_FRONTEND_TX_BROADCAST_TIMEOUT.mdRecommended direction
e2e/terra-broadcast-recovery.spec.ts(or extend swap spec) for Simulated Wallet post-sign RPC block → expect “Broadcast status unknown” / recovery phase, submit disabled until poll ends. Optional second job doc for Keplr extension with same assertions.qa-verify-deployinstart-qa.sh, runsmoke-pool-swap.shwithPAIR_ADDR/OFFER_TOKENfromfrontend-dapp/.env.local(fail QA bring-up on non-zero exit).make smoke-pool-swapwrapper reading deploy env.scripts/qa/README.mdanddocs/testing.md.Acceptance criteria
make start-qaruns smoke script after deploy verification (skippable viaQA_SKIP_SMOKE=1for edge cases).Test plan
make test-frontend— broadcast recovery testsmake setup-cloud-localterra && sg docker -c 'CI=1 make test-e2e-tx'(new spec)PAIR_ADDR=... OFFER_TOKEN=... ./scripts/smoke-pool-swap.shmake start-qaon QA host — smoke runs after verifyAttack / abuse test plan
recoveringphase.Verification criteria
start-qalogs smoke success; failure blocks QA ready state.QA_SKIP_SMOKE=1 make start-qastill works for indexer-only debugging.mentioned in issue #361
mentioned in commit
ab877df57fmentioned in merge request !877
mentioned in commit
517f66daa2mentioned in commit
b626593457Verified !877 at the source + script layer here (VPS). The #368-specific deliverables are good; there's a merge-hygiene blocker from the branch being stale.
Acceptance criteria — all met:
Merge blocker — !877 needs a rebase before it lands:
cd17813) and does NOT contain my !870 tsc fix.Suggested: rebase !877 onto current main, drop/reconcile the redundant #359 impl files (already on main via !867), keep only the #368 additions — E2E spec, smoke hook, smoke-deploy-env.sh, make wrapper, docs. After the rebase the build + e2e re-verify and it's clean to merge.
@PlasticDigits flagging the rebase since it touches the just-merged #359 + my open !870.
mentioned in commit
c02f103081mentioned in commit
03904029f1mentioned in commit
1f36acb5admentioned in commit
337f6becc2mentioned in commit
8c641d165cmentioned in commit
75c9478f77Verification — #368 (post-merge on
main@83ae372)Verified deliverables from !877 on current
mainaftergit pull. No repo changes required from this verification pass.Acceptance criteria
CI=1 bash scripts/with-node.sh --cwd frontend-dapp -- ./node_modules/.bin/playwright test --project=e2e-tx terra-broadcast-recovery.spec.ts— 1 passed (~1.1m). Assertsterra-broadcast-recovery-statuscontains "broadcast status unknown", submit button Checking broadcast… disabled during hungbroadcast_tx_sync, pending tx resolves.make start-qaruns smoke after deploy verificationscripts/qa/start-qa.shlines 118–124: smoke phase afterqa-verify-deploy,set -euo pipefailfails bring-up on non-zero smoke exit.QA_SKIP_SMOKE=1skips smoke[start-qa] QA_SKIP_SMOKE=1 — skipping post-deploy smoke-pool-swapwhen set.make smoke-pool-swapaftermake setup-cloud-localterra --fresh --skip-build— pairterra146yp…from.qa-deploy-stampviascripts/lib/smoke-deploy-env.sh;OK: smoke-pool-swap read-only checks passed.skills/AGENTS_FRONTEND_TX_BROADCAST_TIMEOUT.md§ Post-sign broadcast recovery — manual Keplr steps + optionalE2E_KEPLR_BROADCAST_RECOVERY=1(not default CI).Test plan
make test-frontend— 161 files / 970 tests passed (includesterraBroadcastRecovery.test.ts,terraBroadcastUi.test.ts).bash scripts/e2e-start-indexer.sh).make smoke-pool-swap— pool query + hybrid_simulation pool-only; exit 0.start-qa.sh; fullmake start-qaend-to-end not re-run on this VM (deploy already up; smoke path exercised viamake smoke-pool-swap).Attack / abuse checks
recoveringpollTxUntilRecoveryDeadlineafter singlebroadcastTxattempt; E2E keeps submit disabled until resolution.terraBroadcast.test.tsassertsbroadcastTxcalled once.scripts/smoke-pool-swap.sh— no mnemonic/secret patterns; outputs pool JSON + simulation only.Environment notes
make setup-cloud-localterrafailed on stale treasury funding;./scripts/setup-cloud-agent-localterra.sh --fresh --skip-buildsucceeded.(cd indexer && cargo build --release)beforebash scripts/e2e-start-indexer.sh.Closing as verified on
main.Follow-up to my earlier note: the merge-hygiene blocker I flagged on !877 is resolved. The branch had main merged into it before landing, so my tsc fix (
317ad1c) is still in the ancestry, tsc -b is clean, and the merged #359 broadcast-recovery files weren't reverted. The merge also brought further hardening (duplicate-swap guard, mempool-already-in-cache recovery), which lines up with the "no double-broadcast on retry" abuse item.ACs on the source/script + smoke layer:
Left for the browser pass: actually executing the Playwright recovery spec on the harness, and the manual Keplr extension parity run.
Good to close from my side on the smoke + source/script scope. @PlasticDigits
mentioned in issue #337