Docs: remove GitHub Actions references; document local-only CI #234

Closed
opened 2026-05-30 06:17:29 +00:00 by PlasticDigits · 9 comments
PlasticDigits commented 2026-05-30 06:17:29 +00:00 (Migrated from gitlab.com)

Summary

This repo is hosted on GitLab and does not run GitHub Actions or GitLab CI. The .github/workflows/ YAML files are a portable reference for job names, service containers, and command order — agents and humans run the same checks via Makefile targets and scripts/.

Issue #219 verification surfaced repeated “GitHub Actions job green on main” wording that does not match reality. A partial doc pass landed on main (docs/testing.md § CI, .github/workflows/README.md), but many files still imply GHA is live CI.

Goal

Strip or rewrite all references that read as “we use GitHub Actions today,” and establish one canonical story:

Concept Canonical wording
Where CI runs Local / QA host: make …, scripts/*.sh
.github/workflows/*.yml Reference spec only (optional: rename/move later — out of scope unless agreed)
Job names (e2e, frontend-e2e-indexer-outage, …) Keep as labels mapping to Make/scripts
“CI green on main” “Local/automation checklist passed” or named Make target

Do not delete workflow YAML in this issue unless explicitly decided — focus on docs, skills, comments, and issue templates.

Scope (audit starting points)

Run rg -i 'github actions|\.github/workflows|actions/setup|workflow_dispatch|GHA' from repo root and fix each hit in context.

High-traffic (update first):

Lower priority / archive:

  • docs/reviews/20260409T030009Z/* — add header “historical; CI model outdated” or fix in place
  • Open/closed GitLab issues that say “GitHub Actions” (comment or edit description when touched)

Exclude:

  • Links to third-party GitHub repos (TradingView, nvm, terraswap upstream, etc.)
  • package-lock.json / npm package metadata URLs

Acceptance criteria

  • rg -i 'github actions' under docs/, skills/, scripts/, Makefile, .github/ returns only intentional “we do not use GHA” statements (or zero hits)
  • docs/testing.md § CI includes a job name → local command table covering at least: contracts-terra, frontend, indexer, e2e, frontend-e2e-indexer-outage, frontend-charts-integration, frontend-charts-vitest
  • Every skills/AGENTS_*.md that mentions .github/workflows points to Make/scripts as the execution path
  • .github/workflows/README.md linked from docs/testing.md and root README.md (short “How we test” blurb)
  • No agent playbook tells third parties to “wait for GitHub Actions on main”

Suggested implementation notes

  1. Prefer “automation target” or “reference job e2e” over “CI job” in new text.
  2. Where a workflow step is the only doc for a script, duplicate the command in docs/testing.md or script header — workflow stays secondary.
  3. Optional follow-up (separate issue): move .github/workflows/ → docs/ci-reference/ to avoid the github path confusion.

Test plan

  • rg audit clean per acceptance criteria
  • Spot-check: new contributor reading README.md + docs/testing.md understands checks are local
  • make help / skill cross-links resolve
  • #219 — indexer-outage automation (local make test-e2e-indexer-outage)
  • Recent doc commits on main: 10d2179, bf80fd5
## Summary This repo is hosted on **GitLab** and does **not** run GitHub Actions or GitLab CI. The `.github/workflows/` YAML files are a **portable reference** for job names, service containers, and command order — agents and humans run the same checks via **Makefile targets** and `scripts/`. Issue [#219](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/219) verification surfaced repeated “GitHub Actions job green on `main`” wording that does not match reality. A partial doc pass landed on `main` ([`docs/testing.md` § CI](docs/testing.md#ci), [`.github/workflows/README.md`](.github/workflows/README.md)), but many files still imply GHA is live CI. ## Goal Strip or rewrite **all** references that read as “we use GitHub Actions today,” and establish one canonical story: | Concept | Canonical wording | |--------|-------------------| | Where CI runs | Local / QA host: `make …`, `scripts/*.sh` | | `.github/workflows/*.yml` | Reference spec only (optional: rename/move later — out of scope unless agreed) | | Job names (`e2e`, `frontend-e2e-indexer-outage`, …) | Keep as **labels** mapping to Make/scripts | | “CI green on main” | “Local/automation checklist passed” or named Make target | Do **not** delete workflow YAML in this issue unless explicitly decided — focus on **docs, skills, comments, and issue templates**. ## Scope (audit starting points) Run `rg -i 'github actions|\.github/workflows|actions/setup|workflow_dispatch|GHA'` from repo root and fix each hit in context. **High-traffic (update first):** - [`docs/testing.md`](docs/testing.md) — remaining “workflow runs …” phrasing; add Make↔job table if missing - [`docs/deployment-guide.md`](docs/deployment-guide.md) — hybrid wasm / optimizer workflow_dispatch - [`docs/frontend.md`](docs/frontend.md) — any “CI job” lines - [`skills/AGENTS_E2E_STRICT_CHAIN.md`](skills/AGENTS_E2E_STRICT_CHAIN.md), [`skills/AGENTS_E2E_INDEXER_OUTAGE.md`](skills/AGENTS_E2E_INDEXER_OUTAGE.md), [`skills/AGENTS_LOCAL_POSTGRES_DEV.md`](skills/AGENTS_LOCAL_POSTGRES_DEV.md) - [`skills/AGENTS_FRONTEND_MARKET_DATA_OUTAGE.md`](skills/AGENTS_FRONTEND_MARKET_DATA_OUTAGE.md) - [`Makefile`](Makefile) help text / comments - [`gaps/GAP_1780023683.md`](gaps/GAP_1780023683.md) - [`.github/workflows/test.yml`](.github/workflows/test.yml), [`contracts-wasm-optimizer.yml`](.github/workflows/contracts-wasm-optimizer.yml) — file headers (reference-only banner) - [`CODEOWNERS`](CODEOWNERS) if it implies GHA ownership **Lower priority / archive:** - `docs/reviews/20260409T030009Z/*` — add header “historical; CI model outdated” or fix in place - Open/closed GitLab issues that say “GitHub Actions” (comment or edit description when touched) **Exclude:** - Links to **third-party** GitHub repos (TradingView, nvm, terraswap upstream, etc.) - `package-lock.json` / npm package metadata URLs ## Acceptance criteria - [ ] `rg -i 'github actions'` under `docs/`, `skills/`, `scripts/`, `Makefile`, `.github/` returns only intentional “we do **not** use GHA” statements (or zero hits) - [ ] [`docs/testing.md` § CI](docs/testing.md#ci) includes a **job name → local command** table covering at least: `contracts-terra`, `frontend`, `indexer`, `e2e`, `frontend-e2e-indexer-outage`, `frontend-charts-integration`, `frontend-charts-vitest` - [ ] Every `skills/AGENTS_*.md` that mentions `.github/workflows` points to Make/scripts as the execution path - [ ] [`.github/workflows/README.md`](.github/workflows/README.md) linked from `docs/testing.md` and root [`README.md`](README.md) (short “How we test” blurb) - [ ] No agent playbook tells third parties to “wait for GitHub Actions on `main`” ## Suggested implementation notes 1. Prefer **“automation target”** or **“reference job `e2e`”** over “CI job” in new text. 2. Where a workflow step is the only doc for a script, **duplicate** the command in `docs/testing.md` or script header — workflow stays secondary. 3. Optional follow-up (separate issue): move `.github/workflows/` → `docs/ci-reference/` to avoid the `github` path confusion. ## Test plan - [ ] `rg` audit clean per acceptance criteria - [ ] Spot-check: new contributor reading `README.md` + `docs/testing.md` understands checks are local - [ ] `make help` / skill cross-links resolve ## Related - [#219](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/219) — indexer-outage automation (local `make test-e2e-indexer-outage`) - Recent doc commits on `main`: `10d2179`, `bf80fd5`
PlasticDigits commented 2026-05-30 06:43:31 +00:00 (Migrated from gitlab.com)

Done (pushed to main — c6c8e6b)

Documentation pass for local-only CI (#234): removed wording that implies live GitHub Actions / GitLab CI, and aligned agent playbooks with Make + scripts/ as the execution path.

Changes

  • Canonical CI story: docs/testing.md § CI — invariants table, full reference job → local command matrix, agent cross-links
  • .github/workflows/README.md — expanded mapping (merged with prior partial table on main)
  • Workflow YAML headers — test.yml / contracts-wasm-optimizer.yml marked reference-only
  • README — “How we test” blurb
  • Makefile, deployment guide, runbooks, gaps/GAP_1780023683.md, historical review bundle headers
  • skills/AGENTS_*.md — E2E strict chain, indexer outage, Postgres dev, P2 epic, price chart (no “wait for Actions on main”)

Verification checklist

  • rg -i 'github actions' docs/ skills/ scripts/ Makefile .github/ — only intentional “we do not use GHA” lines
  • Read README.md “How we test” + docs/testing.md § CI as a new contributor
  • make help lists targets that match the job table (test-frontend-charts, test-charts-integration, test-e2e-indexer-outage, etc.)
  • Skill links from docs/README.md and playbooks resolve
  • Spot-check docs/deployment-guide.md wasm policy: dev cargo wasm vs make build-optimized

@brouie — please verify the doc narrative matches how you run checks locally/QA. Issue stays open until sign-off.

## Done (pushed to `main` — c6c8e6b) Documentation pass for **local-only CI** ([#234](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/234)): removed wording that implies live GitHub Actions / GitLab CI, and aligned agent playbooks with Make + `scripts/` as the execution path. ### Changes - **Canonical CI story:** [docs/testing.md § CI](docs/testing.md#ci) — invariants table, full **reference job → local command** matrix, agent cross-links - **[`.github/workflows/README.md`](.github/workflows/README.md)** — expanded mapping (merged with prior partial table on `main`) - **Workflow YAML headers** — `test.yml` / `contracts-wasm-optimizer.yml` marked reference-only - **README** — “How we test” blurb - **Makefile**, deployment guide, runbooks, `gaps/GAP_1780023683.md`, historical review bundle headers - **`skills/AGENTS_*.md`** — E2E strict chain, indexer outage, Postgres dev, P2 epic, price chart (no “wait for Actions on main”) ### Verification checklist - [ ] `rg -i 'github actions' docs/ skills/ scripts/ Makefile .github/` — only intentional “we do **not** use GHA” lines - [ ] Read [README.md](README.md) “How we test” + [docs/testing.md § CI](docs/testing.md#ci) as a new contributor - [ ] `make help` lists targets that match the job table (`test-frontend-charts`, `test-charts-integration`, `test-e2e-indexer-outage`, etc.) - [ ] Skill links from `docs/README.md` and playbooks resolve - [ ] Spot-check [docs/deployment-guide.md](docs/deployment-guide.md) wasm policy: dev cargo wasm vs `make build-optimized` @brouie — please verify the doc narrative matches how you run checks locally/QA. Issue stays open until sign-off.
PlasticDigits commented 2026-05-30 06:44:02 +00:00 (Migrated from gitlab.com)

mentioned in commit b78e2261eb

mentioned in commit b78e2261eb45fafce8584a335444a79e248280e7
PlasticDigits commented 2026-05-30 06:44:02 +00:00 (Migrated from gitlab.com)

mentioned in commit c6c8e6b49e

mentioned in commit c6c8e6b49ebde7addb0d55d15ab1a6f3f00bd3d1
PlasticDigits commented 2026-05-30 06:45:51 +00:00 (Migrated from gitlab.com)

mentioned in commit b2f68c9e4e

mentioned in commit b2f68c9e4e426b21811b746fb45f5efb47e2eaf9
PlasticDigits commented 2026-05-30 06:45:56 +00:00 (Migrated from gitlab.com)

Verification complete (agent, main @ b2f68c9)

Verified GitLab #234 on worktree verify/issue-234 against all acceptance criteria in the issue body and the prior checklist comment. No infra restart was required.

What was already on main (c6c8e6b)

  • Canonical local-only CI story in docs/testing.md § CI — invariants table + full reference job → local command matrix
  • .github/workflows/README.md expanded mapping; workflow YAML headers marked reference-only
  • README “How we test” blurb; Makefile / deployment-guide / runbooks / gaps / historical review headers updated
  • Agent playbooks (AGENTS_E2E_*, AGENTS_LOCAL_POSTGRES_DEV, etc.) point to Make/scripts; no “wait for Actions on main”

Verification polish (b2f68c9)

Replaced four remaining ambiguous “CI” phrases in agent skills with explicit Make/reference-job wording:

  • skills/AGENTS_FEE_DISCOUNT_TIERS.md
  • skills/AGENTS_FRONTEND_MARKET_DATA_OUTAGE.md
  • skills/AGENTS_TESTING_P2_EPIC.md
  • skills/AGENTS_LOCALNET_TRADING_SWARM.md

Acceptance criteria checklist

  • rg -i 'github actions' docs/ skills/ scripts/ Makefile .github/ — only intentional “we do not use GHA” statements (verified)
  • docs/testing.md § CI job table covers contracts-terra, frontend, indexer, e2e, frontend-e2e-indexer-outage, frontend-charts-integration, frontend-charts-vitest
  • Every skills/AGENTS_*.md mentioning .github/workflows cites Make/scripts as execution path (AGENTS_E2E_STRICT_CHAIN, AGENTS_E2E_INDEXER_OUTAGE, AGENTS_LOCAL_POSTGRES_DEV)
  • .github/workflows/README.md linked from docs/testing.md § CI and root README.md
  • No agent playbook instructs “wait for GitHub Actions on main”

Test plan checklist

  • rg audit clean per above
  • README “How we test” + docs/testing.md § CI read coherently as local-only automation
  • make help lists test-frontend-charts, test-charts-integration, test-e2e-indexer-outage, build-optimized, etc.
  • Skill cross-links from docs/README.md and playbooks resolve (spot-checked paths)
  • docs/deployment-guide.md wasm policy: dev cargo wasm vs make build-optimized

@brouie — all automated/doc acceptance criteria pass. Please confirm the narrative matches how you run checks on local/QA hosts; close #234 when satisfied.

## Verification complete (agent, `main` @ b2f68c9) Verified GitLab **#234** on worktree `verify/issue-234` against all acceptance criteria in the issue body and the prior checklist comment. No infra restart was required. ### What was already on `main` (c6c8e6b) - Canonical **local-only CI** story in [docs/testing.md § CI](docs/testing.md#ci) — invariants table + full reference job → local command matrix - [`.github/workflows/README.md`](.github/workflows/README.md) expanded mapping; workflow YAML headers marked reference-only - README “How we test” blurb; Makefile / deployment-guide / runbooks / gaps / historical review headers updated - Agent playbooks (`AGENTS_E2E_*`, `AGENTS_LOCAL_POSTGRES_DEV`, etc.) point to Make/scripts; no “wait for Actions on `main`” ### Verification polish (b2f68c9) Replaced four remaining ambiguous **“CI”** phrases in agent skills with explicit Make/reference-job wording: - `skills/AGENTS_FEE_DISCOUNT_TIERS.md` - `skills/AGENTS_FRONTEND_MARKET_DATA_OUTAGE.md` - `skills/AGENTS_TESTING_P2_EPIC.md` - `skills/AGENTS_LOCALNET_TRADING_SWARM.md` ### Acceptance criteria checklist - [x] `rg -i 'github actions' docs/ skills/ scripts/ Makefile .github/` — only intentional “we do **not** use GHA” statements (verified) - [x] [docs/testing.md § CI](docs/testing.md#ci) job table covers `contracts-terra`, `frontend`, `indexer`, `e2e`, `frontend-e2e-indexer-outage`, `frontend-charts-integration`, `frontend-charts-vitest` - [x] Every `skills/AGENTS_*.md` mentioning `.github/workflows` cites Make/scripts as execution path (`AGENTS_E2E_STRICT_CHAIN`, `AGENTS_E2E_INDEXER_OUTAGE`, `AGENTS_LOCAL_POSTGRES_DEV`) - [x] [`.github/workflows/README.md`](.github/workflows/README.md) linked from [docs/testing.md § CI](docs/testing.md#ci) and root [README.md](README.md) - [x] No agent playbook instructs “wait for GitHub Actions on `main`” ### Test plan checklist - [x] `rg` audit clean per above - [x] README “How we test” + docs/testing.md § CI read coherently as local-only automation - [x] `make help` lists `test-frontend-charts`, `test-charts-integration`, `test-e2e-indexer-outage`, `build-optimized`, etc. - [x] Skill cross-links from `docs/README.md` and playbooks resolve (spot-checked paths) - [x] [docs/deployment-guide.md](docs/deployment-guide.md) wasm policy: dev cargo wasm vs `make build-optimized` @brouie — all automated/doc acceptance criteria pass. Please confirm the narrative matches how you run checks on local/QA hosts; close **#234** when satisfied.
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-05-30 06:46:44 +00:00
PlasticDigits commented 2026-05-30 06:46:45 +00:00 (Migrated from gitlab.com)

Closing per verification sign-off — all acceptance criteria from #234 and the verification checklist passed on main (through b2f68c9). Local-only CI story is canonical in docs/testing.md § CI and .github/workflows/README.md.

Closing per verification sign-off — all acceptance criteria from #234 and the verification checklist passed on `main` (through b2f68c9). Local-only CI story is canonical in docs/testing.md § CI and .github/workflows/README.md.
PlasticDigits commented 2026-05-30 10:10:07 +00:00 (Migrated from gitlab.com)

mentioned in issue #201

mentioned in issue #201
PlasticDigits commented 2026-06-25 13:12:46 +00:00 (Migrated from gitlab.com)

mentioned in issue #411

mentioned in issue #411
PlasticDigits commented 2026-06-25 14:13:00 +00:00 (Migrated from gitlab.com)

mentioned in issue #421

mentioned in issue #421
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic#234
No description provided.