code/cl8y-dex-terraclassic

Fork 0

QA: add fresh-volumes toggle for make start-qa (or make reset-qa) #202

New issue

Closed

opened 2026-05-27 02:38:21 +00:00 by PlasticDigits · 9 comments

PlasticDigits commented

2026-05-27 02:38:21 +00:00

(Migrated from gitlab.com)

Split from #120 — @PlasticDigits requested a dedicated ticket after QA verification discovered stale deployed contracts on a reused LocalTerra volume.

Problem

make start-qa tears down the compose stack via stop-qa.sh but does not remove Docker volumes (localterra-data, postgres-data). A subsequent start-qa reuses chain state from prior runs while deploy-local only redeploys wasm from the current tree. That mismatch is easy to miss and can invalidate contract-side live walks (see sister issue for stale-contract detection).

During #120 verification, the QA stack was running pre-b03152d contracts until volumes were manually removed:

docker volume rm cl8y-dex-terraclassic_localterra-data cl8y-dex-terraclassic_postgres-data
make start-qa

Proposed scope

Operator toggle — one of:
- QA_FRESH_VOLUMES=1 make start-qa (or similar env flag documented in scripts/qa/README.md), or
- dedicated make reset-qa target that runs docker compose down -v (or removes the QA-named volumes) then chains into start-qa.
Clear UX — when fresh volumes are requested, print an explicit banner that LocalTerra + Postgres state was wiped (distinct from the normal incremental restart path).
Docs — when to use fresh vs reuse (fast iteration vs post-contract-change verification); cross-link stale-contracts ticket.

Acceptance

One documented path to start QA with empty LocalTerra + Postgres volumes
Default make start-qa behaviour unchanged unless toggle is set (preserve fast restarts where safe)
scripts/qa/README.md + make help mention the toggle/target

Parent investigation: #120
Sister issue: stale deployed contracts on reused volumes (file separately)

Split from [#120](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/120) — @PlasticDigits requested a dedicated ticket after QA verification discovered stale deployed contracts on a reused LocalTerra volume. ## Problem `make start-qa` tears down the compose stack via `stop-qa.sh` but **does not remove Docker volumes** (`localterra-data`, `postgres-data`). A subsequent `start-qa` reuses chain state from prior runs while `deploy-local` only redeploys wasm from the current tree. That mismatch is easy to miss and can invalidate contract-side live walks (see sister issue for stale-contract detection). During #120 verification, the QA stack was running pre-`b03152d` contracts until volumes were manually removed: ```bash docker volume rm cl8y-dex-terraclassic_localterra-data cl8y-dex-terraclassic_postgres-data make start-qa ``` ## Proposed scope 1. **Operator toggle** — one of: - `QA_FRESH_VOLUMES=1 make start-qa` (or similar env flag documented in `scripts/qa/README.md`), or - dedicated `make reset-qa` target that runs `docker compose down -v` (or removes the QA-named volumes) then chains into `start-qa`. 2. **Clear UX** — when fresh volumes are requested, print an explicit banner that LocalTerra + Postgres state was wiped (distinct from the normal incremental restart path). 3. **Docs** — when to use fresh vs reuse (fast iteration vs post-contract-change verification); cross-link stale-contracts ticket. ## Acceptance - [ ] One documented path to start QA with empty LocalTerra + Postgres volumes - [ ] Default `make start-qa` behaviour unchanged unless toggle is set (preserve fast restarts where safe) - [ ] `scripts/qa/README.md` + `make help` mention the toggle/target ## Related - Parent investigation: #120 - Sister issue: stale deployed contracts on reused volumes (file separately)

PlasticDigits commented

2026-05-27 02:38:28 +00:00

(Migrated from gitlab.com)

mentioned in issue #120

PlasticDigits commented

2026-05-27 13:44:41 +00:00

(Migrated from gitlab.com)

Implemented (main @ `5ce70a6`)

Added a documented operator path to start QA with empty LocalTerra + Postgres volumes while keeping default make start-qa behaviour unchanged.

What changed

make reset-qa — sets QA_FRESH_VOLUMES=1 and runs full start-qa (teardown uses docker compose down -v).
QA_FRESH_VOLUMES=1 make start-qa — same as reset-qa.
Red banner when fresh volumes are requested (distinct from the yellow SSH-tunnel reminder).
Shared helpers: scripts/qa/lib/qa-env.sh, scripts/qa/lib/print-fresh-volumes-banner.sh.
make test-qa-fresh-volumes — unit checks (no Docker).
Docs: docs/qa-invariants.md, scripts/qa/README.md, make help, docs/README.md, docs/qa-onboarding.md.
Agent playbook: skills/AGENTS_QA_FRESH_VOLUMES.md (cross-links #202, #203, #120).

Verification checklist

make test-qa-fresh-volumes passes on a clean clone.
make help lists reset-qa and QA_FRESH_VOLUMES=1 make start-qa.
make start-qa (no flag): stop-qa path uses docker compose down without -v; no red fresh-volumes banner.
make reset-qa (or QA_FRESH_VOLUMES=1 make start-qa): red banner; logs show volume removal; docker volume ls does not show stale cl8y-dex-terraclassic_localterra-data / _postgres-data after teardown (recreated on up).
After reset, make deploy-local runs and contract addresses in frontend-dapp/.env.local / indexer/.env match a fresh chain walk.
make stop-qa alone still preserves volumes.
With QA_SHARED_HOST=1, fresh reset still uses the QA compose overlay.

Leaving issue open for operator sign-off.

@brouie — please verify on the QA host when convenient.

## Implemented (main @ 5ce70a6) Added a documented operator path to start QA with **empty LocalTerra + Postgres volumes** while keeping default `make start-qa` behaviour unchanged. ### What changed - **`make reset-qa`** — sets `QA_FRESH_VOLUMES=1` and runs full `start-qa` (teardown uses `docker compose down -v`). - **`QA_FRESH_VOLUMES=1 make start-qa`** — same as `reset-qa`. - **Red banner** when fresh volumes are requested (distinct from the yellow SSH-tunnel reminder). - Shared helpers: `scripts/qa/lib/qa-env.sh`, `scripts/qa/lib/print-fresh-volumes-banner.sh`. - **`make test-qa-fresh-volumes`** — unit checks (no Docker). - Docs: `docs/qa-invariants.md`, `scripts/qa/README.md`, `make help`, `docs/README.md`, `docs/qa-onboarding.md`. - Agent playbook: `skills/AGENTS_QA_FRESH_VOLUMES.md` (cross-links #202, #203, #120). ### Verification checklist - [ ] `make test-qa-fresh-volumes` passes on a clean clone. - [ ] `make help` lists `reset-qa` and `QA_FRESH_VOLUMES=1 make start-qa`. - [ ] `make start-qa` (no flag): `stop-qa` path uses `docker compose down` **without** `-v`; no red fresh-volumes banner. - [ ] `make reset-qa` (or `QA_FRESH_VOLUMES=1 make start-qa`): red banner; logs show volume removal; `docker volume ls` does not show stale `cl8y-dex-terraclassic_localterra-data` / `_postgres-data` after teardown (recreated on up). - [ ] After reset, `make deploy-local` runs and contract addresses in `frontend-dapp/.env.local` / `indexer/.env` match a fresh chain walk. - [ ] `make stop-qa` alone still preserves volumes. - [ ] With `QA_SHARED_HOST=1`, fresh reset still uses the QA compose overlay. Leaving issue **open** for operator sign-off. @brouie — please verify on the QA host when convenient.

PlasticDigits commented

2026-05-27 13:44:48 +00:00

(Migrated from gitlab.com)

mentioned in commit 5ce70a6d04

mentioned in commit 5ce70a6d0468a0643858eed7f9b87d3ddae50da2

PlasticDigits commented

2026-05-27 13:45:46 +00:00

(Migrated from gitlab.com)

mentioned in issue #203

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-05-27 13:47:54 +00:00

PlasticDigits commented

2026-05-27 13:47:56 +00:00

(Migrated from gitlab.com)

Verified on main at 3226630 — merged locally and pushed to origin/main.

Verified on `main` at 3226630 — merged locally and pushed to origin/main.

PlasticDigits (Migrated from gitlab.com) reopened this issue

2026-05-27 13:50:32 +00:00

PlasticDigits commented

2026-05-27 13:50:34 +00:00

(Migrated from gitlab.com)

Reopened: fix is merged to main but this issue stays open until QA/verification is complete. (Previously closed in error during repo cleanup.)

Reopened: fix is merged to `main` but this issue stays open until QA/verification is complete. (Previously closed in error during repo cleanup.)

PlasticDigits commented

2026-05-30 10:37:24 +00:00

(Migrated from gitlab.com)

Verification (#202) — agent @ `main` @ `956d469`

Verified in git worktree verify/issue-202 (compose project cl8y-dex-terraclassic shared across worktrees per docs/qa-invariants.md).

Issue acceptance (body)

Documented path for empty LocalTerra + Postgres: make reset-qa and QA_FRESH_VOLUMES=1 make start-qa
Default make start-qa unchanged (volumes kept; docker compose down without -v)
scripts/qa/README.md + make help document toggle/target

Checklist (implementation comment)

make test-qa-fresh-volumes — pass
make help lists reset-qa and QA_FRESH_VOLUMES=1 make start-qa
Default stop-qa: no -v; volumes cl8y-dex-terraclassic_{localterra,postgres}-data remain
QA_FRESH_VOLUMES=1 / reset-qa: red banner; [stop-qa] Removing QA Docker volumes (-v); volumes removed then recreated on up
make stop-qa alone preserves volumes (tested between fresh/non-fresh stops)
make qa-verify-deploy from host: blocked here — TCP connects to 127.0.0.1:26657 but HTTP hangs; docker exec … curl inside the container succeeds (host port-proxy issue, not #202)
[~] Full make reset-qa after fresh wipe: volume/banner/deploy path OK; first run hit **rm: cannot remove root-owned cw20_mintable temp dir → fixed in 956d469 (scripts/deploy-dex-local.sh). Subsequent make deploy-local on fresh chain completed; stamp git_sha=a07db41 written.

Follow-up for operator

@brouie — please confirm on the QA host:

make qa-verify-deploy after make reset-qa (or fresh deploy)
Host RPC/LCD reachable on published ports (not only in-container)
Optional: QA_SHARED_HOST=1 make reset-qa on shared-host layout

Docs / agents

Cross-links already present: docs/qa-invariants.md, skills/AGENTS_QA_FRESH_VOLUMES.md, skills/AGENTS_QA_DEPLOY_VERIFY.md (#203).

Status: #202 scope verified; leaving open until host RPC check and operator sign-off on the checklist above pass.

## Verification (#202) — agent @ `main` @ 956d469 Verified in git worktree `verify/issue-202` (compose project `cl8y-dex-terraclassic` shared across worktrees per `docs/qa-invariants.md`). ### Issue acceptance (body) - [x] Documented path for empty LocalTerra + Postgres: **`make reset-qa`** and **`QA_FRESH_VOLUMES=1 make start-qa`** - [x] Default **`make start-qa`** unchanged (volumes kept; `docker compose down` without `-v`) - [x] **`scripts/qa/README.md`** + **`make help`** document toggle/target ### Checklist (implementation comment) - [x] `make test-qa-fresh-volumes` — pass - [x] `make help` lists `reset-qa` and `QA_FRESH_VOLUMES=1 make start-qa` - [x] Default `stop-qa`: no `-v`; volumes `cl8y-dex-terraclassic_{localterra,postgres}-data` remain - [x] `QA_FRESH_VOLUMES=1` / `reset-qa`: red banner; `[stop-qa] Removing QA Docker volumes (-v)`; volumes removed then recreated on `up` - [x] `make stop-qa` alone preserves volumes (tested between fresh/non-fresh stops) - [ ] **`make qa-verify-deploy`** from host: **blocked here** — TCP connects to `127.0.0.1:26657` but HTTP hangs; `docker exec … curl` inside the container succeeds (host port-proxy issue, not #202) - [~] Full **`make reset-qa`** after fresh wipe: volume/banner/deploy path OK; first run hit **`rm: cannot remove` root-owned `cw20_mintable` temp dir → fixed in **956d469** (`scripts/deploy-dex-local.sh`). Subsequent **`make deploy-local`** on fresh chain completed; stamp `git_sha=a07db41` written. ### Follow-up for operator @brouie — please confirm on the QA host: 1. `make qa-verify-deploy` after `make reset-qa` (or fresh deploy) 2. Host RPC/LCD reachable on published ports (not only in-container) 3. Optional: `QA_SHARED_HOST=1 make reset-qa` on shared-host layout ### Docs / agents Cross-links already present: `docs/qa-invariants.md`, `skills/AGENTS_QA_FRESH_VOLUMES.md`, `skills/AGENTS_QA_DEPLOY_VERIFY.md` ([#203](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/203)). **Status:** #202 scope verified; leaving **open** until host RPC check and operator sign-off on the checklist above pass.

PlasticDigits commented

2026-05-30 11:37:58 +00:00

(Migrated from gitlab.com)

Verification complete (#202) — `main` @ `85eb098`

Issue acceptance

Documented fresh-volume path: make reset-qa / QA_FRESH_VOLUMES=1 make start-qa
Default make start-qa unchanged (volumes preserved unless toggle)
scripts/qa/README.md + make help document toggle/target

Follow-up in this commit (host port hang)

Scripts/agents now use docker exec fallback when host curl to published 127.0.0.1:26657/1317 hangs (scripts/lib/localterra-host-curl.sh):

make qa-verify-deploy — PASS (schema + stamp after stamp refresh)
make wait-localterra / make test-localterra-host-curl
LCD helpers via lcd-smart-query.sh

Docs: docs/qa-invariants.md, docs/local-development.md, skills/AGENTS_QA_FRESH_VOLUMES.md, skills/AGENTS_QA_DEPLOY_VERIFY.md.

Checklist

make test-qa-fresh-volumes
make test-qa-verify-deploy (includes test-localterra-host-curl live exec probe)
make qa-verify-deploy
Volume keep vs down -v (prior session)
Red banner on reset-qa

Closing #202 — fresh-volumes scope verified; host verification unblocked via exec fallback.

## Verification complete (#202) — `main` @ 85eb098 ### Issue acceptance - [x] Documented fresh-volume path: `make reset-qa` / `QA_FRESH_VOLUMES=1 make start-qa` - [x] Default `make start-qa` unchanged (volumes preserved unless toggle) - [x] `scripts/qa/README.md` + `make help` document toggle/target ### Follow-up in this commit (host port hang) Scripts/agents now use **`docker exec` fallback** when host `curl` to published `127.0.0.1:26657`/`1317` hangs ([`scripts/lib/localterra-host-curl.sh`](scripts/lib/localterra-host-curl.sh)): - `make qa-verify-deploy` — **PASS** (schema + stamp after stamp refresh) - `make wait-localterra` / `make test-localterra-host-curl` - LCD helpers via `lcd-smart-query.sh` Docs: `docs/qa-invariants.md`, `docs/local-development.md`, `skills/AGENTS_QA_FRESH_VOLUMES.md`, `skills/AGENTS_QA_DEPLOY_VERIFY.md`. ### Checklist - [x] `make test-qa-fresh-volumes` - [x] `make test-qa-verify-deploy` (includes `test-localterra-host-curl` live exec probe) - [x] `make qa-verify-deploy` - [x] Volume keep vs `down -v` (prior session) - [x] Red banner on `reset-qa` Closing #202 — fresh-volumes scope verified; host verification unblocked via exec fallback.

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-05-30 11:37:59 +00:00

PlasticDigits commented

2026-06-07 12:14:17 +00:00

(Migrated from gitlab.com)

mentioned in issue #337