code/cl8y-dex-terraclassic

Fork 0

W7-C5: Expiry section — NO EXPIRY has no tooltip, past date disables submit with no explanation #156

New issue

Closed

opened 2026-05-11 14:32:52 +00:00 by totdking · 11 comments

totdking commented

2026-05-11 14:32:52 +00:00

(Migrated from gitlab.com)

No description provided.

totdking commented

2026-05-11 14:34:05 +00:00

(Migrated from gitlab.com)

Issue Summary

Two gaps in the EXPIRES section of the Place Limit panel under /limit :

NO EXPIRY has no hover tooltip — trader cannot tell what happens to the order with no expiry set
Past date entry disables the Place Limit button with no inline error or tooltip explaining why

Note: 24H / 7D presets correctly calculate and display the human-readable expiry date — pass.

Note on ADVANCED: Book insert walk limit description references max_adjust_steps (on-chain + docs) — developer language with no plain-language equivalent for traders.

Reproduction Steps

Navigate to /trade, select any pair — hover over NO EXPIRY — no tooltip appears
Enter a past date in the date picker — Place Limit button disables with no explanation

Environment Details

Field	Value
OS	macOS (Apple M1 Pro, 14-inch)
Browser	Google Chrome (desktop)
Network	`localterra` (local Docker)
Frontend	`VITE_NETWORK=local npm run dev` at `localhost:3000`

Wallet / Device Details

Wallet: Keplr browser extension
Wallet state: Connected — terra1...sl7cvv
Pair tested: EMBER / CORAL (terra146...c9mjav)

Severity / Impact

P2 Polish. Found under W7-C5 (Expiry — Display, Interactivity, and Trader use dimensions).

cc: @PlasticDigits

### Issue Summary Two gaps in the EXPIRES section of the Place Limit panel under `/limit` : 1. **NO EXPIRY** has no hover tooltip — trader cannot tell what happens to the order with no expiry set 2. **Past date entry** disables the Place Limit button with no inline error or tooltip explaining why **Note:** 24H / 7D presets correctly calculate and display the human-readable expiry date — pass. **Note on ADVANCED:** Book insert walk limit description references `max_adjust_steps (on-chain + docs)` — developer language with no plain-language equivalent for traders. --- ### Reproduction Steps 1. Navigate to `/trade`, select any pair — hover over **NO EXPIRY** — no tooltip appears 2. Enter a past date in the date picker — Place Limit button disables with no explanation --- ### Environment Details | Field | Value | |-------|-------| | OS | macOS (Apple M1 Pro, 14-inch) | | Browser | Google Chrome (desktop) | | Network | `localterra` (local Docker) | | Frontend | `VITE_NETWORK=local npm run dev` at `localhost:3000` | --- ### Wallet / Device Details - **Wallet:** Keplr browser extension - **Wallet state:** Connected — `terra1...sl7cvv` - **Pair tested:** EMBER / CORAL (`terra146...c9mjav`) --- ### Severity / Impact ## **P2 Polish.** Found under **W7-C5** (Expiry — Display, Interactivity, and Trader use dimensions). cc: @PlasticDigits

totdking commented

2026-05-11 17:31:47 +00:00

(Migrated from gitlab.com)

mentioned in issue #116

Brouie commented

2026-05-13 04:16:01 +00:00

(Migrated from gitlab.com)

mentioned in commit e289e8d6f6

mentioned in commit e289e8d6f6fc97cab0b737b61f28173e5a5d7baf

Brouie commented

2026-05-13 04:16:46 +00:00

(Migrated from gitlab.com)

mentioned in merge request !732

Brouie commented

2026-05-13 04:17:24 +00:00

(Migrated from gitlab.com)

mr !732 opened for both gaps — https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/14

covers:

(1) NO EXPIRY tooltip + active-state styling + hint copy when selected
(2) past-date inline error in the expiry field + wired into Place Limit gate so the button disables with a clear reason instead of silently

tests: new LimitOrderExpiryField.test.tsx with 7 cases, full frontend suite 441/441 PASS at branch head.

side-note on ADVANCED's max_adjust_steps language left out of scope — can address separately if desired.

/cc @PlasticDigits @totdking

mr !732 opened for both gaps — https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/14 covers: - (1) NO EXPIRY tooltip + active-state styling + hint copy when selected - (2) past-date inline error in the expiry field + wired into Place Limit gate so the button disables with a clear reason instead of silently tests: new LimitOrderExpiryField.test.tsx with 7 cases, full frontend suite 441/441 PASS at branch head. side-note on ADVANCED's max_adjust_steps language left out of scope — can address separately if desired. /cc @PlasticDigits @totdking

PlasticDigits commented

2026-05-13 04:27:09 +00:00

(Migrated from gitlab.com)

mentioned in commit 0761f93384

mentioned in commit 0761f93384aabc667b2239fd12df7835ee5e5c95

Brouie commented

2026-05-13 05:28:05 +00:00

(Migrated from gitlab.com)

mentioned in issue #120

PlasticDigits commented

2026-05-13 06:38:05 +00:00

(Migrated from gitlab.com)

@Brouie Please open a seperate issue for max_adjust_steps language, we should have high, medium, and low defaults with custom, and explain that its gas costs (high gas, medium, low etc)

Brouie commented

2026-05-13 07:23:05 +00:00

(Migrated from gitlab.com)

mentioned in issue #141

PlasticDigits commented

2026-05-27 05:13:02 +00:00

(Migrated from gitlab.com)

mentioned in issue #204

PlasticDigits commented

2026-05-27 05:13:05 +00:00

(Migrated from gitlab.com)

Expiry gaps from this issue were addressed in !732 (NO EXPIRY tooltip + past-date inline error).

Follow-up for the Advanced → max_adjust_steps developer language split out per @PlasticDigits: #204 — trader-friendly Low / Medium / High / Custom gas presets with plain-language copy.

Closing #156; track the Advanced copy work on #204.

Expiry gaps from this issue were addressed in !732 (NO EXPIRY tooltip + past-date inline error). Follow-up for the **Advanced → max_adjust_steps** developer language split out per @PlasticDigits: [**#204**](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/204) — trader-friendly **Low / Medium / High / Custom** gas presets with plain-language copy. Closing #156; track the Advanced copy work on #204.

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-05-27 05:13:06 +00:00