code/cl8y-dex-terraclassic

Fork 0

Price (USD) chart missing volume bars, indicators menu, and fullscreen control . No standard charting overlays available (No tools beyond basic candlesticks) #150

New issue

Closed

opened 2026-05-07 17:18:58 +00:00 by totdking · 17 comments

totdking commented

2026-05-07 17:18:58 +00:00

(Migrated from gitlab.com)

No description provided.

totdking commented

2026-05-07 17:27:04 +00:00

(Migrated from gitlab.com)

Issue Summary

The Price (USD) chart on /trade renders candlesticks only. There are no volume bars below the candles, no indicators menu, and no fullscreen or expand control. A CEX-migrant trader expects these as baseline charting tools for pre-trade context; without them the chart shows price history only, with no way to assess volume, momentum, or trend before placing an order.

Reproduction Steps

Navigate to /trade
Select any active pair (e.g. EMBER/CORAL)
Observe the Price (USD) chart panel
Look for volume bars below candles -> none present
Look for an indicators or overlays menu on the chart -> none present
Look for a fullscreen or expand control -> none present

Expected Behavior

Volume bars rendered below candles as a baseline overlay
An indicators menu allowing at minimum moving averages or RSI
A fullscreen or expand control to enlarge the chart for detailed analysis

Actual Behavior

No volume bars anywhere on the chart
No indicators or overlays menu present
No fullscreen or expand control present
Chart is fixed in its panel with no way to enlarge it

Environment Details

Field	Value
OS	macOS (Apple M1 Pro, 14-inch)
Browser	Google Chrome (desktop)
Viewport	1470×864
Network	`localterra` (local Docker)
Frontend	`VITE_NETWORK=local npm run dev`

Wallet / Device Details

Wallet: Simulated dev wallet
Wallet state: Connected — localterra
Pair tested: EMBER/CORAL

Screenshots

See attached screenshot showing the Price (USD) chart with candles only — no volume bars, no indicators menu, no expand control.

{width="900" height="580"}

Severity / Impact

P2 Polish. Chart remains functional for basic price history reading. No funds are at risk. However the absence of volume and indicators is a meaningful gap for a CEX-migrant trader who relies on these to assess entry timing. Found under W6-C2 (Overlays — Display and Interactivity dimensions).

cc: @PlasticDigits

### Issue Summary The Price (USD) chart on `/trade` renders candlesticks only. There are no volume bars below the candles, no indicators menu, and no fullscreen or expand control. A CEX-migrant trader expects these as baseline charting tools for pre-trade context; without them the chart shows price history only, with no way to assess volume, momentum, or trend before placing an order. --- ### Reproduction Steps 1. Navigate to `/trade` 2. Select any active pair (e.g. EMBER/CORAL) 3. Observe the Price (USD) chart panel 4. Look for volume bars below candles -\> none present 5. Look for an indicators or overlays menu on the chart -\> none present 6. Look for a fullscreen or expand control -\> none present --- ### Expected Behavior - Volume bars rendered below candles as a baseline overlay - An indicators menu allowing at minimum moving averages or RSI - A fullscreen or expand control to enlarge the chart for detailed analysis --- ### Actual Behavior - No volume bars anywhere on the chart - No indicators or overlays menu present - No fullscreen or expand control present - Chart is fixed in its panel with no way to enlarge it --- ### Environment Details | Field | Value | |-------|-------| | OS | macOS (Apple M1 Pro, 14-inch) | | Browser | Google Chrome (desktop) | | Viewport | 1470×864 | | Network | `localterra` (local Docker) | | Frontend | `VITE_NETWORK=local npm run dev` | --- ### Wallet / Device Details - **Wallet:** Simulated dev wallet - **Wallet state:** Connected — localterra - **Pair tested:** EMBER/CORAL --- ### Screenshots > See attached screenshot showing the Price (USD) chart with candles only — no volume bars, no indicators menu, no expand control. ![image.png](/uploads/9a4c42701160fc907ac356d2a92b3440/image.png){width="900" height="580"} --- ### Severity / Impact **P2 Polish.** Chart remains functional for basic price history reading. No funds are at risk. However the absence of volume and indicators is a meaningful gap for a CEX-migrant trader who relies on these to assess entry timing. Found under **W6-C2** (Overlays — Display and Interactivity dimensions). cc: @PlasticDigits

totdking commented

2026-05-07 17:32:42 +00:00

(Migrated from gitlab.com)

mentioned in issue #116

PlasticDigits commented

2026-05-09 09:38:54 +00:00

(Migrated from gitlab.com)

mentioned in commit 8a8cd4e3aa

mentioned in commit 8a8cd4e3aad7614782c8718dfbd69d595cd8d97a

PlasticDigits commented

2026-05-09 09:38:55 +00:00

(Migrated from gitlab.com)

mentioned in commit 9ded951a86

mentioned in commit 9ded951a866811a414ef3cbdcabfb4b05e021e28

PlasticDigits commented

2026-05-09 09:39:17 +00:00

(Migrated from gitlab.com)

mentioned in issue #149

PlasticDigits commented

2026-05-09 09:42:14 +00:00

(Migrated from gitlab.com)

mentioned in commit a153784cd3

mentioned in commit a153784cd3618551955b5af11c6eea1f7ba6235b

PlasticDigits commented

2026-05-09 09:42:29 +00:00

(Migrated from gitlab.com)

Update (implementation)

Delivered TradingView lightweight-charts enhancements on /trade and /charts (not the hosted TradingView widget):

Volume: Dedicated histogram pane below candles; quote volume first, base fallback when quote is zero (common on local indexers). Panel strip height increased for readability; header sub-label Volume (quote, else base) explains the rule.
Indicators menu: MA 7, MA 25 (overlays on the price pane), RSI 14 (separate pane, 0–100 with 70/30 guide lines). Toggling overlays recreates the chart (zoom resets).
Expand / Exit: Fullscreen API on the chart card for a larger analysis surface.
Combined with existing work: Last headline price (#149) and USD Y-axis clamp (#151) remain; docs and skills/AGENTS_FRONTEND_PRICE_CHART.md crosslink #113, #149, #150, #151.

Verification checklist

Open /trade, select a pair with candles — confirm histogram under candles (non-flat when indexer has volume).
Indicators → enable MA 7 / MA 25 / RSI 14 — lines and RSI pane appear; disable — overlays remove.
Expand / Exit — chart card enters and leaves fullscreen.
Local indexer with volume_quote: 0 but non-zero volume_base — bars still show relative height.
Run cd frontend-dapp && npm run test:run && npm run build — green.

@totdking please verify on your side when convenient.

Issue left open pending your confirmation.

## Update (implementation) Delivered **TradingView lightweight-charts** enhancements on `/trade` and `/charts` (not the hosted TradingView widget): - **Volume:** Dedicated histogram pane below candles; **quote** volume first, **base** fallback when quote is zero (common on local indexers). Panel strip height increased for readability; header sub-label **Volume (quote, else base)** explains the rule. - **Indicators menu:** MA **7**, MA **25** (overlays on the price pane), **RSI 14** (separate pane, 0–100 with 70/30 guide lines). Toggling overlays **recreates** the chart (zoom resets). - **Expand / Exit:** Fullscreen API on the chart card for a larger analysis surface. - **Combined with existing work:** **Last** headline price (#149) and **USD Y-axis** clamp (#151) remain; docs and `skills/AGENTS_FRONTEND_PRICE_CHART.md` crosslink **#113**, **#149**, **#150**, **#151**. ### Verification checklist - [ ] Open `/trade`, select a pair with candles — confirm **histogram** under candles (non-flat when indexer has volume). - [ ] **Indicators** → enable MA 7 / MA 25 / RSI 14 — lines and RSI pane appear; disable — overlays remove. - [ ] **Expand** / **Exit** — chart card enters and leaves fullscreen. - [ ] Local indexer with `volume_quote: 0` but non-zero `volume_base` — bars still show relative height. - [ ] Run `cd frontend-dapp && npm run test:run && npm run build` — green. @totdking please verify on your side when convenient. Issue left **open** pending your confirmation.

totdking commented

2026-05-11 12:29:00 +00:00

(Migrated from gitlab.com)

mentioned in issue #151

totdking commented

2026-05-12 14:05:10 +00:00

(Migrated from gitlab.com)

Open /trade, select a pair with candles — confirm histogram under candles (non-flat when indexer has volume).
Indicators → enable MA 7 / MA 25 / RSI 14 — lines and RSI pane appear; disable — overlays remove.
Expand / Exit — chart card enters and leaves fullscreen.
Local indexer with volume_quote: 0 but non-zero volume_base — bars still show relative height.
Run cd frontend-dapp && npm run test:run && npm run build — green.

Gaps noticed

for the indicators, if activated, it does not show up immediately on the chart, i would have to change the timeframe for any of the indicators to show up .

Screen record:

cc: @PlasticDigits

* [x] Open `/trade`, select a pair with candles — confirm **histogram** under candles (non-flat when indexer has volume). * [ ] **Indicators** → enable MA 7 / MA 25 / RSI 14 — lines and RSI pane appear; disable — overlays remove. * [x] **Expand** / **Exit** — chart card enters and leaves fullscreen. * [x] Local indexer with `volume_quote: 0` but non-zero `volume_base` — bars still show relative height. * [x] Run `cd frontend-dapp && npm run test:run && npm run build` — green. ## Gaps noticed for the indicators, if activated, it does not show up immediately on the chart, i would have to change the timeframe for any of the indicators to show up . ### Screen record: ![Screen Recording 2026-05-12 at 15.01.16.mov](/uploads/da1d1cd8f2b388f5991b664a718b5816/Screen_Recording_2026-05-12_at_15.01.16.mov) cc: @PlasticDigits

PlasticDigits commented

2026-05-13 05:19:38 +00:00

(Migrated from gitlab.com)

mentioned in commit 1e364061e4

mentioned in commit 1e364061e4ce8b894bcd7b8e1a68857d90460f3f

PlasticDigits commented

2026-05-13 05:20:10 +00:00

(Migrated from gitlab.com)

Update (GitLab #150 — indicators QA)

Implemented a fix for MA 7 / MA 25 / RSI 14 toggles on the Price (USD) chart (dfb6d48 on main).

What changed

The chart is created once; indicators are applied with lightweight-charts addSeries / removeSeries, and RSI uses addPane / removePane(2) instead of tearing down the whole chart on every checkbox change.
That removes the async re-init race (dynamic import() + effect cleanup) that could leave overlays missing after QA toggles.
Logic lives in frontend-dapp/src/components/charts/priceChartLightweightIndicatorSync.ts with unit tests; PriceChart test covers toggling MA 7 after load.
Docs / agent crosslinks: docs/frontend.md § Trade page — price chart invariants; skills/AGENTS_FRONTEND_PRICE_CHART.md.

Checklist for verification

/trade (or /charts) with a pair that has candle history: open Indicators, enable MA 7 — cyan overlay appears on the price pane; disable — overlay disappears.
Enable MA 25 — amber overlay; disable — gone.
Enable RSI 14 — third pane appears (0–100 scale, 70/30 guides); disable — RSI pane removed, layout returns to candle + volume only.
Toggle combinations quickly (e.g. all on → all off → RSI only) — no blank chart, no stuck ghost panes.
Optional: resize the chart card / fullscreen — volume and RSI pane heights still look reasonable.

@totdking could you re-run the QA scenario above on latest main and confirm?

Issue left open until you sign off.

## Update (GitLab #150 — indicators QA) Implemented a fix for **MA 7 / MA 25 / RSI 14** toggles on the Price (USD) chart (`dfb6d48` on `main`). ### What changed - The chart is **created once**; indicators are applied with lightweight-charts **`addSeries` / `removeSeries`**, and RSI uses **`addPane` / `removePane(2)`** instead of tearing down the whole chart on every checkbox change. - That removes the **async re-init race** (dynamic `import()` + effect cleanup) that could leave overlays missing after QA toggles. - Logic lives in `frontend-dapp/src/components/charts/priceChartLightweightIndicatorSync.ts` with unit tests; `PriceChart` test covers toggling MA 7 after load. - **Docs / agent crosslinks:** `docs/frontend.md` § Trade page — price chart invariants; `skills/AGENTS_FRONTEND_PRICE_CHART.md`. ### Checklist for verification - [ ] `/trade` (or `/charts`) with a pair that has candle history: open **Indicators**, enable **MA 7** — cyan overlay appears on the price pane; disable — overlay disappears. - [ ] Enable **MA 25** — amber overlay; disable — gone. - [ ] Enable **RSI 14** — third pane appears (0–100 scale, 70/30 guides); disable — RSI pane removed, layout returns to candle + volume only. - [ ] Toggle combinations quickly (e.g. all on → all off → RSI only) — no blank chart, no stuck ghost panes. - [ ] Optional: resize the chart card / fullscreen — volume and RSI pane heights still look reasonable. @totdking could you re-run the QA scenario above on latest `main` and confirm? Issue left **open** until you sign off.

PlasticDigits commented

2026-05-27 04:45:26 +00:00

(Migrated from gitlab.com)

Verification complete (agent QA — 2026-05-27)

Re-verified GitLab #150 on latest main (3f6a2e5) against the full local stack:

Services: LocalTerra healthy · host Postgres :5432 · indexer http://127.0.0.1:3001 · frontend http://127.0.0.1:3000 · bot swarm active.

Checklist

/trade (EMBER/CORAL): volume histogram below candles (non-flat with live indexer data).
Indicators → MA 7: cyan overlay appears immediately on toggle (no timeframe change required — original gap from 2026-05-12 is resolved).
MA 25: amber overlay; disable removes it.
RSI 14: third pane (0–100, 70/30 guides); disable returns candle + volume layout only.
Quick toggles: all on → all off → RSI only — no blank chart, no ghost panes.
Expand / Exit fullscreen control present (prior QA sign-off retained).
volume_quote: 0 / volume_base fallback — bars show relative height (local indexer).
cd frontend-dapp && npm run test:run && npm run build — 599 tests pass, build green.
Optional: RSI + volume pane heights remain reasonable after indicator toggles on /trade and /charts.

No additional code changes required; closing as verified.

## Verification complete (agent QA — 2026-05-27) Re-verified GitLab #150 on latest `main` (3f6a2e5) against the full local stack: **Services:** LocalTerra healthy · host Postgres :5432 · indexer http://127.0.0.1:3001 · frontend http://127.0.0.1:3000 · bot swarm active. ### Checklist - [x] `/trade` (EMBER/CORAL): volume histogram below candles (non-flat with live indexer data). - [x] **Indicators → MA 7**: cyan overlay appears **immediately** on toggle (no timeframe change required — original gap from 2026-05-12 is resolved). - [x] **MA 25**: amber overlay; disable removes it. - [x] **RSI 14**: third pane (0–100, 70/30 guides); disable returns candle + volume layout only. - [x] Quick toggles: all on → all off → RSI only — no blank chart, no ghost panes. - [x] **Expand / Exit** fullscreen control present (prior QA sign-off retained). - [x] `volume_quote: 0` / `volume_base` fallback — bars show relative height (local indexer). - [x] `cd frontend-dapp && npm run test:run && npm run build` — 599 tests pass, build green. - [x] Optional: RSI + volume pane heights remain reasonable after indicator toggles on `/trade` and `/charts`. No additional code changes required; closing as verified.

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-05-27 04:45:27 +00:00

PlasticDigits commented

2026-05-29 03:13:21 +00:00

(Migrated from gitlab.com)

mentioned in issue #211