fix(frontend): extra-debit TaxPreview send_msg leftover after #1267 #1294

Merged

PlasticDigits merged 2 commits from issue/1285 into main

2026-09-21 05:30:03 +00:00

PlasticDigits commented

2026-09-21 04:57:23 +00:00

Owner

Summary

S1285-1 / S1285-2: Swap/Trade build execute-aligned TaxPreview queries (communityTaxPreviewQuery.ts): pair-direct Swap send_msg; router hop uses router→pair with trader and taxPreviewExecuteDebitRaw (declared + hop_trader_debit).
S1285-4: Swap TxResultAlert and Trade market submit chrome humanize broadcast errors via humanizeUserFacingErrorFromUnknown (InsufficientForSellTax map).
S1285-3: Vitest hook/preview tests + Swap/Trade RTL cases with Honest LCD debit === declared at full balance (submit stays disabled). #1267 local floor remains as fail-closed backstop in extraDebitSubmitGate.

Acceptance criteria (#1285)

Criterion	Status
Pair-direct `send_msg` or documented equivalent	Met — wired `send_msg`; S1267-1 local floor unchanged
Router `hop_trader_debit` or explicit local floor	Met — `taxPreviewExecuteDebitRaw` + local floor
Vitest LCD shapes (not only `debitRaw: null`)	Met — hook + unit + RTL Honest-debit cases
Inline execute error humanized	Met — Swap + Trade market

Validation

make verify-issue-1285 (includes make verify-issue-1267 regression)
No related open PR existed; head issue/1285 created for reuse.

Gaps

Production/runtime logs not consulted (not an incident); VM lacked nvm until $HOME/.cursor-nvm provisioned for Vitest.
communityTaxPreviewQuery.test.ts still uses short mock terra1… addresses (resolver only checks prefix); hook tests use valid bech32.

Fixes #1285

## Summary - **S1285-1 / S1285-2:** Swap/Trade build execute-aligned `TaxPreview` queries (`communityTaxPreviewQuery.ts`): pair-direct `Swap` `send_msg`; router hop uses router→pair with `trader` and `taxPreviewExecuteDebitRaw` (`declared + hop_trader_debit`). - **S1285-4:** Swap `TxResultAlert` and Trade market submit chrome humanize broadcast errors via `humanizeUserFacingErrorFromUnknown` (`InsufficientForSellTax` map). - **S1285-3:** Vitest hook/preview tests + Swap/Trade RTL cases with Honest LCD `debit === declared` at full balance (submit stays disabled). `#1267` local floor remains as fail-closed backstop in `extraDebitSubmitGate`. ## Acceptance criteria (#1285) | Criterion | Status | |-----------|--------| | Pair-direct `send_msg` or documented equivalent | **Met** — wired `send_msg`; S1267-1 local floor unchanged | | Router `hop_trader_debit` or explicit local floor | **Met** — `taxPreviewExecuteDebitRaw` + local floor | | Vitest LCD shapes (not only `debitRaw: null`) | **Met** — hook + unit + RTL Honest-debit cases | | Inline execute error humanized | **Met** — Swap + Trade market | ## Validation - `make verify-issue-1285` (includes `make verify-issue-1267` regression) - No related open PR existed; head `issue/1285` created for reuse. ## Gaps - Production/runtime logs not consulted (not an incident); VM lacked nvm until `$HOME/.cursor-nvm` provisioned for Vitest. - `communityTaxPreviewQuery.test.ts` still uses short mock `terra1…` addresses (resolver only checks prefix); hook tests use valid bech32. Fixes #1285

Rows
Columns