fix(frontend): extra-debit TaxPreview send_msg leftover after #1267 #1285

New issue

Closed

opened 2026-09-21 04:03:07 +00:00 by PlasticDigits · 2 comments

PlasticDigits commented

2026-09-21 04:03:07 +00:00

Owner

Summary

#1267 / PR #1270 landed. Typed 100% extra-debit Sell is blocked via max(LCD debit, local sell_bps floor) so Honest TaxPreview cannot skip the gate.

Remaining

Pair-direct queryTaxPreview still omits Swap send_msg (LCD Honest debit === declared). Local floor covers AC1; execute-aligned preview does not.
Router hops should use hop_trader_debit (or keep the local floor explicitly) instead of treating Honest debit as sell debit.
Wire or delete unused classifyCommunityTaxQueryError.
Inline Swap/Trade TxResultAlert should use humanizeUserFacingErrorFromUnknown so InsufficientForSellTax is not raw wasm if broadcast still happens.

Do not skip sell tax, shrink pair credit, or extra-debit Provide / PlaceLimitOrder* (T592-7). Parent: #1267.

Acceptance criteria

Pair-direct preview includes Swap send_msg (or documented equivalent).
Router preview uses hop_trader_debit or an explicit local floor.
Vitest covers those LCD shapes, not only debitRaw: null.
Inline execute error uses the existing InsufficientForSellTax humanize map.

## Summary #1267 / PR #1270 landed. Typed 100% extra-debit Sell is blocked via `max(LCD debit, local sell_bps floor)` so Honest TaxPreview cannot skip the gate. ## Remaining - Pair-direct `queryTaxPreview` still omits Swap `send_msg` (LCD Honest `debit === declared`). Local floor covers AC1; execute-aligned preview does not. - Router hops should use `hop_trader_debit` (or keep the local floor explicitly) instead of treating Honest `debit` as sell debit. - Wire or delete unused `classifyCommunityTaxQueryError`. - Inline Swap/Trade `TxResultAlert` should use `humanizeUserFacingErrorFromUnknown` so `InsufficientForSellTax` is not raw wasm if broadcast still happens. Do not skip sell tax, shrink pair credit, or extra-debit Provide / `PlaceLimitOrder*` (T592-7). Parent: #1267. ## Acceptance criteria - [ ] Pair-direct preview includes Swap `send_msg` (or documented equivalent). - [ ] Router preview uses `hop_trader_debit` or an explicit local floor. - [ ] Vitest covers those LCD shapes, not only `debitRaw: null`. - [ ] Inline execute error uses the existing `InsufficientForSellTax` humanize map.

PlasticDigits referenced this issue

2026-09-21 04:03:16 +00:00

fix(frontend): extra-debit Sell submits when TaxPreview.debit exceeds balance #1267

PlasticDigits added the

ready

labels

2026-09-21 04:20:01 +00:00

PlasticDigits commented

2026-09-21 04:20:15 +00:00

Author

Owner

cl8y-agent-control: queued implement job 9226a69a-c135-40ed-9855-86ed4794dbc4 (not executed; no Hetzner VM).

cl8y-agent-control: queued `implement` job `9226a69a-c135-40ed-9855-86ed4794dbc4` (not executed; no Hetzner VM).

PlasticDigits removed the

ready

labels

2026-09-21 04:21:29 +00:00

PlasticDigits referenced this issue from a commit

2026-09-21 04:57:19 +00:00

fix(frontend): execute-aligned TaxPreview and humanize extra-debit tx errors

PlasticDigits referenced this issue from a pull request that will close it,

2026-09-21 04:57:23 +00:00

fix(frontend): extra-debit TaxPreview send_msg leftover after #1267 #1294

PlasticDigits closed this issue

2026-09-21 05:30:03 +00:00

PlasticDigits referenced this issue

2026-09-21 05:42:25 +00:00

Post-merge leftover after PRs 1287-1298 #1300

PlasticDigits commented

2026-09-21 05:44:13 +00:00

Author

Owner

Merged as PR #1294. Execute-aligned TaxPreview send_msg / hop_trader_debit plus humanized extra-debit tx errors. #1267 local floor kept.

Leftover ops: #1300

Merged as PR #1294. Execute-aligned TaxPreview send_msg / hop_trader_debit plus humanized extra-debit tx errors. #1267 local floor kept. Leftover ops: https://git.cl8y.com/code/cl8y-dex-terraclassic/issues/1300