code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

docs(dex): remaining GET /route/solve failures census (#1265) #1289

Merged
PlasticDigits merged 4 commits from docs/1265-route-solve-remaining-failures into main 2026-09-21 05:23:20 +00:00
Conversation 2 Commits 4 Files changed 18 +464 -16
PlasticDigits commented 2026-09-21 04:35:00 +00:00
Owner
Copy link

Summary

  • Research-only census for #1265: ADR 0007 inventories Swap/Trade quote paths and scores F0–F10.
  • Decision: Stay. No impl spawn. #1218 keeps F0 (native wrap-enter skip solve). #1257 (closed, in tree) keeps F1. #1264 / #1222 stay out for execute gas (F10).
  • Dated 2026-09-21 public GET summaries (contract ids + hops + amounts). Wallet sim vs estimated_amount_out is unmeasured.
  • Also: pre-push now checks only commits not already on origin when creating a new remote branch (zero OID no longer walks all ancestors).
  • Implement agent: make verify-issue-1289 aliases make verify-issue-1265 (9/9 incl. automated pre-push zero-OID gate).

Test plan

  • make verify-issue-1265 / make verify-issue-1289 (first pass + built-in retest; 9/9)
  • python3 scripts/check_route_solver_docs.py green
  • make test-commit-msg-hook
  • New-branch pre-push stdin sim (zero remote OID) — in verify script
  • Implement agent (worktree c1919008-18ec-4b42-bfbf-e5bb761a6718): AC1–AC6 satisfied in ADR 0007; no prod solver/quote diff vs main
  • Reviewer: re-fetch public GET rows or accept unmeasured (wallet sim still unmeasured by design)

AC checklist (#1265)

  • AC1 One ADR covering quote-path inventory + F0–F10
  • AC2 Dated probes or explicit unmeasured rows (do not recycle #1218 LUNC→USTR as unrelated CW20 proof)
  • AC3 F0–F10 scored; product decision Stay; F0/F1/F10 stay with filed tickets
  • AC4 #1203, #690, #1222, #1264 out of census
  • AC5 Docs-only solver/quote-path: no best_execution.rs / route_paths.rs / cw20RouteSolveQuote.ts / SwapPage.tsx quote-branch edits
  • AC6 No follow-up implement issue (Stay)

Invariants R-CENSUS-1–R-CENSUS-8. Verify: make verify-issue-1265 · make verify-issue-1289. Playbook: skills/AGENTS_INDEXER_HYBRID_BEST_EXECUTION.md.

Gaps / verification notes

  • Wallet simulateMultiHopSwap vs public estimated_amount_out: unmeasured (documented in ADR; not a merge blocker for Stay).
  • Live log review: not required (docs-only; no runtime change). No cl8y-logs-read probe run.
## Summary - Research-only census for [#1265](https://git.cl8y.com/code/cl8y-dex-terraclassic/issues/1265): ADR 0007 inventories Swap/Trade quote paths and scores F0–F10. - Decision: **Stay**. **No impl spawn.** #1218 keeps F0 (native wrap-enter skip solve). #1257 (closed, in tree) keeps F1. #1264 / #1222 stay out for execute gas (F10). - Dated 2026-09-21 public GET summaries (contract ids + hops + amounts). Wallet sim vs `estimated_amount_out` is **unmeasured**. - Also: pre-push now checks only commits not already on origin when creating a new remote branch (zero OID no longer walks all ancestors). - Implement agent: `make verify-issue-1289` aliases `make verify-issue-1265` (9/9 incl. automated pre-push zero-OID gate). ## Test plan - [x] `make verify-issue-1265` / `make verify-issue-1289` (first pass + built-in retest; 9/9) - [x] `python3 scripts/check_route_solver_docs.py` green - [x] `make test-commit-msg-hook` - [x] New-branch pre-push stdin sim (zero remote OID) — in verify script - [x] Implement agent (worktree `c1919008-18ec-4b42-bfbf-e5bb761a6718`): AC1–AC6 satisfied in ADR 0007; no prod solver/quote diff vs `main` - [ ] Reviewer: re-fetch public GET rows or accept **unmeasured** (wallet sim still unmeasured by design) ## AC checklist (#1265) - [x] **AC1** One ADR covering quote-path inventory + F0–F10 - [x] **AC2** Dated probes or explicit unmeasured rows (do not recycle #1218 LUNC→USTR as unrelated CW20 proof) - [x] **AC3** F0–F10 scored; product decision **Stay**; F0/F1/F10 stay with filed tickets - [x] **AC4** #1203, #690, #1222, #1264 out of census - [x] **AC5** Docs-only solver/quote-path: no `best_execution.rs` / `route_paths.rs` / `cw20RouteSolveQuote.ts` / `SwapPage.tsx` quote-branch edits - [x] **AC6** No follow-up implement issue (Stay) Invariants **R-CENSUS-1–R-CENSUS-8**. Verify: `make verify-issue-1265` · `make verify-issue-1289`. Playbook: `skills/AGENTS_INDEXER_HYBRID_BEST_EXECUTION.md`. ## Gaps / verification notes - Wallet `simulateMultiHopSwap` vs public `estimated_amount_out`: **unmeasured** (documented in ADR; not a merge blocker for Stay). - Live log review: not required (docs-only; no runtime change). No `cl8y-logs-read` probe run.
ADR 0007 scores F0-F10 Stay. No solver or quote-path changes.
fix(hooks): only check new commits on first push of a branch
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
12b3be9873 
pre-push treated a zero remote OID as git rev-list of that SHA, which walks all ancestors.
PlasticDigits commented 2026-09-21 04:35:05 +00:00
Author
Owner
Copy link

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue
PlasticDigits commented 2026-09-21 04:54:54 +00:00
Author
Owner
Copy link

cl8y-agent-control: queued implement job c1919008-18ec-4b42-bfbf-e5bb761a6718 (not executed; no Hetzner VM).

cl8y-agent-control: queued `implement` job `c1919008-18ec-4b42-bfbf-e5bb761a6718` (not executed; no Hetzner VM).
qa(dex): alias verify-issue-1289 and gate pre-push zero OID
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
a7ab1f14c1 
Wire the #1289 implement PR to the #1265 census verify script and
automate the new-branch pre-push stdin check in make verify-issue-1265.
Merge origin/main into docs/1265-route-solve-remaining-failures
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
c42ffc4776 
Keep 1234/1288 Makefile targets with 1265/1289 census verify aliases. Combine pre-push origin/main skip with new-branch unpublished-commit range.
PlasticDigits deleted branch docs/1265-route-solve-remaining-failures 2026-09-21 05:23:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1289
No description provided.