code/cl8y-dex-terraclassic

Fork 0

docs(indexer): ADR 0005 for multihop protocol fee hops #1275

Merged

PlasticDigits merged 2 commits from design/1274-protocol-fee-hops into main

2026-09-21 03:36:33 +00:00

PlasticDigits commented

2026-09-17 00:10:21 +00:00

Owner

Summary

Versioned design for persisting every factory AMM hop in protocol_fee_events (#1269 / implement PR #1274).
ADR 0005: pair-scoped uniqueness, wrap/window NULL partial, backfill, GET rollup-only, alternatives, rollout/rollback.
Architecture overview section points at the ADR; skill and verify-issue-1269 docs grep include the ADR.

This PR is design docs only. It does not migrate Coolify, deploy, or approve the proposal.

Test plan

grep / make verify-issue-1269 docs step includes ADR 0005 (full verify is Postgres + cargo; optional here)
Reviewer: uniqueness + NULL partial + no DO UPDATE match shipped ingest
Reviewer: #1209 / #1210 / #1211 stay downstream of the widened key

## Summary - Versioned design for persisting every factory AMM hop in `protocol_fee_events` ([#1269](https://git.cl8y.com/code/cl8y-dex-terraclassic/issues/1269) / implement [PR #1274](https://git.cl8y.com/code/cl8y-dex-terraclassic/pulls/1274)). - ADR 0005: pair-scoped uniqueness, wrap/window NULL partial, backfill, GET rollup-only, alternatives, rollout/rollback. - Architecture overview section points at the ADR; skill and `verify-issue-1269` docs grep include the ADR. This PR is **design docs only**. It does not migrate Coolify, deploy, or approve the proposal. ## Test plan - [ ] `grep` / `make verify-issue-1269` docs step includes ADR 0005 (full verify is Postgres + cargo; optional here) - [ ] Reviewer: uniqueness + NULL partial + no `DO UPDATE` match shipped ingest - [ ] Reviewer: #1209 / #1210 / #1211 stay downstream of the widened key

PlasticDigits added 1 commit

2026-09-17 00:10:21 +00:00

docs(indexer): ADR 0005 for multihop protocol fee hops

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

b5250cfcb5

Versioned uniqueness, backfill, and GET-rollup contract for #1269 / PR #1274.

PlasticDigits requested review from maintainers

2026-09-17 00:10:21 +00:00

PlasticDigits commented

2026-09-17 00:10:25 +00:00

Author

Owner

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

PlasticDigits referenced this pull request

2026-09-17 00:10:33 +00:00

fix(indexer): persist every multihop AMM hop in protocol_fee_events #1274

PlasticDigits added 1 commit

2026-09-17 00:16:33 +00:00

docs(indexer): complete ADR 0005 hop-fee review record

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

c9da734e3d

Post-hoc design: pair-scoped uniqueness, sqlx version leftover vs USDT pin, USD stamp lag, leftover rollout.

PlasticDigits commented

2026-09-17 00:16:36 +00:00

Author

Owner

Design record updated on this PR (docs only; does not re-merge ingest or deploy).

ADR 0005 is the versioned review artifact: pair-scoped swap_amm uniqueness, wrap/window NULL partial, ON CONFLICT DO NOTHING, backfill, GET rollup-only.
Architecture overview stays a pointer (#indexer-protocol-fee-ledger); skill owns F1269-1–F1269-8.
Named leftover (ordinary ops, not agent-control #297): sqlx files on main share prefix 20260916120000 (hops vs #1258 USDT). Rename the unapplied file before Coolify compile. Then hub backfill_null_fee_usd + aggregator tick before comparing 7d AMM USD.

No DESIGN: APPROVE on this comment.

Design record updated on this PR (docs only; does not re-merge ingest or deploy). - ADR 0005 is the versioned review artifact: pair-scoped `swap_amm` uniqueness, wrap/window NULL partial, `ON CONFLICT DO NOTHING`, backfill, GET rollup-only. - Architecture overview stays a pointer (`#indexer-protocol-fee-ledger`); skill owns F1269-1–F1269-8. - Named leftover (ordinary ops, not agent-control #297): sqlx files on `main` share prefix `20260916120000` (hops vs #1258 USDT). Rename the unapplied file before Coolify compile. Then hub `backfill_null_fee_usd` + aggregator tick before comparing 7d AMM USD. No DESIGN: APPROVE on this comment.

PlasticDigits removed review request for maintainers

2026-09-21 03:36:21 +00:00

PlasticDigits merged commit 16dfa30204 into main

2026-09-21 03:36:33 +00:00

PlasticDigits deleted branch design/1274-protocol-fee-hops

2026-09-21 03:36:33 +00:00

PlasticDigits referenced this pull request from a commit

2026-09-21 03:36:34 +00:00

Merge pull request 'docs(indexer): ADR 0005 for multihop protocol fee hops' (#1275) from design/1274-protocol-fee-hops

PlasticDigits referenced this pull request

2026-09-21 04:03:03 +00:00

fix(indexer): persist every multihop AMM hop in protocol_fee_events #1269