code/cl8y-dex-terraclassic

Fork 0

fix(indexer): persist every multihop AMM hop in protocol_fee_events #1274

Merged

PlasticDigits merged 3 commits from issue/1269 into main

2026-09-16 22:57:02 +00:00

PlasticDigits commented

2026-09-16 21:23:31 +00:00

Owner

Summary

Persist every factory AMM hop in protocol_fee_events with pair-scoped uniqueness (tx_hash, source, pair_id, ordinal) so per-pair swap_index 0 hops no longer collide.
Wrap / unwrap / UST1 / book / place keep NULL pair_id and a partial unique on (tx_hash, source, ordinal). Replay stays ON CONFLICT DO NOTHING (never overwrite).
One-shot SQL + poller-startup backfill from swap_events.commission_amount; trade_exists still skips swap insert but retries fee ingest.

Fixes #1269

Test plan

VERIFY_ISSUE_1269_SKIP_RELATED=1 make verify-issue-1269 (docs/source greps, lib protocol_fees, parser swap_index, indexer_protocol_fees hop/replay/wrap/backfill)
make verify-issue-586 (and 613/614/683) after Coolify/indexer deploy
After deploy + backfill + aggregator tick, /protocol 7d AMM matches hop-complete priced SUM, not the collision-truncated census
Poller replay does not inflate fee_event_count

## Summary - Persist every factory AMM hop in `protocol_fee_events` with pair-scoped uniqueness `(tx_hash, source, pair_id, ordinal)` so per-pair `swap_index` 0 hops no longer collide. - Wrap / unwrap / UST1 / book / place keep NULL `pair_id` and a partial unique on `(tx_hash, source, ordinal)`. Replay stays `ON CONFLICT DO NOTHING` (never overwrite). - One-shot SQL + poller-startup backfill from `swap_events.commission_amount`; `trade_exists` still skips swap insert but retries fee ingest. Fixes #1269 ## Test plan - [x] `VERIFY_ISSUE_1269_SKIP_RELATED=1 make verify-issue-1269` (docs/source greps, lib `protocol_fees`, parser `swap_index`, `indexer_protocol_fees` hop/replay/wrap/backfill) - [ ] `make verify-issue-586` (and 613/614/683) after Coolify/indexer deploy - [ ] After deploy + backfill + aggregator tick, `/protocol` 7d AMM matches hop-complete priced `SUM`, not the collision-truncated census - [ ] Poller replay does not inflate `fee_event_count`

PlasticDigits added 1 commit

2026-09-16 21:23:31 +00:00

fix(indexer): persist every multihop AMM hop in protocol_fee_events

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

8ea9c302b9

Pair-scope swap_amm uniqueness so per-pair swap_index 0 hops coexist.
Backfill missing commissions from swap_events; replay stays idempotent.

PlasticDigits requested review from maintainers

2026-09-16 21:23:32 +00:00

PlasticDigits commented

2026-09-16 21:23:33 +00:00

Author

Owner

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

PlasticDigits commented

2026-09-16 22:29:41 +00:00

Author

Owner

/agent review

PlasticDigits commented

2026-09-16 22:29:47 +00:00

Author

Owner

cl8y-agent-control: queued bug_review job 2ef6078c-0758-4dbe-a41d-a473acf8f7e1 (not executed; no Hetzner VM).

cl8y-agent-control: queued `bug_review` job `2ef6078c-0758-4dbe-a41d-a473acf8f7e1` (not executed; no Hetzner VM).

PlasticDigits removed review request for maintainers

2026-09-16 22:53:01 +00:00

PlasticDigits added 1 commit

2026-09-16 22:53:23 +00:00

Merge branch 'main' into issue/1269

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

0ddffa5afd

PlasticDigits added 1 commit

2026-09-16 22:55:21 +00:00

Merge branch 'main' into issue/1269 192097f662

PlasticDigits added 1 commit

2026-09-16 22:55:57 +00:00

Merge branch 'main' into issue/1269

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

3b080cfd3b

PlasticDigits merged commit 7ec1fa3de1 into main

2026-09-16 22:57:02 +00:00

PlasticDigits added the

agent:implement

labels

2026-09-16 23:11:43 +00:00

PlasticDigits referenced this pull request from a commit

2026-09-17 00:10:12 +00:00

docs(indexer): ADR 0005 for multihop protocol fee hops

PlasticDigits referenced this pull request

2026-09-17 00:10:21 +00:00

docs(indexer): ADR 0005 for multihop protocol fee hops #1275

PlasticDigits commented

2026-09-17 00:10:33 +00:00

Author

Owner

Design for this slice is in-repo (docs only; no Coolify migrate/deploy from this comment).

Outcome: every factory AMM hop with commission_amount > 0 is one swap_amm row. Unique (tx_hash, source, pair_id, ordinal) WHERE pair_id IS NOT NULL; wrap/window/book/place stay NULL pair_id with the non-pair partial. Replay ON CONFLICT DO NOTHING. Backfill from swap_events. GET stays rollup-only.

Not #297 deploy/spend/custody. Not a founder card.

DESIGN: READY_FOR_REVIEW

Design for this slice is in-repo (docs only; no Coolify migrate/deploy from this comment). - ADR: https://git.cl8y.com/code/cl8y-dex-terraclassic/src/branch/design/1274-protocol-fee-hops/docs/adr/0005-protocol-fee-multihop-hops.md - Overview: https://git.cl8y.com/code/cl8y-dex-terraclassic/src/branch/design/1274-protocol-fee-hops/docs/architecture.md#indexer-protocol-fee-ledger - Design PR: https://git.cl8y.com/code/cl8y-dex-terraclassic/pulls/1275 Outcome: every factory AMM hop with `commission_amount > 0` is one `swap_amm` row. Unique `(tx_hash, source, pair_id, ordinal)` WHERE `pair_id IS NOT NULL`; wrap/window/book/place stay NULL `pair_id` with the non-pair partial. Replay `ON CONFLICT DO NOTHING`. Backfill from `swap_events`. GET stays rollup-only. Not #297 deploy/spend/custody. Not a founder card. DESIGN: READY_FOR_REVIEW

PlasticDigits removed the

agent:implement

label

2026-09-17 00:10:46 +00:00

PlasticDigits referenced this pull request

2026-09-21 04:03:03 +00:00

fix(indexer): persist every multihop AMM hop in protocol_fee_events #1269