code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

fix(community-tax): SendFrom listed-pair Sell extra-debits beyond allowance #1233

Merged
PlasticDigits merged 2 commits from issue/1228 into main 2026-09-12 02:42:02 +00:00
Conversation 1 Commits 2 Files changed 14 +676 -20
PlasticDigits commented 2026-09-11 08:03:07 +00:00
Owner
Copy link

Summary

  • execute_send_from classifies via tax::preview before deduct_allowance, then deducts TaxPreview.debit (pair-direct listed-pair Sell = amount + tax, T592-2 / A-allow).
  • Allowance equal to declared amount (or debit - 1) reverts before balances move. TransferFrom still deducts amount only (T592-7). Pair/router/factory wasm unchanged (H-01).
  • Multitest + make verify-issue-1228. Live 11611 / 11619 still need a later store+migrate (ops, not this PR).

Fixes #1228

Acceptance

  • AC1. Listed-pair SendFrom+Swap with allowance == declared amount reverts; no owner debit, no pair credit, no sink credit, allowance unchanged.
  • AC2. Same call with allowance == TaxPreview.debit succeeds; owner −debit, pair +amount, sinks +tax, remaining allowance 0.
  • AC3. SendFrom cannot skip sell tax (same extra-debit as owner Send for pair-direct).
  • AC4. TransferFrom to the listed pair (no Swap hook) remains 1:1; allowance decreases by amount only.
  • AC5. Unregistered pair / Honest path: SendFrom debit = amount; allowance = amount.
  • AC6. Pair-direct spoofed trader does not move the victim; owner is extra-debited (T592-13).
  • AC7. Manager-directory / manager-role skip: no extra-debit; allowance = amount.
  • AC8. Docs/skills: T592-2 states SendFrom allowance covers economic debit. No pair/router math change.
  • AC9. Existing sell_extra_debit_on_swap_send / greedy extra-debit tests stay green.

Test plan

  • cargo test -p cl8y-community-tax-token (crate suite)
  • make verify-issue-1228 (first pass + retest)
  • Reviewer: confirm execute_send_from deducts preview.debit and execute_transfer_from still deducts amount
  • Reviewer: pair/router/factory paths have empty diff
  • Ops follow-up (not this PR): store + migrate listed 11611 / 11619
## Summary - `execute_send_from` classifies via `tax::preview` **before** `deduct_allowance`, then deducts `TaxPreview.debit` (pair-direct listed-pair Sell = `amount + tax`, **T592-2** / **A-allow**). - Allowance equal to declared `amount` (or `debit - 1`) **reverts** before balances move. `TransferFrom` still deducts `amount` only (**T592-7**). Pair/router/factory wasm unchanged (**H-01**). - Multitest + `make verify-issue-1228`. Live **11611** / **11619** still need a later store+migrate (ops, not this PR). Fixes #1228 ## Acceptance - [x] AC1. Listed-pair `SendFrom+Swap` with allowance == declared `amount` reverts; no owner debit, no pair credit, no sink credit, allowance unchanged. - [x] AC2. Same call with allowance == `TaxPreview.debit` succeeds; owner −debit, pair +`amount`, sinks +tax, remaining allowance 0. - [x] AC3. `SendFrom` cannot skip sell tax (same extra-debit as owner `Send` for pair-direct). - [x] AC4. `TransferFrom` to the listed pair (no Swap hook) remains 1:1; allowance decreases by `amount` only. - [x] AC5. Unregistered pair / Honest path: `SendFrom` debit = `amount`; allowance = `amount`. - [x] AC6. Pair-direct spoofed `trader` does not move the victim; owner is extra-debited (**T592-13**). - [x] AC7. Manager-directory / manager-role skip: no extra-debit; allowance = `amount`. - [x] AC8. Docs/skills: **T592-2** states SendFrom allowance covers economic debit. No pair/router math change. - [x] AC9. Existing `sell_extra_debit_on_swap_send` / greedy extra-debit tests stay green. ## Test plan - [x] `cargo test -p cl8y-community-tax-token` (crate suite) - [x] `make verify-issue-1228` (first pass + retest) - [ ] Reviewer: confirm `execute_send_from` deducts `preview.debit` and `execute_transfer_from` still deducts `amount` - [ ] Reviewer: pair/router/factory paths have empty diff - [ ] Ops follow-up (not this PR): store + migrate listed **11611** / **11619** 
Pair-direct listed-pair SendFrom extra-debits amount+tax (T592-2) but
used to consume only declared amount from allowance. Classify first and
deduct the economic debit so insufficient allowance fail-closes.
Pre-commit clippy on rustc 1.88 flags historical uninlined_format_args
in pair/dex-common; allow that style lint rather than touching pair wasm.
PlasticDigits commented 2026-09-11 22:09:53 +00:00
Author
Owner
Copy link

drain skip: hard-blocked (needs-human / high-risk / human topic); remaining continue

drain skip: hard-blocked (needs-human / high-risk / human topic); remaining continue
Merge origin/main into issue/1228 for PR #1233
All checks were successful
ci/woodpecker/pr/woodpecker gitleaks tracked-tree scan passed locally
Details
61756c2112
PlasticDigits deleted branch issue/1228 2026-09-12 02:42:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1233
No description provided.