docs: complete #195 merge-gate docs after catch-all CODEOWNERS delete #197

Merged
PlasticDigits merged 1 commit from issue/195 into main 2026-09-21 20:54:46 +00:00

Summary

PR #195 merged with only the root CODEOWNERS deletion. This follow-up on issue/195 lands the remaining implement acceptance criteria from ADR 0001 (accepted design SHA 078d42407d9960e86982bdedcb20ff7bd49377f2).

Completed criteria

  • D1/D2: Root catch-all already absent on main; four Forgejo CODEOWNERS paths remain absent on this tip (object ls-tree check).
  • D3: docs/qa-onboarding.md — Branch Protection table, post-PR workflow, Reviews row, and fj pr view comment updated; ban-list strings removed; required Woodpecker / practice phrases present.
  • ADR + pointers: Added docs/adr/0001-remove-catchall-codeowners.md with Status Accepted line carve-out only vs accepted tree; docs/architecture.md and docs/README.md byte-identical to accepted SHA.
  • Vendor: OpenZeppelin and forge-std .github/CODEOWNERS unchanged.
  • Leftover tracker: Opened issue #196 for post-merge plant-check (D4); no close-keyword targeting #196 on this PR or commits.

Validation run (local)

ACCEPTED=078d42407d9960e86982bdedcb20ff7bd49377f2
# architecture.md + README.md byte-identical to $ACCEPTED
# ADR diff vs $ACCEPTED: Status Proposed → Accepted only
# qa-onboarding ban-list absent; D3 replacement phrases present
# git diff --name-only origin/main HEAD == four docs paths only
# four-path CODEOWNERS absence on HEAD; vendor CODEOWNERS present; .woodpecker.yaml unchanged

Gaps / follow-up

  • Plant-check PR {n} and leftover-complete GET pairs belong on tracker #196 after this PR merges (not in scope of this diff).
  • #194 (renovate.json) may still land separately; this tip is docs-only vs current main.
  • Pre-merge #195 land-ready checklist (descendant-of-fc1b20f, five-path including CODEOWNERS delete) applied to the historical product branch; post-merge completion is tree contents on main per ADR Integration section.

Test plan

  • Woodpecker ci/woodpecker/pr/woodpecker green on this PR
  • Maintainer merge (no force_merge)
## Summary PR #195 merged with only the root `CODEOWNERS` deletion. This follow-up on `issue/195` lands the remaining implement acceptance criteria from [ADR 0001](docs/adr/0001-remove-catchall-codeowners.md) (accepted design SHA `078d42407d9960e86982bdedcb20ff7bd49377f2`). ## Completed criteria - **D1/D2**: Root catch-all already absent on `main`; four Forgejo CODEOWNERS paths remain absent on this tip (object `ls-tree` check). - **D3**: `docs/qa-onboarding.md` — Branch Protection table, post-PR workflow, Reviews row, and `fj pr view` comment updated; ban-list strings removed; required Woodpecker / practice phrases present. - **ADR + pointers**: Added `docs/adr/0001-remove-catchall-codeowners.md` with Status **Accepted** line carve-out only vs accepted tree; `docs/architecture.md` and `docs/README.md` byte-identical to accepted SHA. - **Vendor**: OpenZeppelin and forge-std `.github/CODEOWNERS` unchanged. - **Leftover tracker**: Opened issue #196 for post-merge plant-check (D4); no close-keyword targeting #196 on this PR or commits. ## Validation run (local) ```bash ACCEPTED=078d42407d9960e86982bdedcb20ff7bd49377f2 # architecture.md + README.md byte-identical to $ACCEPTED # ADR diff vs $ACCEPTED: Status Proposed → Accepted only # qa-onboarding ban-list absent; D3 replacement phrases present # git diff --name-only origin/main HEAD == four docs paths only # four-path CODEOWNERS absence on HEAD; vendor CODEOWNERS present; .woodpecker.yaml unchanged ``` ## Gaps / follow-up - **Plant-check PR `{n}`** and leftover-complete GET pairs belong on tracker **#196** after this PR merges (not in scope of this diff). - **#194** (`renovate.json`) may still land separately; this tip is docs-only vs current `main`. - Pre-merge #195 land-ready checklist (descendant-of-`fc1b20f`, five-path including `CODEOWNERS` delete) applied to the historical product branch; post-merge completion is tree contents on `main` per ADR Integration section. ## Test plan - [ ] Woodpecker `ci/woodpecker/pr/woodpecker` green on this PR - [ ] Maintainer merge (no `force_merge`)
docs: land catch-all CODEOWNERS delete and merge-gate copy
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ci/woodpecker/push/woodpecker Pipeline was successful
c5603305e6
Land ADR 0001, architecture pointer, README index, and qa-onboarding D3
after the incomplete #195 merge (CODEOWNERS already removed on main).

Co-authored-by: Cursor <cursoragent@cursor.com>
Author
Owner

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue
Author
Owner

drain skip: default autoland requires tip ACCEPT (#77)

drain skip: default autoland requires tip ACCEPT (#77)
Sign in to join this conversation.
No description provided.