Bug: make solana-test-e2e fails — Bad substitution in lib-local-deploy-env.sh #77

Closed
opened 2026-03-26 03:40:24 +00:00 by Brouie · 4 comments
Brouie commented 2026-03-26 03:40:24 +00:00 (Migrated from gitlab.com)

make solana-test-e2e fails with '/bin/sh: 5: ./scripts/lib-local-deploy-env.sh: Bad substitution'. Tests restructured — on-chain flows now in deposit_withdraw.test.ts (anchor test), Rust E2E file only has offline checks. make solana-test-e2e runs 0 ignored tests. May need Makefile update to match new test structure.

make solana-test-e2e fails with '/bin/sh: 5: ./scripts/lib-local-deploy-env.sh: Bad substitution'. Tests restructured — on-chain flows now in deposit_withdraw.test.ts (anchor test), Rust E2E file only has offline checks. make solana-test-e2e runs 0 ignored tests. May need Makefile update to match new test structure.
Brouie commented 2026-03-26 03:40:53 +00:00 (Migrated from gitlab.com)

mentioned in issue #67

mentioned in issue #67
PlasticDigits commented 2026-03-26 13:09:21 +00:00 (Migrated from gitlab.com)

mentioned in commit ecd73f6a26

mentioned in commit ecd73f6a267f9332022d8063d93205bbdecaa919
PlasticDigits commented 2026-03-26 13:09:26 +00:00 (Migrated from gitlab.com)

Fixed (pushed to feat/solana-integration)

Cause: Make runs recipes with /bin/sh. Sourcing scripts/lib-local-deploy-env.sh used bash-only syntax (${BASH_SOURCE[0]}, [[ ... ]]), which triggers Bad substitution under dash/sh.

Changes:

  • Run the solana-test-e2e recipe via bash -c '...' (same pattern as deploy-solana).
  • Drop --ignored from cargo test — test_solana_flows.rs is now offline-only with no #[ignore] tests; on-chain flows live in Anchor tests per issue description.

Verified locally: make solana-test-e2e passes (3 tests).

Commit: ecd73f6

@brouie please verify when you have a moment.

## Fixed (pushed to `feat/solana-integration`) **Cause:** Make runs recipes with `/bin/sh`. Sourcing `scripts/lib-local-deploy-env.sh` used bash-only syntax (`${BASH_SOURCE[0]}`, `[[ ... ]]`), which triggers `Bad substitution` under dash/sh. **Changes:** - Run the `solana-test-e2e` recipe via `bash -c '...'` (same pattern as `deploy-solana`). - Drop `--ignored` from `cargo test` — `test_solana_flows.rs` is now offline-only with no `#[ignore]` tests; on-chain flows live in Anchor tests per issue description. Verified locally: `make solana-test-e2e` passes (3 tests). Commit: `ecd73f6` @brouie please verify when you have a moment.
Brouie commented 2026-03-27 01:08:34 +00:00 (Migrated from gitlab.com)

Verified. make solana-test-e2e runs cleanly — Bad substitution fixed (bash -c). 3/3 offline tests pass. On-chain flows moved to anchor test suite (179/179 via make solana-test). Closing.

Verified. make solana-test-e2e runs cleanly — Bad substitution fixed (bash -c). 3/3 offline tests pass. On-chain flows moved to anchor test suite (179/179 via make solana-test). Closing.
Brouie (Migrated from gitlab.com) closed this issue 2026-03-27 01:08:35 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-bridge-monorepo#77
No description provided.