chore: leftover CODEOWNERS S3 (protection GET + plant-check) #3

New issue

Open

opened 2026-09-21 20:34:40 +00:00 by PlasticDigits · 0 comments

PlasticDigits commented

2026-09-21 20:34:40 +00:00

Owner

Leftover-complete for ADR 0001 after merge of product PR #2. This issue
does not close #2. Opened in code/cl8y-aidevclusterfund before that merge.

Dated operator GET of this repo's main protection rule equals the six
F2 protection flags (F2-2, F2-8, F2-3, F2-9, F2-10, F2-5) in
docs/architecture.md. Attest the JSON here. Not copied from code/hello.
A GET recorded before a later template re-copy does not count.
After the delete is on main: dedicated plant-check PR {n} (not draft,
title not WIP, at least one changed file, no manual reviewer request).
Split matchers by endpoint:
- Pulls GET .../pulls/{n}: the pulls arm fails on any non-empty
  requested_reviewers_teams. name == "maintainers" plus org code on
  that team object (organization.username == "code" or
  organization.name == "code") only names a CODEOWNERS plant. It is
  not a second pass path. Do not match code/maintainers or
  @code/maintainers.
- Reviews GET .../pulls/{n}/reviews: a plant is official == true AND
  state == "REQUEST_REVIEW" AND team.name == "maintainers". Do not
  dereference team.organization (it is null). Do not treat official
  alone as a plant.
  Record {n}, then close without merge. Not #2, not #1, not the next
  natural PR.

Leftover-complete for ADR 0001 after merge of product PR #2. This issue does not close #2. Opened in code/cl8y-aidevclusterfund before that merge. 1. Dated operator GET of this repo's `main` protection rule equals the six F2 protection flags (F2-2, F2-8, F2-3, F2-9, F2-10, F2-5) in docs/architecture.md. Attest the JSON here. Not copied from code/hello. A GET recorded before a later template re-copy does not count. 2. After the delete is on `main`: dedicated plant-check PR {n} (not draft, title not WIP, at least one changed file, no manual reviewer request). Split matchers by endpoint: - Pulls GET .../pulls/{n}: the pulls arm fails on any non-empty requested_reviewers_teams. name == "maintainers" plus org code on that team object (organization.username == "code" or organization.name == "code") only names a CODEOWNERS plant. It is not a second pass path. Do not match code/maintainers or @code/maintainers. - Reviews GET .../pulls/{n}/reviews: a plant is official == true AND state == "REQUEST_REVIEW" AND team.name == "maintainers". Do not dereference team.organization (it is null). Do not treat official alone as a plant. Record {n}, then close without merge. Not #2, not #1, not the next natural PR.

PlasticDigits referenced this issue from a commit

2026-09-21 20:34:53 +00:00

docs: land ADR 0001 standing contract and README F2 pointer

PlasticDigits referenced this issue

2026-09-21 20:35:00 +00:00

chore: complete ADR 0001 land (docs + README F2) #4