chore: complete #14 CODEOWNERS docs and tests #15

Open

PlasticDigits wants to merge 4 commits from issue/14 into main

PlasticDigits commented

2026-09-21 20:08:50 +00:00

Owner

Summary

Completes branch implement (ADR 0001 slices 1–2) for #14 on head issue/14:

Lands design docs (docs/adr/0001, docs/architecture.md, docs/README.md, AGENTS.md pointer) rebased onto main (root CODEOWNERS already removed by merged PR #14).
Adds src/content/codeowners.test.ts (four Forgejo paths + tracked basename) and wires it into package.json scripts.test.
Updates skills/cl8y-site-positioning with CO14 pointer.

Fixes #14 for slices 1–2 only. CO14-7 gap: ci/woodpecker/pr/woodpecker has not posted on this tip; no .woodpecker.yaml in this diff (CO14-5).

Acceptance criteria

Criterion	Status
CO14-1 four paths absent + no tracked `CODEOWNERS`	Done (on `main` + tests)
CO14-2 no catch-all `.*` owner	Done (tests)
ADR + architecture + README + AGENTS	Done
`package.json` test argv	Done
No visitor copy / token / `render.yaml` / Woodpecker	Done
CO14-7 Woodpecker green on tip	Not done (named CI issue TBD)

Test plan

node --experimental-strip-types --test (invariants + codeowners + tokenDirectory + copyText) — 28 passed locally
yarn typecheck / yarn lint / yarn build — not run here (no node_modules in gate worktree); Woodpecker CI required for merge

## Summary Completes **branch implement** (ADR 0001 slices 1–2) for [#14](https://git.cl8y.com/code/CL8Y-web/issues/14) on head `issue/14`: - Lands design docs (`docs/adr/0001`, `docs/architecture.md`, `docs/README.md`, `AGENTS.md` pointer) rebased onto `main` (root `CODEOWNERS` already removed by merged PR #14). - Adds `src/content/codeowners.test.ts` (four Forgejo paths + tracked basename) and wires it into `package.json` `scripts.test`. - Updates `skills/cl8y-site-positioning` with CO14 pointer. Fixes #14 for slices 1–2 only. **CO14-7 gap:** `ci/woodpecker/pr/woodpecker` has not posted on this tip; no `.woodpecker.yaml` in this diff (CO14-5). ## Acceptance criteria | Criterion | Status | |-----------|--------| | CO14-1 four paths absent + no tracked `CODEOWNERS` | Done (on `main` + tests) | | CO14-2 no catch-all `.*` owner | Done (tests) | | ADR + architecture + README + AGENTS | Done | | `package.json` test argv | Done | | No visitor copy / token / `render.yaml` / Woodpecker | Done | | CO14-7 Woodpecker green on tip | **Not done** (named CI issue TBD) | ## Test plan - [x] `node --experimental-strip-types --test` (invariants + codeowners + tokenDirectory + copyText) — 28 passed locally - [ ] `yarn typecheck` / `yarn lint` / `yarn build` — not run here (no `node_modules` in gate worktree); Woodpecker CI required for merge

PlasticDigits added 4 commits

2026-09-21 20:08:50 +00:00

docs(adr): propose removing catch-all CODEOWNERS (#14 ) ed47d1fa1b

Stop planted official review requests; keep host merge gate (no direct main, Woodpecker, no force_merge).

Co-authored-by: Cursor <cursoragent@cursor.com>

docs(adr): pin #14 to forgejo#48 plant-vs-block keep-set 7929d0418b

Host already rolled official-review block off; this repo only deletes the catch-all file. Do not wait on hello#15.

Co-authored-by: Cursor <cursoragent@cursor.com>

docs(adr): wait on Woodpecker to merge #14 c384737630

File-delete may finish on the product-PR branch; #14 stays open until the required context posts. Name all four CODEOWNERS paths and pin the dated keep-set.

Co-authored-by: Cursor <cursoragent@cursor.com>

test(docs): complete #14 slices 1–2 on issue/14 2ee861a960

Wire CODEOWNERS absence tests into yarn test, land ADR/architecture from
design, and document CO14 in agent skills. Woodpecker (CO14-7) remains open.

Co-authored-by: Cursor <cursoragent@cursor.com>

PlasticDigits commented

2026-09-21 20:08:52 +00:00

Author

Owner

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

PlasticDigits commented

2026-09-21 20:08:55 +00:00

Author

Owner

Implement report (gate-impl)

Slices 1–2: complete on issue/14 @ 2ee861a.

Validation: codeowners.test.ts covers all four Forgejo paths + git ls-files basename check; full unit suite 28/28 via Node test runner locally.

Gaps (unchanged contract):

CO14-7: ci/woodpecker/pr/woodpecker not observed on this tip (no pipeline in repo).
Slice 4: dedicated plant-check + dismiss stale official reviews — operator leftover.
Prior merged PR #14 closed the issue with delete-only; this PR carries the ADR/tests argv the design required.

Do not merge until Woodpecker posts (host protection unchanged).

## Implement report (gate-impl) **Slices 1–2:** complete on `issue/14` @ `2ee861a`. **Validation:** `codeowners.test.ts` covers all four Forgejo paths + `git ls-files` basename check; full unit suite 28/28 via Node test runner locally. **Gaps (unchanged contract):** - **CO14-7:** `ci/woodpecker/pr/woodpecker` not observed on this tip (no pipeline in repo). - **Slice 4:** dedicated plant-check + dismiss stale official reviews — operator leftover. - Prior merged PR #14 closed the issue with delete-only; this PR carries the ADR/tests argv the design required. Do not merge until Woodpecker posts (host protection unchanged).

Some required checks are missing.

You are not authorized to merge this pull request.

View command line instructions