chore: complete ADR 0001 merge-plane (CODEOWNERS) #4

Open

PlasticDigits wants to merge 6 commits from issue/3 into main

PlasticDigits commented

2026-09-21 20:02:34 +00:00

Owner

Summary

Completes issue #3 / ADR 0001 after occupying PR #3 landed the root CODEOWNERS delete on main.

Cherry-pick accepted design (7956d2b^..1b1ab88) onto current main (no file at any of the four Forgejo lookup paths).
.gitignore carve-out so docs/adr/ and docs/architecture.md are tracked; docs/CODEOWNERS stays untracked/ignored.
Woodpecker slice 3: no-catchall-codeowners (alpine:3.20, test ! -f on root, docs/, .gitea/, .forgejo/).
docs/architecture.md merge-plane table; ADR 0001 status Accepted.

Fixes #3

Acceptance criteria

Criterion	Status
No `CODEOWNERS` at four Forgejo paths on tip	Done (delete was on `main`; CI asserts)
Woodpecker `no-catchall-codeowners` + unchanged `tree`	Done
`architecture.md` / ADR 0001 decision record	Done
No contract/deploy/CAC/protection PATCH edits	Done (docs + CI only)
No `force_merge: true` advice in product docs	Done (ADR mentions forbidden API only)

Validation

Local: test ! -f on four paths; tree find non-empty; docs/* tracked via git ls-files.
forge test: not run (Foundry not installed on worker); not merge-plane oracle per ADR.
Woodpecker ci/woodpecker/pr/woodpecker: pending on this PR tip.

Gaps

Post-land “no new plant” oracle requires a non-WIP PR opened after merge (not this PR while leftover may exist on closed #3).
Protection GET flags not re-verified (anonymous 401 per ADR).
Leftover official review on merged #3 not dismissed (by design).

## Summary Completes [issue #3](https://git.cl8y.com/code/CL8Y-Token-SC/issues/3) / ADR 0001 after occupying PR #3 landed the root `CODEOWNERS` delete on `main`. - Cherry-pick accepted design (`7956d2b^..1b1ab88`) onto current `main` (no file at any of the four Forgejo lookup paths). - `.gitignore` carve-out so `docs/adr/` and `docs/architecture.md` are tracked; `docs/CODEOWNERS` stays untracked/ignored. - Woodpecker slice 3: `no-catchall-codeowners` (`alpine:3.20`, `test ! -f` on root, `docs/`, `.gitea/`, `.forgejo/`). - `docs/architecture.md` merge-plane table; ADR 0001 status **Accepted**. Fixes #3 ## Acceptance criteria | Criterion | Status | | --- | --- | | No `CODEOWNERS` at four Forgejo paths on tip | Done (delete was on `main`; CI asserts) | | Woodpecker `no-catchall-codeowners` + unchanged `tree` | Done | | `architecture.md` / ADR 0001 decision record | Done | | No contract/deploy/CAC/protection PATCH edits | Done (docs + CI only) | | No `force_merge: true` advice in product docs | Done (ADR mentions forbidden API only) | ## Validation - Local: `test ! -f` on four paths; `tree` find non-empty; `docs/*` tracked via `git ls-files`. - `forge test`: not run (Foundry not installed on worker); not merge-plane oracle per ADR. - Woodpecker `ci/woodpecker/pr/woodpecker`: pending on this PR tip. ## Gaps - Post-land “no new plant” oracle requires a **non-WIP** PR opened after merge (not this PR while leftover may exist on closed #3). - Protection GET flags not re-verified (anonymous 401 per ADR). - Leftover official review on merged #3 not dismissed (by design).

PlasticDigits added 6 commits

2026-09-21 20:02:34 +00:00

docs: ADR 0001 remove catch-all CODEOWNERS b2c4faf392

Record the merge-plane decision so official review is not planted on every change, without treating CODEOWNERS as a land gate.

Co-authored-by: Cursor <cursoragent@cursor.com>

docs: pin Alpine CODEOWNERS CI and non-mergeable design transport f8fe29a39a

Independent review could not implement slice 3 as written: Tests named a
missing scripts/ helper and an rg oracle that fails this ADR, and the
merge table still allowed a CODEOWNERS file Outcome 1 forbids.

Co-authored-by: Cursor <cursoragent@cursor.com>

docs: close Forgejo CODEOWNERS four-path load order 5b6ee4bb2c

After the root file is gone, .gitea/CODEOWNERS still plants official review; CI and leftover glance must match the first-existing four-path loader, and a draft is not proof.

Co-authored-by: Cursor <cursoragent@cursor.com>

docs: pin occupying cherry-pick to include Alpine revision 10b67fca9b

Implement must apply 7956d2b, 7e66bf0, then the four-path load-order
revision; skipping 7e66bf0 would drop the Alpine pin and restore a
three-path no-file contract.

Co-authored-by: Cursor <cursoragent@cursor.com>

docs: pin occupying cherry-pick to include four-path SHA e5a31b3c2d

Implement must apply 7956d2b, 7e66bf0, d01f4c1, then b639bd1; skipping
d01f4c1 restores three-path CI and reopens the .gitea/CODEOWNERS plant.

Co-authored-by: Cursor <cursoragent@cursor.com>

ci: add no-catchall-codeowners Woodpecker step (ADR 0001 slice 3)

ci/woodpecker/push/woodpecker Pipeline was successful

Details

ci/woodpecker/pr/woodpecker Pipeline was successful

Details

426f9ec1a8

Cherry-picked accepted design onto main after occupying #3 delete landed.
Alpine test ! -f on all four Forgejo CODEOWNERS lookup paths.

Co-authored-by: Cursor <cursoragent@cursor.com>

PlasticDigits commented

2026-09-21 20:02:41 +00:00

Author

Owner