code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

DevEx: indexer clippy clean with -D warnings (split from #2) #8

New issue
Closed
opened 2026-03-28 09:50:16 +00:00 by PlasticDigits · 7 comments
PlasticDigits commented 2026-03-28 09:50:16 +00:00 (Migrated from gitlab.com)

Split from #2. cargo clippy -- -D warnings currently fails on pre-existing lints in indexer/src/persist.rs and indexer/src/reorg.rs (e.g. redundant closures, useless conversion).

Scope

  • Fix or allow with narrow attributes + rationale; align with CI if we add a clippy gate.

Exit

  • cd indexer && cargo clippy --all-targets -- -D warnings passes.

Related: #2

Split from #2. `cargo clippy -- -D warnings` currently fails on pre-existing lints in `indexer/src/persist.rs` and `indexer/src/reorg.rs` (e.g. redundant closures, useless conversion). **Scope** - Fix or allow with narrow attributes + rationale; align with CI if we add a clippy gate. **Exit** - `cd indexer && cargo clippy --all-targets -- -D warnings` passes. Related: #2
PlasticDigits commented 2026-03-28 09:50:24 +00:00 (Migrated from gitlab.com)

mentioned in issue #2

mentioned in issue #2
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-03-31 03:22:14 +00:00
PlasticDigits commented 2026-03-31 03:28:47 +00:00 (Migrated from gitlab.com)

mentioned in commit aaa52c9eee

mentioned in commit aaa52c9eeeae9639a8a60d5871182c56413f7bf3
PlasticDigits (Migrated from gitlab.com) reopened this issue 2026-03-31 03:29:13 +00:00
PlasticDigits commented 2026-03-31 03:29:17 +00:00 (Migrated from gitlab.com)

@brouie Please verify this fix when you have a moment.

What to check

  • From repo root: cd indexer && cargo clippy --all-targets -- -D warnings (should pass).
  • CI: the unit-tests workflow now runs the same clippy command before cargo test on the indexer job.

Leaving this issue open until verification is done.

@brouie Please verify this fix when you have a moment. **What to check** - From repo root: `cd indexer && cargo clippy --all-targets -- -D warnings` (should pass). - CI: the `unit-tests` workflow now runs the same clippy command before `cargo test` on the indexer job. Leaving this issue **open** until verification is done.
Brouie commented 2026-04-01 03:45:34 +00:00 (Migrated from gitlab.com)

verified -- cargo clippy --all-targets -- -D warnings passes clean on latest main (d9987ca). no warnings.

verified -- cargo clippy --all-targets -- -D warnings passes clean on latest main (d9987ca). no warnings.
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-04-02 04:22:23 +00:00
PlasticDigits commented 2026-04-24 08:18:43 +00:00 (Migrated from gitlab.com)

mentioned in issue #62

mentioned in issue #62
PlasticDigits commented 2026-06-25 20:07:22 +00:00 (Migrated from gitlab.com)

mentioned in issue #348

mentioned in issue #348
PlasticDigits commented 2026-06-25 20:07:49 +00:00 (Migrated from gitlab.com)

mentioned in issue #342

mentioned in issue #342
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
cac-design-issue-544
renovate/configure
No results found.
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega#8
No description provided.