Bug: Podiums onchain and clearing projections show raw wei/WAD values #11
Labels
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
code/yieldomega#11
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
TimeCurvePage:
Podiums onchain section — 'Biggest single buy' and 'Highest cumulative CHARM' show raw wei (10000000000000000000) instead of human-readable (10). 'Last buyers' shows small integers (1, 2, 3) which is correct.
Clearing & Liquidity Anchors — 'Projected final reserve per 1 DOUB' shows 40000000000000 WAD, 'Launch liquidity anchor' 48000000000000, 'Kumbaya lower bound' 38400000000000. Should format to decimal.
Found on v1.4.0, local Anvil stack, commit
aaa52c9.Implemented in
0acecc6:frontend/src/lib/compactNumberFormat.tsformats decimal strings with k/m/b/t thene+scientific notation (default 3 significant figures, overridable via options). TimeCurve clearing anchors use WAD (18) and onchain podium values use the accepted assetdecimals. Please re-check on local Anvil.mentioned in commit
0acecc6edaReopened per maintainer request: please confirm the compact formatting on local Anvil (clearing anchors + onchain podium values) before we close this again.
partial fix on
d9987ca. compact formatting works for some values (charm redemptions show '250k', totalTokensForSale shows '1m'). but:indexer-side buys/redemptions correctly show decimal + abbr. the issue is in the onchain display components for clearing anchors and podium values.
Pushed
efa5a30: bigint coercion beforeformatUnits(fixes string-shaped RPC values mangling clearing anchors + podium reads),AmountDisplayabbr now uses compact sigfigs (podium preview),growthRateWadshown as compact decimal WAD.@brouie please re-verify on local Anvil: clearing anchors, onchain podium values, podium payout abbr.
partial fix on
44138d7. compact formatting works for some values:still showing raw values in these areas:
the abbr field is just repeating the decimal field for most values instead of actually abbreviating.
still partial on
254999d. compact works for: charm redemptions (250k), totalTokensForSale (1m).still raw/full precision:
abbr field is still repeating the decimal field instead of actually abbreviating for sub-1m values.
separate finding: fee sinks onchain dont match policy labels on TimeCurvePage. policy says DOUB LP 3000 bps but onchain shows 2500. CL8Y buy-and-burn policy 1000 but onchain 3500. Team policy 500 but onchain 0. Rabbit Treasury policy 3500 but onchain 2000. might be intentional with the new contract changes or a deploy script config issue -- lmk.
re-verified on
254999d(clean rebuild + npm ci). all items from my 4/3 report are now fixed:all formatting issues resolved. closing.
mentioned in issue #128
mentioned in issue #351
mentioned in issue #342
mentioned in merge request !525