code/yieldomega

Watch

Fork 0

QA: --help output of start-qa-local-full-stack.sh leaks 'set -euo pipefail' line (cosmetic) #105

New issue

Closed

opened 2026-05-01 12:19:48 +00:00 by Brouie · 6 comments

Brouie commented

2026-05-01 12:19:48 +00:00

(Migrated from gitlab.com)

P3-low cosmetic: --help output of scripts/start-qa-local-full-stack.sh includes the line set -euo pipefail at the bottom of the help text, which is shell setup not user-facing usage info.

Repro

$ bash scripts/start-qa-local-full-stack.sh --help
... (correct usage block) ...
  Swarm:    /tmp/yieldomega_bot_swarm.pids, /tmp/yieldomega_swarm_*.log
set -euo pipefail

Cause

usage() at line 44-46:

usage() {
  sed -n '3,35p' "$0" | sed 's/^# \{0,1\}//'
}

The header comment block ends at line 33. Line 34 is blank, line 35 is set -euo pipefail. Range 3,35p slurps in lines past the comment header.

Fix

Change '3,35p' -> '3,33p', or use a sentinel-aware approach (stop at first non-comment line).

Impact

Cosmetic only — no functional issue. Operators reading --help see one stray shell directive line.

cc @PlasticDigits

P3-low cosmetic: `--help` output of `scripts/start-qa-local-full-stack.sh` includes the line `set -euo pipefail` at the bottom of the help text, which is shell setup not user-facing usage info. ### Repro ``` $ bash scripts/start-qa-local-full-stack.sh --help ... (correct usage block) ... Swarm: /tmp/yieldomega_bot_swarm.pids, /tmp/yieldomega_swarm_*.log set -euo pipefail ``` ### Cause `usage()` at line 44-46: ``` usage() { sed -n '3,35p' "$0" | sed 's/^# \{0,1\}//' } ``` The header comment block ends at line 33. Line 34 is blank, line 35 is `set -euo pipefail`. Range `3,35p` slurps in lines past the comment header. ### Fix Change `'3,35p'` -> `'3,33p'`, or use a sentinel-aware approach (stop at first non-comment line). ### Impact Cosmetic only — no functional issue. Operators reading `--help` see one stray shell directive line. cc @PlasticDigits

Brouie commented

2026-05-01 12:20:31 +00:00

(Migrated from gitlab.com)

mentioned in issue #104

Brouie commented

2026-05-01 12:27:59 +00:00

(Migrated from gitlab.com)

mentioned in issue #100

PlasticDigits commented

2026-05-02 04:45:39 +00:00

(Migrated from gitlab.com)

mentioned in commit e256571363

mentioned in commit e256571363a2650df1e541fd5ef5b46448613ac7

PlasticDigits commented

2026-05-02 04:46:15 +00:00

(Migrated from gitlab.com)

Fixed on main (`e256571`)

Change: scripts/start-qa-local-full-stack.sh usage() now uses awk to print leading # banner lines from line 3 onward and stops at the first non-comment line (replaces brittle sed -n '3,35p'), so set -euo pipefail never appears in --help.

Invariant INV-QA-FULLSTACK-HELP-105 is documented and cross-linked from docs/testing/invariants-and-business-logic.md, qa-local-full-stack.md, manual-qa-checklists.md, e2e-anvil.md, skills/README.md, skills/script-with-timecurve-local/SKILL.md, and .cursor/skills/yieldomega-guardrails/SKILL.md.

Verification: bash scripts/start-qa-local-full-stack.sh --help contains no set -euo pipefail.

Work done in a git worktree; merged to main and pushed.

## Fixed on main (e256571) **Change:** [`scripts/start-qa-local-full-stack.sh`](https://gitlab.com/PlasticDigits/yieldomega/-/blob/main/scripts/start-qa-local-full-stack.sh) `usage()` now uses `awk` to print leading `#` banner lines from line 3 onward and stops at the first non-comment line (replaces brittle `sed -n '3,35p'`), so `set -euo pipefail` never appears in `--help`. **Invariant INV-QA-FULLSTACK-HELP-105** is documented and cross-linked from `docs/testing/invariants-and-business-logic.md`, `qa-local-full-stack.md`, `manual-qa-checklists.md`, `e2e-anvil.md`, `skills/README.md`, `skills/script-with-timecurve-local/SKILL.md`, and `.cursor/skills/yieldomega-guardrails/SKILL.md`. **Verification:** `bash scripts/start-qa-local-full-stack.sh --help` contains no `set -euo pipefail`. Work done in a git worktree; merged to `main` and pushed.

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-05-02 04:46:16 +00:00

PlasticDigits commented

2026-05-05 05:45:54 +00:00

(Migrated from gitlab.com)

mentioned in issue #153

PlasticDigits commented

2026-05-05 05:48:18 +00:00

(Migrated from gitlab.com)

marked this issue as related to #153

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega#105

No description provided.

Rows
Columns