Frontend: Disclosure when hybrid book leg enabled (quote may exclude book) #76

New issue

Closed

opened 2026-04-09 03:24:03 +00:00 by PlasticDigits · 6 comments

PlasticDigits commented

2026-04-09 03:24:03 +00:00

(Migrated from gitlab.com)

Type

missing-implementation — interim mitigation acceptable before full ADR implementation

Evidence

SECURITY_REVIEW.md FE-01; SwapPage.tsx

Dependencies

Wording coordinated with #64

Acceptance criteria

Warning visible before submit when book leg > 0
Link to docs/limit-orders.md or integrator doc

Epic

#59

## Type **missing-implementation** — **interim** mitigation acceptable before full ADR implementation ## Evidence - `SECURITY_REVIEW.md` FE-01; `SwapPage.tsx` ## Dependencies - Wording coordinated with #64 ## Acceptance criteria - [ ] Warning visible before submit when book leg > 0 - [ ] Link to `docs/limit-orders.md` or integrator doc ## Epic #59

PlasticDigits commented

2026-04-09 03:24:04 +00:00

(Migrated from gitlab.com)

marked this issue as related to #59

PlasticDigits commented

2026-04-09 03:24:04 +00:00

(Migrated from gitlab.com)

marked this issue as related to #56

PlasticDigits commented

2026-04-13 04:48:30 +00:00

(Migrated from gitlab.com)

FE-01 disclosure: Swap page now includes a clickable link to the canonical docs/limit-orders.md on GitLab in the hybrid book-leg alert, updated copy to cover indexer/LCD snapshot drift when hybrid estimates are used, plus a Vitest case (SwapPage.test.tsx) that asserts the alert and link appear before swap when a book leg is set on a direct CW20 route. @brouie please verify copy and UX in the browser.

**FE-01 disclosure:** Swap page now includes a clickable link to the canonical `docs/limit-orders.md` on GitLab in the hybrid book-leg alert, updated copy to cover indexer/LCD snapshot drift when hybrid estimates are used, plus a Vitest case (`SwapPage.test.tsx`) that asserts the alert and link appear before swap when a book leg is set on a direct CW20 route. @brouie please verify copy and UX in the browser.

Brouie commented

2026-04-20 06:39:07 +00:00

(Migrated from gitlab.com)

@PlasticDigits Verified on current main. Acceptance criteria:

Warning visible before submit when book leg > 0: SwapPage.tsx line 887 (showHybridBookSubmitWarning gate), alert at line 890 labeled 'Limit book leg' with copy 'The on-screen estimate may still diverge from execution if the indexer or LCD snapshot differs from the chain at submit time (hybrid / L8).'
Link to docs/limit-orders.md: SwapPage.tsx line 895 -- external link to https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/blob/main/docs/limit-orders.md with target=_blank and rel=noopener noreferrer

Vitest coverage: SwapPage.test.tsx line 96 test 'shows hybrid book warning with doc link before swap when book leg > 0' asserts the alert presence and that the link href contains docs/limit-orders.md.

FE-01 disclosure properly implemented as interim mitigation per security review. Closing.

@PlasticDigits Verified on current main. Acceptance criteria: - [x] Warning visible before submit when book leg > 0: SwapPage.tsx line 887 (showHybridBookSubmitWarning gate), alert at line 890 labeled 'Limit book leg' with copy 'The on-screen estimate may still diverge from execution if the indexer or LCD snapshot differs from the chain at submit time (hybrid / L8).' - [x] Link to docs/limit-orders.md: SwapPage.tsx line 895 -- external link to https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/blob/main/docs/limit-orders.md with target=_blank and rel=noopener noreferrer **Vitest coverage:** SwapPage.test.tsx line 96 test 'shows hybrid book warning with doc link before swap when book leg > 0' asserts the alert presence and that the link href contains docs/limit-orders.md. FE-01 disclosure properly implemented as interim mitigation per security review. Closing.

Brouie (Migrated from gitlab.com) closed this issue

2026-04-20 06:39:11 +00:00

Brouie commented

2026-04-20 06:43:37 +00:00

(Migrated from gitlab.com)

mentioned in issue #79