code/cl8y-dex-terraclassic

Fork 0

ops: post-merge !477 leftover verify (#692) #701

New issue

Closed

opened 2026-08-29 04:56:13 +00:00 by PlasticDigits · 7 comments

PlasticDigits commented

2026-08-29 04:56:13 +00:00

(Migrated from gitlab.com)

Summary

!1195 (#692 /pool Vol USD + pair-list volume_usd_24h) is on main (f4fa6788). Local AC passed before merge (make verify-issue-692 8/8, including Playwright e2e/pool-table-547 with 5 workers and related 547/655/534). Close this leftover when Coolify migrate + live list↔stats + /pool visual checks are done.

!1185 (#678 acquire guidance) was already on main; product claims re-checked PASS (make verify-issue-678 7/7). No extra leftover for #678 (stack leftover #686 already closed).

Do not reopen #692 / #678 unless a merged invariant is wrong (GitLab auto-closed #692 on merge).

No automerge. Do not wait on GitLab CI (quota is not a product signal). GitLab CI on !1195 failed with ci_quota_exceeded only.

Merged MRs

MR	Issue	What landed
!1195	#692	`pair_volume_24h.volume_usd` stamp; additive `GET /pairs` `volume_usd_24h`; `sort=volume_usd_24h` NULLS LAST; `/pool` Vol + Manage + pair-search badges compact USD or —; `make verify-issue-692`
!1185	#678	Already merged 2026-08-27; Swap/Trade unfunded-pay acquire guidance. Sanity on current `main` still PASS.

Operator leftovers

Coolify indexer (#692)

Apply migration then redeploy indexer from current main:

indexer/migrations/20260829120000_pair_volume_24h_usd.sql

Adds nullable pair_volume_24h.volume_usd + NULLS LAST index. refresh_pair_volumes must run once after deploy so list USD is not all omitted.

# priced pair: list USD ≈ pair stats volume_usd (PVol-5, ~5 min lag)
curl -sS "https://indexer.dex.cl8y.com/api/v1/pairs?limit=5&sort=volume_usd_24h&order=desc"
curl -sS "https://indexer.dex.cl8y.com/api/v1/pairs/${PAIR}/stats"
# invalid sort still 400
curl -sS -o /dev/null -w "%{http_code}\n" \
  "https://indexer.dex.cl8y.com/api/v1/pairs?sort=volume_usd"
# expect 400

Do not N+1 /stats from /pool. Do not convert volume_quote_24h in the browser.

Coolify frontend (#692)

Rebuild frontend from current main. /pool Vol cells must be $… or — (never quote-token 48.2M without $). Manage line + Trade/Limits/Charts pair-search badges use the same USD field.

Live / LocalTerra QA

Priced UST1/cUSTC (or UST1/USTR) list volume_usd_24h ≈ GET /pairs/{addr}/stats volume_usd within rollup lag.
Unpriced / idle → —, not a fake $0.
Light + dark /pool Vol readability.
Production gem hide unchanged (P562).
Local indexer: restart after git pull so the new migration applies (running process on pre-!1195 binary will omit volume_usd_24h).

Open MR left alone

!1194 (#693 /trade ticket flatten) is another worker’s open MR. Overlaps Makefile, AGENTS.md, docs/frontend.md with !1195. Rebase onto current main before merge — do not close or merge it from this leftover.

Local verify (after `git pull`)

make setup-indexer-postgres   # if indexer/.env missing
make verify-issue-692

Guardrails

Do not reopen #692 / #678 for ops/QA.
Do not wait on GitLab CI quota.
Do not change liquidity_usd / v2 LP USD (#655 / #664).
Do not humanize indexer volume_quote_24h.
Do not merge or delete feat/693-trade-ticket-flatten while !1194 is open.

## Summary [!1195](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/477) (#692 `/pool` Vol USD + pair-list `volume_usd_24h`) is on `main` (`f4fa6788`). Local AC passed before merge (`make verify-issue-692` **8/8**, including Playwright `e2e/pool-table-547` with 5 workers and related 547/655/534). **Close this leftover when Coolify migrate + live list↔stats + `/pool` visual checks are done.** [!1185](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/467) (#678 acquire guidance) was already on `main`; product claims re-checked PASS (`make verify-issue-678` 7/7). No extra leftover for #678 (stack leftover [#686](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/686) already closed). Do **not** reopen [#692](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/692) / [#678](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/678) unless a merged invariant is wrong (GitLab auto-closed #692 on merge). No automerge. Do not wait on GitLab CI (quota is not a product signal). GitLab CI on !1195 failed with `ci_quota_exceeded` only. ## Merged MRs | MR | Issue | What landed | |----|-------|-------------| | !1195 | #692 | `pair_volume_24h.volume_usd` stamp; additive `GET /pairs` `volume_usd_24h`; `sort=volume_usd_24h` NULLS LAST; `/pool` Vol + Manage + pair-search badges compact USD or —; `make verify-issue-692` | | !1185 | #678 | Already merged 2026-08-27; Swap/Trade unfunded-pay acquire guidance. Sanity on current `main` still PASS. | ## Operator leftovers ### Coolify indexer (#692) Apply migration then redeploy indexer from current `main`: ``` indexer/migrations/20260829120000_pair_volume_24h_usd.sql ``` Adds nullable `pair_volume_24h.volume_usd` + `NULLS LAST` index. `refresh_pair_volumes` must run once after deploy so list USD is not all omitted. ```bash # priced pair: list USD ≈ pair stats volume_usd (PVol-5, ~5 min lag) curl -sS "https://indexer.dex.cl8y.com/api/v1/pairs?limit=5&sort=volume_usd_24h&order=desc" curl -sS "https://indexer.dex.cl8y.com/api/v1/pairs/${PAIR}/stats" # invalid sort still 400 curl -sS -o /dev/null -w "%{http_code}\n" \ "https://indexer.dex.cl8y.com/api/v1/pairs?sort=volume_usd" # expect 400 ``` Do **not** N+1 `/stats` from `/pool`. Do **not** convert `volume_quote_24h` in the browser. ### Coolify frontend (#692) Rebuild frontend from current `main`. `/pool` Vol cells must be `$…` or **—** (never quote-token `48.2M` without `$`). Manage line + Trade/Limits/Charts pair-search badges use the same USD field. ### Live / LocalTerra QA - Priced UST1/cUSTC (or UST1/USTR) list `volume_usd_24h` ≈ `GET /pairs/{addr}/stats` `volume_usd` within rollup lag. - Unpriced / idle → **—**, not a fake `$0`. - Light + dark `/pool` Vol readability. - Production gem hide unchanged (P562). - Local indexer: restart after `git pull` so the new migration applies (running process on pre-!1195 binary will omit `volume_usd_24h`). ### Open MR left alone [!1194](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/476) (#693 `/trade` ticket flatten) is another worker’s open MR. Overlaps `Makefile`, `AGENTS.md`, `docs/frontend.md` with !1195. **Rebase onto current `main` before merge** — do not close or merge it from this leftover. ## Local verify (after `git pull`) ```bash make setup-indexer-postgres # if indexer/.env missing make verify-issue-692 ``` ## Guardrails - Do not reopen #692 / #678 for ops/QA. - Do not wait on GitLab CI quota. - Do not change `liquidity_usd` / v2 LP USD (#655 / #664). - Do not humanize indexer `volume_quote_24h`. - Do not merge or delete `feat/693-trade-ticket-flatten` while !1194 is open.

PlasticDigits commented

2026-08-29 04:56:14 +00:00

(Migrated from gitlab.com)

marked as related to #692

PlasticDigits commented

2026-08-29 04:56:25 +00:00

(Migrated from gitlab.com)

mentioned in issue #692

PlasticDigits commented

2026-08-29 04:56:38 +00:00

(Migrated from gitlab.com)

!1194 (#693) is now cannot_be_merged / has_conflicts: true against current main after !1195. Overlap is Makefile, AGENTS.md, docs/frontend.md. Left that worktree and remote branch in place for the other worker — rebase there, not on this leftover.

!1194 (#693) is now `cannot_be_merged` / `has_conflicts: true` against current `main` after !1195. Overlap is `Makefile`, `AGENTS.md`, `docs/frontend.md`. Left that worktree and remote branch in place for the other worker — rebase there, not on this leftover.

PlasticDigits commented

2026-08-29 05:14:43 +00:00

(Migrated from gitlab.com)

mentioned in issue #702

PlasticDigits commented

2026-08-29 05:14:56 +00:00

(Migrated from gitlab.com)

!1194 (#693) is now merged to main (e6ddbf1d). The feat/693-trade-ticket-flatten worktree is gone. Frontend /trade leftover QA is #702. This ticket remains the indexer/Coolify leftover for !1195 (#692 Vol USD).

!1194 (#693) is now merged to `main` (`e6ddbf1d`). The `feat/693-trade-ticket-flatten` worktree is gone. Frontend `/trade` leftover QA is #702. This ticket remains the indexer/Coolify leftover for !1195 (#692 Vol USD).

PlasticDigits commented

2026-08-29 10:04:44 +00:00

(Migrated from gitlab.com)

mentioned in commit 5ca6fc5a47

mentioned in commit 5ca6fc5a47e78bb901e8a945e3cd445b84232482

PlasticDigits commented

2026-08-29 10:05:56 +00:00

(Migrated from gitlab.com)

Landed leftover harness on main (5ca6fc5a). Playbook: skills/AGENTS_POST_MERGE_OPS_701.md. Regression: make verify-issue-701.

What ran

Child: make verify-issue-692 PASS (including Playwright e2e/pool-table-547 at 5 workers, plus related 547/655/534).
Coolify indexer: GET /pairs?sort=volume_usd_24h includes volume_usd_24h; priced pair terra1ceprjsxp86ggftf5e38wwt34l83e5gq7penkdnv4wsatkwcs8v6qccw55f list USD ≈ stats volume_usd (delta 0); sort=volume_usd → 400.
Coolify frontend JS: /pool Vol USD markers (pool-row-vol, volume_usd_24h).

Did not reopen #692 / #678. Did not change liquidity_usd / v2 LP USD. Did not humanize volume_quote_24h. !1194 leftover stays on #702.

Checklist to re-verify

make verify-issue-692
Coolify list volume_usd_24h ≈ pair /stats volume_usd
Invalid sort=volume_usd → 400
Live bundle has /pool Vol USD field (not quote-token volume)
LocalTerra pool-table Playwright (5 workers)
Operator /pool light + dark Vol readability (~375 / ~1280) — headless Playwright against dex.cl8y.com hit PAGE UNAVAILABLE / blank 1280 after the risk modal; not a substitute for a real browser walk
Confirm unpriced / idle cells show — (not a fake $0) on Coolify /pool

Leaving open for the Coolify visual leftover. Close when the light/dark /pool walk is recorded.

Landed leftover harness on `main` (`5ca6fc5a`). Playbook: `skills/AGENTS_POST_MERGE_OPS_701.md`. Regression: `make verify-issue-701`. ## What ran - Child: `make verify-issue-692` PASS (including Playwright `e2e/pool-table-547` at 5 workers, plus related 547/655/534). - Coolify indexer: `GET /pairs?sort=volume_usd_24h` includes `volume_usd_24h`; priced pair `terra1ceprjsxp86ggftf5e38wwt34l83e5gq7penkdnv4wsatkwcs8v6qccw55f` list USD ≈ stats `volume_usd` (delta 0); `sort=volume_usd` → **400**. - Coolify frontend JS: `/pool` Vol USD markers (`pool-row-vol`, `volume_usd_24h`). Did **not** reopen #692 / #678. Did not change `liquidity_usd` / v2 LP USD. Did not humanize `volume_quote_24h`. !1194 leftover stays on #702. ## Checklist to re-verify - [x] `make verify-issue-692` - [x] Coolify list `volume_usd_24h` ≈ pair `/stats` `volume_usd` - [x] Invalid `sort=volume_usd` → 400 - [x] Live bundle has `/pool` Vol USD field (not quote-token volume) - [x] LocalTerra pool-table Playwright (5 workers) - [ ] Operator `/pool` light + dark Vol readability (~375 / ~1280) — headless Playwright against `dex.cl8y.com` hit PAGE UNAVAILABLE / blank 1280 after the risk modal; not a substitute for a real browser walk - [ ] Confirm unpriced / idle cells show **—** (not a fake `$0`) on Coolify `/pool` Leaving **open** for the Coolify visual leftover. Close when the light/dark `/pool` walk is recorded.

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-08-29 12:27:54 +00:00