ops: post-merge !469/!471/!472 leftover verify (#684 #685 #687) #688

Closed
opened 2026-08-27 07:43:01 +00:00 by PlasticDigits · 10 comments
PlasticDigits commented 2026-08-27 07:43:01 +00:00 (Migrated from gitlab.com)

Summary

!1187 (#687), !1189 (#684), and !1190 (#685) are on main. Local AC for indexer/docs/verify targets passed before merge. Close this leftover when Coolify + Llama GitHub crawler ops are done.

Do not reopen #684 / #685 unless a merged invariant is wrong (GitLab auto-closed them on merge). Keep #687 open until GitHub dimension-adapters#8987 pnpm test fees/dexs cl8y-dex succeeds.

No automerge. Do not wait on GitLab CI (quota failed; not a product signal).

Merged MRs

MR Issue What landed
!1187 #687 Llama daily_fees_usd headline = EFee-6 priced SUM; adapter start 2026-08-17 / 1786924800; METRIC+residual; make verify-issue-687
!1189 #684 Persist post-event AMM reserve_* on swap/liquidity; GET /gt/events does not JOIN live pair_reserves; reverse-apply backfill CLI; make verify-issue-684
!1190 #685 /cg/tickers liquidity_in_usd = pair_liquidity_usd stamp; bid/ask mid±fee_bps; CMC numeric ids + isFrozen; gem omit lockstep; make verify-issue-685

Conflict resolution on merge: Makefile help kept verify-issue-686 + 687 + 685 + 684; invariants kept GT post-event reserves and Llama priced SUM; gt.rs uses shared listing_exclude::is_excluded_cw20 (no duplicate local helper).

Operator leftovers

Coolify indexer (all three)

Redeploy indexer from current main (906b6e7f+). Apply migrate:

20260827160000_gt_event_post_reserves.sql

Then:

cl8y-dex-indexer backfill-gt-event-reserves

No wasm / dApp change required for this stack.

#684 AC11 (live)

Pick a factory pair with ≥2 pool swaps in a ≤2000-block window. Confirm reserves change across events. Do not paste integrator chat.

curl -sS "https://indexer.dex.cl8y.com/gt/events?fromBlock=H1&toBlock=H2"

#685 live field truth

curl -sS "https://indexer.dex.cl8y.com/cg/tickers?limit=5"
# priced pair: liquidity_in_usd ≈ GET /api/v1/pairs/{pool_id} liquidity_usd
# and ≠ that pair's 24h volume_usd

#687 Llama crawler

  1. Patch GitHub dimension-adapters#8987: start: "2026-08-17", METRIC groups + residual (match scripts/defillama/fees/index.ts). Do not addUSDValue(total) then labels. Do not map JSON null → $0.
  2. Paste pnpm test fees cl8y-dex and pnpm test dexs cl8y-dex (yesterday + start) on #8987 and on #687.
  3. After Coolify deploy, curl yesterday + 1786924800 as in scripts/defillama/README.md. Prior day (start - 86400) stays 404.

Local verify (after git pull)

make setup-indexer-postgres   # if indexer/.env missing
make verify-issue-687
make verify-issue-684
make verify-issue-646
make verify-issue-685

Guardrails

  • Do not reopen #631 / #683 / #224 / #646.
  • Do not treat CG liquidity_in_usd as Llama TVL.
  • Do not JOIN live pair_reserves onto /gt/events.
  • Do not wait on GitLab CI quota.
  • Do not swallow Llama HTTP 404 as $0.

Sanity notes from merge review (non-blocking)

  • #684: same-tx swap-then-liquidity phase is swap-first (matches typical zap). First catch-up events stay NULL until backfill (intentional).
  • #685: list path may still emit duplicate SYMBOL_SYMBOL rows with different pool_id; orderbook/trades 404 those keys. Bid/ask is fee mid, not hybrid book best (documented).
  • #687: GitHub adapter + Coolify are the close gate, not in-repo code.
## Summary [!1187](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/469) (#687), [!1189](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/471) (#684), and [!1190](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/472) (#685) are on `main`. Local AC for indexer/docs/verify targets passed before merge. **Close this leftover when Coolify + Llama GitHub crawler ops are done.** Do **not** reopen [#684](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/684) / [#685](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/685) unless a merged invariant is wrong (GitLab auto-closed them on merge). Keep [#687](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/687) open until GitHub [dimension-adapters#8987](https://github.com/DefiLlama/dimension-adapters/pull/8987) `pnpm test fees/dexs cl8y-dex` succeeds. No automerge. Do not wait on GitLab CI (quota failed; not a product signal). ## Merged MRs | MR | Issue | What landed | |----|-------|-------------| | !1187 | #687 | Llama `daily_fees_usd` headline = EFee-6 priced SUM; adapter `start` `2026-08-17` / `1786924800`; METRIC+residual; `make verify-issue-687` | | !1189 | #684 | Persist post-event AMM `reserve_*` on swap/liquidity; GET `/gt/events` does not JOIN live `pair_reserves`; reverse-apply backfill CLI; `make verify-issue-684` | | !1190 | #685 | `/cg/tickers` `liquidity_in_usd` = `pair_liquidity_usd` stamp; bid/ask mid±`fee_bps`; CMC numeric ids + `isFrozen`; gem omit lockstep; `make verify-issue-685` | Conflict resolution on merge: Makefile help kept `verify-issue-686` + `687` + `685` + `684`; invariants kept GT post-event reserves **and** Llama priced SUM; `gt.rs` uses shared `listing_exclude::is_excluded_cw20` (no duplicate local helper). ## Operator leftovers ### Coolify indexer (all three) Redeploy indexer from current `main` (`906b6e7f+`). Apply migrate: ``` 20260827160000_gt_event_post_reserves.sql ``` Then: ```bash cl8y-dex-indexer backfill-gt-event-reserves ``` No wasm / dApp change required for this stack. ### #684 AC11 (live) Pick a factory pair with ≥2 pool swaps in a ≤2000-block window. Confirm `reserves` **change** across events. Do not paste integrator chat. ```bash curl -sS "https://indexer.dex.cl8y.com/gt/events?fromBlock=H1&toBlock=H2" ``` ### #685 live field truth ```bash curl -sS "https://indexer.dex.cl8y.com/cg/tickers?limit=5" # priced pair: liquidity_in_usd ≈ GET /api/v1/pairs/{pool_id} liquidity_usd # and ≠ that pair's 24h volume_usd ``` ### #687 Llama crawler 1. Patch GitHub [dimension-adapters#8987](https://github.com/DefiLlama/dimension-adapters/pull/8987): `start: "2026-08-17"`, METRIC groups + residual (match `scripts/defillama/fees/index.ts`). Do not `addUSDValue(total)` then labels. Do not map JSON `null` → `$0`. 2. Paste `pnpm test fees cl8y-dex` and `pnpm test dexs cl8y-dex` (yesterday + start) on #8987 and on #687. 3. After Coolify deploy, curl yesterday + `1786924800` as in `scripts/defillama/README.md`. Prior day (`start - 86400`) stays **404**. ## Local verify (after `git pull`) ```bash make setup-indexer-postgres # if indexer/.env missing make verify-issue-687 make verify-issue-684 make verify-issue-646 make verify-issue-685 ``` ## Guardrails - Do not reopen #631 / #683 / #224 / #646. - Do not treat CG `liquidity_in_usd` as Llama TVL. - Do not JOIN live `pair_reserves` onto `/gt/events`. - Do not wait on GitLab CI quota. - Do not swallow Llama HTTP 404 as `$0`. ## Sanity notes from merge review (non-blocking) - **#684:** same-tx swap-then-liquidity phase is swap-first (matches typical zap). First catch-up events stay NULL until backfill (intentional). - **#685:** list path may still emit duplicate `SYMBOL_SYMBOL` rows with different `pool_id`; orderbook/trades **404** those keys. Bid/ask is fee mid, not hybrid book best (documented). - **#687:** GitHub adapter + Coolify are the close gate, not in-repo code.
PlasticDigits commented 2026-08-27 07:43:02 +00:00 (Migrated from gitlab.com)

marked as related to #684

marked as related to #684
PlasticDigits commented 2026-08-27 07:43:03 +00:00 (Migrated from gitlab.com)

marked as related to #685

marked as related to #685
PlasticDigits commented 2026-08-27 07:43:03 +00:00 (Migrated from gitlab.com)

marked as related to #687

marked as related to #687
PlasticDigits commented 2026-08-27 07:43:22 +00:00 (Migrated from gitlab.com)

mentioned in issue #684

mentioned in issue #684
PlasticDigits commented 2026-08-27 07:43:23 +00:00 (Migrated from gitlab.com)

mentioned in issue #685

mentioned in issue #685
PlasticDigits commented 2026-08-27 07:43:24 +00:00 (Migrated from gitlab.com)

mentioned in issue #687

mentioned in issue #687
PlasticDigits commented 2026-08-27 07:43:25 +00:00 (Migrated from gitlab.com)

Opened after merging !1187 / !1189 / !1190 without automerge or CI wait. Child issues: #684 and #685 auto-closed on merge; #687 stays open for the Llama GitHub crawler close gate. Next: Coolify indexer migrate+redeploy+GT backfill, live AC11/#685 ticker probe, then GitHub #8987 pnpm test.

Opened after merging !1187 / !1189 / !1190 without automerge or CI wait. Child issues: #684 and #685 auto-closed on merge; #687 stays open for the Llama GitHub crawler close gate. Next: Coolify indexer migrate+redeploy+GT backfill, live AC11/#685 ticker probe, then GitHub #8987 `pnpm test`.
PlasticDigits commented 2026-08-27 07:45:08 +00:00 (Migrated from gitlab.com)

Follow-up on main (79a4deb5): make Cloud Agent help now lists verify-issue-684 with 685/686/687. Tip is 79a4deb5. Local worktrees/branches for the merged fix/* branches were removed; no stashes. No other open MRs.

Follow-up on `main` (`79a4deb5`): `make` Cloud Agent help now lists `verify-issue-684` with 685/686/687. Tip is `79a4deb5`. Local worktrees/branches for the merged fix/* branches were removed; no stashes. No other open MRs.
PlasticDigits commented 2026-08-27 08:03:44 +00:00 (Migrated from gitlab.com)

Ops 2026-08-27 — local verify + live probes + Llama #8987

Tip 79a4deb5. Did not reopen #684 / #685 / #646 / #631 / #683 / #224.

Local verify (this checkout)

All green:

  • make verify-issue-684 — 4/4
  • make verify-issue-685 — 4/4
  • make verify-issue-646 — 2/2
  • make verify-issue-687 — 7/7 (includes related 631 + 683)

No wasm / dApp / frontend rebuild for this stack. No new Coolify env vars.

Coolify indexer — already on new GET paths

Live https://indexer.dex.cl8y.com is serving the merged indexer (migrate applied; GET reads swap_events.reserve_*; #685 TVL stamp; #687 priced-SUM methodology). Still missing: one-shot backfill.

Leftover Status
Redeploy indexer 906b6e7f+ / 79a4deb5 Done (live behavior matches tip)
Migrate 20260827160000_gt_event_post_reserves.sql Done (GET 200 with NULL→"0", not the old live snapshot)
cl8y-dex-indexer backfill-gt-event-reserves Not done
#684 AC11 live reserves change Blocked on backfill
#685 live field truth Done
#687 Llama start + pnpm test Done on GitHub (dimension-adapters#8987 6e87a48); waiting on Llama merge

#684 AC11 (live) — backfill required

Original sample window still returns "0" / "0" (NULL columns, as designed until backfill):

GET /gt/events?fromBlock=30128918&toBlock=30129103
pair terra1q5karg99p5hc0jvplgn2fd8akg39r4ss00cu5rwkm600yqvmssgqhwqvq0
block 30128918 swap asset0In=0.831… asset1Out=8016.78 reserves 0 / 0
block 30129103 swap asset0In=0.775… asset1Out=7412.02 reserves 0 / 0

Recent 2000-block tip window: same pair, 11 swaps, all "0" / "0". Old bug (identical non-zero live snapshot) is gone.

Operator (Coolify indexer container, one-shot — do not replace the server CMD):

cl8y-dex-indexer backfill-gt-event-reserves

Then re-probe the same window and confirm reserves.asset0 / asset1 change across those two swaps. No integrator chat.

#685 live field truth — pass

GET /cg/tickers?limit=5 UST1_USTR:

  • liquidity_in_usd 31204.98… ≈ GET /api/v1/pairs/terra16vxrhpvpcucu05y0nr862vf9hnqeh274uaff4s7hz4n0ea74006qf5hgqy liquidity_usd 31213.66… (60s cache drift)
  • Not 24h quote volume (base_volume 1303635808)
  • Bid/ask are reserve mid ± fee_bps, not last_price * 0.999
  • /cmc/ticker base_id / quote_id are numbers; cl8y_*_address present; isFrozen "0"
  • /cg/pairs n=7, no gem leak

#687 Llama crawler — patched + tests green

Pushed https://github.com/DefiLlama/dimension-adapters/pull/8987 6e87a48: start: "2026-08-17". METRIC+residual unchanged. Throw-on-null unchanged. Do not map 404/null → $0.

Live daily GET:

timestamp http date volume_usd daily_fees_usd
1786838400 404 start−86400 — —
1786924800 200 2026-08-17 716.51 "0"
1787702400 200 2026-08-26 1511.77 90.27
1787788800 200 2026-08-27 819.30 10.50

pnpm test on that branch (also on #8987 and #687):

pnpm test fees cl8y-dex
# 26 Aug → fees 90.00 / revenue 90.00 / SSR 0; breakdown swap 52 + wrap 31 + mint/redeem 7.97

pnpm test dexs cl8y-dex
# 26 Aug → volume 1.51 k; backfill start 17/8/2026

pnpm test fees cl8y-dex 2026-08-18
# window = start day → fees 0.00 (idle, no throw)

pnpm test dexs cl8y-dex 2026-08-18
# volume 717.00

Passing 2026-08-17 as the CLI date arg skips terra (window end = start midnight). That is expected.

Keep #687 open until Llama merges #8987. Do not close this leftover until the GT backfill + AC11 re-probe.

## Ops 2026-08-27 — local verify + live probes + Llama #8987 Tip `79a4deb5`. Did **not** reopen #684 / #685 / #646 / #631 / #683 / #224. ### Local verify (this checkout) All green: - `make verify-issue-684` — 4/4 - `make verify-issue-685` — 4/4 - `make verify-issue-646` — 2/2 - `make verify-issue-687` — 7/7 (includes related 631 + 683) No wasm / dApp / frontend rebuild for this stack. No new Coolify env vars. ### Coolify indexer — already on new GET paths Live `https://indexer.dex.cl8y.com` is serving the merged indexer (migrate applied; GET reads `swap_events.reserve_*`; #685 TVL stamp; #687 priced-SUM methodology). **Still missing: one-shot backfill.** | Leftover | Status | |----------|--------| | Redeploy indexer `906b6e7f+` / `79a4deb5` | **Done** (live behavior matches tip) | | Migrate `20260827160000_gt_event_post_reserves.sql` | **Done** (GET 200 with NULL→`"0"`, not the old live snapshot) | | `cl8y-dex-indexer backfill-gt-event-reserves` | **Not done** | | #684 AC11 live reserves change | **Blocked on backfill** | | #685 live field truth | **Done** | | #687 Llama `start` + `pnpm test` | **Done on GitHub** (dimension-adapters#8987 `6e87a48`); waiting on Llama merge | ### #684 AC11 (live) — backfill required Original sample window still returns `"0"` / `"0"` (NULL columns, as designed until backfill): ``` GET /gt/events?fromBlock=30128918&toBlock=30129103 pair terra1q5karg99p5hc0jvplgn2fd8akg39r4ss00cu5rwkm600yqvmssgqhwqvq0 block 30128918 swap asset0In=0.831… asset1Out=8016.78 reserves 0 / 0 block 30129103 swap asset0In=0.775… asset1Out=7412.02 reserves 0 / 0 ``` Recent 2000-block tip window: same pair, 11 swaps, all `"0"` / `"0"`. Old bug (identical non-zero live snapshot) is gone. **Operator (Coolify indexer container, one-shot — do not replace the server CMD):** ``` cl8y-dex-indexer backfill-gt-event-reserves ``` Then re-probe the same window and confirm `reserves.asset0` / `asset1` **change** across those two swaps. No integrator chat. ### #685 live field truth — pass `GET /cg/tickers?limit=5` UST1_USTR: - `liquidity_in_usd` `31204.98…` ≈ `GET /api/v1/pairs/terra16vxrhpvpcucu05y0nr862vf9hnqeh274uaff4s7hz4n0ea74006qf5hgqy` `liquidity_usd` `31213.66…` (60s cache drift) - Not 24h quote volume (`base_volume` 1303635808) - Bid/ask are reserve mid ± `fee_bps`, not `last_price * 0.999` - `/cmc/ticker` `base_id` / `quote_id` are numbers; `cl8y_*_address` present; `isFrozen` `"0"` - `/cg/pairs` n=7, no gem leak ### #687 Llama crawler — patched + tests green Pushed https://github.com/DefiLlama/dimension-adapters/pull/8987 `6e87a48`: `start: "2026-08-17"`. METRIC+residual unchanged. Throw-on-null unchanged. Do not map 404/`null` → `$0`. Live daily GET: | timestamp | http | date | volume_usd | daily_fees_usd | |-----------|------|------|------------|----------------| | 1786838400 | **404** | start−86400 | — | — | | 1786924800 | 200 | 2026-08-17 | 716.51 | `"0"` | | 1787702400 | 200 | 2026-08-26 | 1511.77 | 90.27 | | 1787788800 | 200 | 2026-08-27 | 819.30 | 10.50 | `pnpm test` on that branch (also on #8987 and #687): ``` pnpm test fees cl8y-dex # 26 Aug → fees 90.00 / revenue 90.00 / SSR 0; breakdown swap 52 + wrap 31 + mint/redeem 7.97 pnpm test dexs cl8y-dex # 26 Aug → volume 1.51 k; backfill start 17/8/2026 pnpm test fees cl8y-dex 2026-08-18 # window = start day → fees 0.00 (idle, no throw) pnpm test dexs cl8y-dex 2026-08-18 # volume 717.00 ``` Passing `2026-08-17` as the CLI date arg skips terra (window end = start midnight). That is expected. Keep #687 open until Llama merges #8987. **Do not close this leftover until the GT backfill + AC11 re-probe.**
PlasticDigits commented 2026-08-27 08:09:20 +00:00 (Migrated from gitlab.com)

Ops 2026-08-27 — GT backfill + AC11 pass

Coolify ran:

cl8y-dex-indexer backfill-gt-event-reserves
pairs=20 swaps_filled=1902 liqs_filled=63 skipped_ambiguous=188

#684 AC11 (live) — pass

GET /gt/events?fromBlock=30128918&toBlock=30129103 on pair terra1q5karg99p5hc0jvplgn2fd8akg39r4ss00cu5rwkm600yqvmssgqhwqvq0:

block asset0In / asset1Out reserves.asset0 / asset1
30128918 0.83145 / 8016.78 184.29892 / 1801399.07
30129103 0.77546 / 7412.02 185.07438 / 1793851.18

Reserves change. No longer "0"/"0" and no longer the identical live snapshot. Recent 2000-block tip window: 11 swaps on the same pair, unique reserve tuples > 1.

Leftover status

Item Status
Coolify migrate + redeploy Done (earlier)
backfill-gt-event-reserves Done
#684 AC11 Pass
#685 live field truth Pass (earlier)
Llama pnpm test on #8987 Pass on fork 6e87a48

Closing this leftover. Keep #687 open until Llama merges dimension-adapters#8987. Do not reopen #684 / #685.

## Ops 2026-08-27 — GT backfill + AC11 pass Coolify ran: ``` cl8y-dex-indexer backfill-gt-event-reserves pairs=20 swaps_filled=1902 liqs_filled=63 skipped_ambiguous=188 ``` ### #684 AC11 (live) — pass `GET /gt/events?fromBlock=30128918&toBlock=30129103` on pair `terra1q5karg99p5hc0jvplgn2fd8akg39r4ss00cu5rwkm600yqvmssgqhwqvq0`: | block | asset0In / asset1Out | reserves.asset0 / asset1 | |-------|----------------------|--------------------------| | 30128918 | 0.83145 / 8016.78 | **184.29892 / 1801399.07** | | 30129103 | 0.77546 / 7412.02 | **185.07438 / 1793851.18** | Reserves **change**. No longer `"0"`/`"0"` and no longer the identical live snapshot. Recent 2000-block tip window: 11 swaps on the same pair, unique reserve tuples > 1. ### Leftover status | Item | Status | |------|--------| | Coolify migrate + redeploy | Done (earlier) | | `backfill-gt-event-reserves` | **Done** | | #684 AC11 | **Pass** | | #685 live field truth | Pass (earlier) | | Llama `pnpm test` on #8987 | Pass on fork `6e87a48` | Closing this leftover. Keep [#687](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/687) open until Llama merges [dimension-adapters#8987](https://github.com/DefiLlama/dimension-adapters/pull/8987). Do not reopen #684 / #685.
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-08-27 08:09:38 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic#688
No description provided.