ops: post-merge !415–!417 tax swarm / e2e-tx / Layer B tax-on leftovers #625
Labels
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
code/cl8y-dex-terraclassic#625
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Parent
Merged on
main(no CI wait):3ca5f628)36fce44c)01cd541b)Conflict resolves kept all three verify targets / skill links (
77df08f4,5f683cfe).Do not reopen #621 / #622 / #623 unless a merged invariant is wrong (S621, E622, C623). Fresh #620 seed volume leftovers stay on #624.
Playbooks:
AGENTS_LOCALNET_SWARM_TAX.md,AGENTS_E2E_COMMUNITY_TAX_TX.md,AGENTS_CW20_CODE_ID_TAX_ON.md.Merge notes: #621 · #622 · #623.
Why this is needed
In-repo gates are green on the merge tip:
make verify-issue-6219/9 including live TS--dry-run(swarm_tax+ seed pair visible)make verify-issue-6226/6 docs + spec + unit (14 Vitest)make verify-issue-623docs / B-lt untouched / FoT mutant / crates PASSGitLab CI on !1133–!1135 failed with
ci_quota_exceeded(not a code defect). Live leftovers were not proven on a clean seed volume:layer-b-tax-on.shextra-debit sell fromtest2is OK; the buy still Sends EMBER fromtest1(manager + treasury). Manager-exempt buy is 1:1 (#609), so the suite failsbuy user credit >= pair debiteven whenbuy_bps=500. Fix: buy from a non-manager / non-exempt wallet (or assert-exempt explicitly). Then re-runLAYER_B_TAX_ON=1 make verify-issue-623on a clean seed and keep the ephemeral path green.100000vs preview105000; indexer down; leftover #623 tax pairs filledpairs[0]). Needs freshmake deploy-local+ indexer, screenshots, and skip-tax fail-closed.make swarm-local/make swarm-launchwithout Mint errors or an insufficient-funds storm; LCD extra-debit / buy split / hop-trader;SWARM_TAX_WORKERS=0;make verify-issue-293stillpool_only.taxTokenslength ≫ 1). Gem pickers and tax-on seed pins must ignore them; prefer a#624fresh volume.Acceptance
LAYER_B_TAX_ON=1 make verify-issue-623green on seed pins and ephemeral.VERIFY_ISSUE_622_CHAIN=1 make verify-issue-622P0 sell/buy/provide/limit green on a clean #620 seed; attach sell + buy screenshots; missing pins fail closed.make swarm-local/make swarm-launchshort soak:tax_listedextra-debit + buy split + routertrader+tax_hybrid_skip; gem workers never offer the tax token;SWARM_TAX_WORKERS=0is exclude-only.make verify-issue-293stillpool_only(do not add tax/EMBER to OE-1).make verify-issue-621·622·623stay green onmain. Optional:CODE_ID=11619 LAYER_B_LT=1 make verify-issue-589andmake verify-issue-601.Do not
layer-b-lt.shorRegisterListedPairthere (C623-1 / C589-5).test.skipthe e2e-tx spec when pins are missing (E622-2).AddWhitelistedCodeId11611 / 11619 / 8654 from LocalTerra evidence.Verify
marked as related to #621
marked as related to #622
marked as related to #623
marked as related to #624
mentioned in issue #624
Opened after merging !1133–!1135. Child issues #621 / #622 / #623 stay closed. Fresh #620 volume work remains on #624.
mentioned in commit
df759514fbVerify on
main(df759514)Landed leftover playbook M625-1–M625-8 / Q13,
make verify-issue-625, and live-path fixes. Children #621 / #622 / #623 / #620 stay closed. Fresh #620 volume leftovers stay on #624.What changed
pick_trader(same non-treasury wallet as sell).config.manageris not ExemptionDirectory-exempt when that SKU is off./poolCORS for Vite:3173, provide/place/cancel gas, place Send honest (declared - maker_fee), cancel refund buy-net (pair debit = remaining; do not assert wallet restore to pre-place).skim_min_return=1e15is cleared (0→ None) before the floor-success skim and restored after the probe.AGENTS_POST_MERGE_OPS_625.md,AGENTS_E2E_COMMUNITY_TAX_TX.md,AGENTS_CW20_CODE_ID_TAX_ON.md,AGENTS_COMMUNITY_TAX_AUTOLP.md,AGENTS_LOCALNET_SWARM_TAX.md.Checklist (issue body)
LAYER_B_TAX_ON=1 make verify-issue-623green on seed pins (buy split visible; AutoLP floor + hostile probe).VERIFY_ISSUE_622_CHAIN=1Playwright 5/5 P0 sell extra-debit + buy net + provide 1:1 + limit place/cancel + P1 Trade Market quote. Screenshots written locally asfrontend-dapp/test-results/community-tax-sell.pngandcommunity-tax-buy.png(GitLab upload API rejected the files). Missing pins still fail closed (E622-2).#624/#620volume (VERIFY625_SKIP_FRESH=1). Factory still lists leftover tax tokens.make swarm-launchsoak:tax_listedextra-debit / hybrid skip markers ontax-0; gems did not offer the pinned tax token;SWARM_TAX_WORKERS=0is exclude-only.make verify-issue-293OE-1 pool_only green (tax/EMBER not added to hub). Wrap preflight still reports0 USTC-Cindexer rows on this VM — not a tax leftover.make verify-issue-621·622·623green onmain.CODE_ID=11619 LAYER_B_LT=1 make verify-issue-589andmake verify-issue-601not re-run.Do not (confirmed)
No reopen of #621 / #622 / #623 / #620. B-lt stays tax-off. Hybrid stays on. No
test.skip. No columbus-5 11611 / 11619 / 8654 whitelist. No pair/router FoT math.Leaving open until a fresh
#624seed re-proves Playwright P0 and the ephemeral tax-on path. Re-run:mentioned in commit
eb852f4dc2Verify on
main(eb852f4d) — fresh#624seedWorktree:
issue-625-post-merge-leftovers. RanVERIFY625_FRESH=1 VERIFY625_REQUIRE_LIVE=1 VERIFY625_REQUIRE_CHAIN=1 make verify-issue-625aftermake reset && make deploy-local(deterministic #620/#624 seed, QA taxterra1fll72…/ pairterra13tt96…, treasury ≠ test1).Round 1 failed only M625-4 (45s soak: tax-0 RNG bought/limited while gem workers stormed test1 sequence). Fixed, reset infra, re-ran. Round 2: 17/17 PASS.
Children #621 / #622 / #623 / #620 stay closed.
What changed (
eb852f4d)LAYER_B_TAX_ON_FORCE_EPHEMERAL=1skips seed pins so a #624 volume still proves instantiate + buy-from-trader (distinctlayer-b-tax-on-ephemeral.json).tax-0starts before gem workers and warms uphybridthensell; leftover soak polls fortax_listed+tax_debit=+tax_hybrid_skip.AGENTS_POST_MERGE_OPS_625.mdM625-2 / M625-4,AGENTS_CW20_CODE_ID_TAX_ON.md,AGENTS_LOCALNET_SWARM_TAX.mdS621-2, Q13.Checklist (issue body + prior leftover comment)
buy_user=test1, treasury=test2).LAYER_B_TAX_ON=1green on seed pins (sell7B9C33C0…, buy0484B775…).LAYER_B_TAX_ON_FORCE_EPHEMERAL=1,source=ephemeral, tokenterra1xdxz…, buy3020B225…).VERIFY_ISSUE_622_CHAIN=1Playwright P0 on a fresh#624/#620volume (not leftover factory): sell extra-debit + buy net + provide 1:1 + limit place/cancel + P1 Trade Market. Screenshots:frontend-dapp/test-results/community-tax-sell.pngandcommunity-tax-buy.png. Missing pins still fail closed (E622-2).make swarm-launchsoak:tax_listed+tax_hybrid_skip+tax_debit=(pair sell 500 bps + router hop). Gems did not offer the pinned tax token.SWARM_TAX_WORKERS=0is exclude-only.make verify-issue-293OE-1 pool_only green (tax/EMBER not added to hub). Wrap preflight still reports0 USTC-Cindexer rows — not a tax leftover; stack treats OE-1 as the leftover.make verify-issue-621·622·623green onmain.make verify-issue-601green (includesCODE_ID=11611 LAYER_B_LT=1 make verify-issue-589). SeparateCODE_ID=11619 LAYER_B_LT=1not re-run this pass (optional; 11619 stays listed on columbus-5).Do not (confirmed)
No reopen of #621 / #622 / #623 / #620. B-lt stays tax-off. Hybrid stays on. No
test.skip. No columbus-5 11611 / 11619 / 8654 whitelist. No pair/router FoT math.Re-run:
mentioned in issue #626