Raise default route impact / slippage protection from 0.5% to 5% #497

New issue

Closed

opened 2026-07-15 04:07:49 +00:00 by PlasticDigits · 11 comments

PlasticDigits commented

2026-07-15 04:07:49 +00:00

(Migrated from gitlab.com)

Summary

Default frontend slippage / route impact protection is 0.5%, which is too low. The protection used for the insufficient-liquidity (route impact) warning should default to 5%, not 0.5%.

Current behavior

Zustand store default: slippageTolerance: 0.5 in frontend-dapp/src/stores/dex.ts.
That value is passed on-chain as max_spread (slippageTolerance / 100) and drives the Swap insufficient-liquidity copy:

Route impact exceeds your {slippageTolerance}% protection — try a smaller amount or another route.
With a 0.5% default, normal trade sizes often trip the preflight / insufficient-liquidity warning even when liquidity is acceptable for retail users.

Expected behavior

Default slippageTolerance should be 5 (5%).
Insufficient-liquidity / route-impact warning should use that 5% default unless the user changes Settings.
Confirm UI presets / tests that hard-code 0.5% as the default (e.g. Swap / Trade confirm max-spread expectations) are updated accordingly.

Relevant files

frontend-dapp/src/stores/dex.ts — slippageTolerance: 0.5
frontend-dapp/src/pages/SwapPage.tsx — insufficient liquidity warning + settings presets [0.1, 0.5, 1.0]
frontend-dapp/src/components/trade/TradeMarketOrderPanel.tsx — trade surface uses same store default
Tests asserting confirm max-spread 0.5% (Swap / Trade pre-submit summaries)

Acceptance criteria

Default protection is 5% for new sessions / unset store state.
Insufficient liquidity warning reflects 5% unless user overrides.
Unit / UI tests updated for the new default.

## Summary Default frontend **slippage / route impact protection** is **0.5%**, which is too low. The protection used for the insufficient-liquidity (route impact) warning should default to **5%**, not **0.5%**. ## Current behavior - Zustand store default: `slippageTolerance: 0.5` in `frontend-dapp/src/stores/dex.ts`. - That value is passed on-chain as `max_spread` (`slippageTolerance / 100`) and drives the Swap insufficient-liquidity copy: > Route impact exceeds your {slippageTolerance}% protection — try a smaller amount or another route. - With a 0.5% default, normal trade sizes often trip the preflight / insufficient-liquidity warning even when liquidity is acceptable for retail users. ## Expected behavior - Default `slippageTolerance` should be **5** (5%). - Insufficient-liquidity / route-impact warning should use that 5% default unless the user changes Settings. - Confirm UI presets / tests that hard-code `0.5%` as the default (e.g. Swap / Trade confirm max-spread expectations) are updated accordingly. ## Relevant files - `frontend-dapp/src/stores/dex.ts` — `slippageTolerance: 0.5` - `frontend-dapp/src/pages/SwapPage.tsx` — insufficient liquidity warning + settings presets `[0.1, 0.5, 1.0]` - `frontend-dapp/src/components/trade/TradeMarketOrderPanel.tsx` — trade surface uses same store default - Tests asserting confirm max-spread `0.5%` (Swap / Trade pre-submit summaries) ## Acceptance criteria - [ ] Default protection is 5% for new sessions / unset store state. - [ ] Insufficient liquidity warning reflects 5% unless user overrides. - [ ] Unit / UI tests updated for the new default.

Rows
Columns