code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

QA: Review indexer–frontend dapp integration (main @ 5712a44) #43

New issue
Closed
opened 2026-03-25 12:28:40 +00:00 by PlasticDigits · 2 comments
PlasticDigits commented 2026-03-25 12:28:40 +00:00 (Migrated from gitlab.com)
Copy link

Context

Please QA the frontend changes merged on main that wire the dapp to more of the indexer HTTP API (commit 5712a44).

Branch: main (pushed)

Scope (files touched)

  • frontend-dapp/src/App.tsx — routes /trader, /trader/:address, /protocol
  • frontend-dapp/src/components/charts/PriceChart.tsx — 1w candle interval
  • frontend-dapp/src/components/common/Layout.tsx — nav: Trader, Protocol
  • frontend-dapp/src/components/wallet/WalletButton.tsx — Trader profile link
  • frontend-dapp/src/hooks/useTokenDisplayInfo.ts — indexer token logos/symbols (shared query)
  • frontend-dapp/src/pages/ChartsPage.tsx — overview USD + USTC, pair sort/pagination, getPair when selection off-page
  • frontend-dapp/src/pages/PoolPage.tsx — indexed token count in header
  • frontend-dapp/src/pages/ProtocolPage.tsx — new — USTC oracle + history, hook events table
  • frontend-dapp/src/pages/SwapPage.tsx — Settings: indexer route check vs client route
  • frontend-dapp/src/pages/TraderPage.tsx — optional address param
  • frontend-dapp/src/services/indexer/client.ts — new API helpers
  • frontend-dapp/src/types/index.ts — indexer types

QA checklist

Environment

  • VITE_INDEXER_URL points at a running indexer (or default http://localhost:3001 for local)
  • Wallet connects to intended Terra Classic network

Charts (/charts)

  • Overview shows six stats including 24h Volume (USD) and USTC / USD (or em dash if indexer omits fields)
  • Pair list: sort (default 24h volume desc) and order work; pagination appears when >50 pairs
  • Selecting a pair on another page still resolves (loading line or merged row) via single-pair fetch
  • Price chart includes 1w interval and loads candles without errors

Protocol (/protocol)

  • USTC/USD oracle section shows snapshot and sources when indexer returns data
  • Recent USTC/USD history table loads (or empty/error states are acceptable)
  • Hook events table loads; optional filter by hook contract works (debounced)

Pool (/pool)

  • Header shows indexed tokens count when indexer responds
  • Pool cards still show 24h volume; token labels/logos look sane (indexer + fallbacks)

Swap (/)

  • Open Settings → Indexer route check runs for two CW20 tokens; Compare indexer route shows hops
  • Error copy for non-CW20 / native-only paths is clear
  • When a client multihop route exists, Client hops count appears next to indexer hops

Trader

  • Nav Trader and /trader open search/empty state; /trader/:addr loads profile
  • Wallet menu Trader profile navigates to connected address

Regression

  • No console errors on navigation between Swap, Pool, Charts, Protocol, Trader, Tiers, Create Pair
  • npm run build passes (CI)

Notes

  • Indexer route solver only resolves tokens present as CW20 rows in the indexer asset table (see in-app copy).
  • Pair TWAP on Charts remains on-chain pair oracle; Protocol page is protocol-level USTC/USD from the indexer.

/cc @brouie

## Context Please QA the frontend changes merged on `main` that wire the dapp to more of the indexer HTTP API (commit `5712a44`). **Branch:** `main` (pushed) ## Scope (files touched) - `frontend-dapp/src/App.tsx` — routes `/trader`, `/trader/:address`, `/protocol` - `frontend-dapp/src/components/charts/PriceChart.tsx` — `1w` candle interval - `frontend-dapp/src/components/common/Layout.tsx` — nav: Trader, Protocol - `frontend-dapp/src/components/wallet/WalletButton.tsx` — Trader profile link - `frontend-dapp/src/hooks/useTokenDisplayInfo.ts` — indexer token logos/symbols (shared query) - `frontend-dapp/src/pages/ChartsPage.tsx` — overview USD + USTC, pair sort/pagination, `getPair` when selection off-page - `frontend-dapp/src/pages/PoolPage.tsx` — indexed token count in header - `frontend-dapp/src/pages/ProtocolPage.tsx` — **new** — USTC oracle + history, hook events table - `frontend-dapp/src/pages/SwapPage.tsx` — Settings: indexer route check vs client route - `frontend-dapp/src/pages/TraderPage.tsx` — optional `address` param - `frontend-dapp/src/services/indexer/client.ts` — new API helpers - `frontend-dapp/src/types/index.ts` — indexer types ## QA checklist ### Environment - [ ] `VITE_INDEXER_URL` points at a running indexer (or default `http://localhost:3001` for local) - [ ] Wallet connects to intended Terra Classic network ### Charts (`/charts`) - [ ] Overview shows six stats including **24h Volume (USD)** and **USTC / USD** (or em dash if indexer omits fields) - [ ] Pair list: **sort** (default 24h volume desc) and **order** work; **pagination** appears when >50 pairs - [ ] Selecting a pair on another page still resolves (loading line or merged row) via single-pair fetch - [ ] Price chart includes **1w** interval and loads candles without errors ### Protocol (`/protocol`) - [ ] USTC/USD oracle section shows snapshot and **sources** when indexer returns data - [ ] **Recent USTC/USD history** table loads (or empty/error states are acceptable) - [ ] **Hook events** table loads; optional filter by hook contract works (debounced) ### Pool (`/pool`) - [ ] Header shows **indexed tokens** count when indexer responds - [ ] Pool cards still show 24h volume; token labels/logos look sane (indexer + fallbacks) ### Swap (`/`) - [ ] Open **Settings** → **Indexer route check** runs for two **CW20** tokens; **Compare indexer route** shows hops - [ ] Error copy for non-CW20 / native-only paths is clear - [ ] When a client multihop route exists, **Client hops** count appears next to indexer hops ### Trader - [ ] Nav **Trader** and `/trader` open search/empty state; `/trader/:addr` loads profile - [ ] Wallet menu **Trader profile** navigates to connected address ### Regression - [ ] No console errors on navigation between Swap, Pool, Charts, Protocol, Trader, Tiers, Create Pair - [ ] `npm run build` passes (CI) ## Notes - Indexer route solver **only** resolves tokens present as CW20 rows in the indexer asset table (see in-app copy). - Pair TWAP on Charts remains **on-chain** pair oracle; **Protocol** page is **protocol-level** USTC/USD from the indexer. /cc @brouie
PlasticDigits commented 2026-03-25 12:28:41 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @Brouie

assigned to @Brouie
Brouie commented 2026-04-01 06:00:41 +00:00 (Migrated from gitlab.com)
Copy link

verified -- indexer-frontend integration working on 117efc3. swap EMBER/CORAL successful (tx confirmed). pool reserves, fee, price impact, min received all populating from indexer. limit book leg toggle and indexer route check present in settings. high price impact correctly rejected by contract (9.17% spread > 2% tolerance on ONYX/CORAL). limit orders indexer showing placed orders (#42 confirmed separately).

verified -- indexer-frontend integration working on 117efc3. swap EMBER/CORAL successful (tx confirmed). pool reserves, fee, price impact, min received all populating from indexer. limit book leg toggle and indexer route check present in settings. high price impact correctly rejected by contract (9.17% spread > 2% tolerance on ONYX/CORAL). limit orders indexer showing placed orders (#42 confirmed separately).
Brouie (Migrated from gitlab.com) closed this issue 2026-04-01 06:01:18 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/tokio-util-0.x-lockfile
renovate/thiserror-2.x-lockfile
renovate/serde_json-1.x-lockfile
renovate/serde-monorepo
renovate/libc-0.x-lockfile
renovate/chrono-0.x-lockfile
cac-design-issue-1206
cac-design-issue-1317
cac-design-issue-1316
cac-design-issue-1311
cac-design-issue-1300
cac-design-issue-1306
cac-design-issue-1305
cac-design-issue-1302
cac-design-issue-1277
No results found.
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic#43
No description provided.